fix(legacy): fix Polkadot signing issues (#172)

Author: somebodyLi

legacy/firmware/polkadot.c

@@ -133,7 +133,7 @@ static bool layoutPolkadotSign(char *signer) {
 
 static bool get_signer_address(const PolkadotSignTx *msg, const HDNode *node,
                                char *address) {
-  uint16_t addressType = 0;
+  uint16_t addressType = 42;
   if (!strncmp(msg->network, "polkadot", 8)) {
     addressType = 0;
   } else if (!strncmp(msg->network, "kusama", 6)) {
@@ -146,8 +146,6 @@ static bool get_signer_address(const PolkadotSignTx *msg, const HDNode *node,
     addressType = 126;
   } else if (!strncmp(msg->network, "manta", 5)) {
     addressType = 77;
-  } else {
-    return false;
   }
   polkadot_get_address_from_public_key(node->public_key + 1, address,
                                        addressType);
@@ -162,7 +160,7 @@ bool polkadot_sign_tx(const PolkadotSignTx *msg, const HDNode *node,
     layoutHome();
     return false;
   }
-
+  memzero(polkadot_network, sizeof(polkadot_network));
   memcpy(polkadot_network, msg->network, strlen(msg->network) + 1);
   parser_error_t ret = polkadot_tx_parse(msg->raw_tx.bytes, msg->raw_tx.size);
   if (ret == parser_unexpected_callIndex) {

legacy/firmware/polkadot/parser_impl.c

@@ -33,12 +33,5 @@ parser_error_t _polkadot_readTx(parser_context_t *c, parser_tx_t *v,
       return parser_unexpected_value;
     }
   }
-  if (c->offset < c->bufferLen) {
-    return parser_unexpected_unparsed_bytes;
-  }
-
-  if (c->offset > c->bufferLen) {
-    return parser_unexpected_buffer_end;
-  }
   return parser_ok;
 }

legacy/firmware/polkadot/parser_impl_common.c

@@ -343,6 +343,8 @@ uint16_t _getAddressType() { return __address_type; }
 uint16_t _detectAddressType(const parser_context_t *c) {
   (void)c;
   memset(__polkadot_ticker, 0, sizeof(__polkadot_ticker));
+  memcpy(__polkadot_ticker, " UNKN", 5);
+  __polkadot_decimal = 0;
   if (!strncmp(polkadot_network, "polkadot", 8)) {
     __polkadot_decimal = COIN_AMOUNT_DECIMAL_PLACES;
     memcpy(__polkadot_ticker, COIN_TICKER, 4);
@@ -368,7 +370,7 @@ uint16_t _detectAddressType(const parser_context_t *c) {
     memcpy(__polkadot_ticker, MANTA_COIN_TICKER, 6);
     return 77;
   }
-
+  memcpy(polkadot_network, "unkn Chain", 11);
   return 42;
 }