fix(legacy): stellar adaption and support for ada testnet message signing

Author: somebodyLi

common/protob/messages-cardano.proto

@@ -538,6 +538,7 @@ message CardanoSignMessage {
     required CardanoDerivationType derivation_type = 3;
     required uint32 network_id = 4;                                 // network id - mainnet or testnet
     optional CardanoAddressType address_type = 5;                   // one of the CardanoAddressType
+    optional uint32 protocol_magic = 6;                             // network's protocol magic - needed for Byron addresses on testnets
 }
 
 /**

legacy/firmware/ada.c

@@ -1981,7 +1981,9 @@ bool ada_sign_messages(const CardanoSignMessage *msg,
     fsm_sendFailure(FailureType_Failure_ProcessError, "Deriving root failed");
     return false;
   }
-  if (!derive_bytes(&address_params, msg->network_id, MAINNET_PROTOCOL_MAGIC,
+  if (!derive_bytes(&address_params, msg->network_id,
+                    msg->has_protocol_magic ? msg->protocol_magic
+                                            : MAINNET_PROTOCOL_MAGIC,
                     address_bytes, &address_bytes_len)) {
     return false;
   }

legacy/firmware/ethereum_onekey.c

@@ -55,7 +55,7 @@ static bool eip1559;
 static struct SHA3_CTX keccak_ctx = {0};
 
 static uint32_t signing_access_list_count;
-static EthereumAccessListOneKey signing_access_list[8];
+static EthereumAccessListOneKey signing_access_list[16];
 _Static_assert(sizeof(signing_access_list) ==
                    sizeof(((EthereumSignTxEIP1559OneKey *)NULL)->access_list),
                "access_list buffer size mismatch");

legacy/firmware/fsm.c

@@ -301,9 +301,8 @@ static const CoinInfo *fsm_getCoin(bool has_name, const char *name) {
   return coin;
 }
 
-static HDNode *fsm_getDerivedNode(const char *curve, const uint32_t *address_n,
-                                  size_t address_n_count,
-                                  uint32_t *fingerprint) {
+HDNode *fsm_getDerivedNode(const char *curve, const uint32_t *address_n,
+                           size_t address_n_count, uint32_t *fingerprint) {
   static CONFIDENTIAL HDNode node;
   if (fingerprint) {
     *fingerprint = 0;

legacy/firmware/fsm_msg_ada.h

@@ -96,12 +96,12 @@ void fsm_msgCardanoGetAddress(CardanoGetAddress *msg) {
   if (msg->has_show_display && msg->show_display) {
     char desc[20] = {0};
     char addr_type[32] = {0};
-    snprintf(desc, 20, "Cardano %s", _("Address:"));
+    snprintf(desc, 20, "Cardano %s", _("Address"));
     if (msg->address_parameters.address_type == CardanoAddressType_BASE) {
-      snprintf(addr_type, 32, "Base %s", _("Address:"));
+      snprintf(addr_type, 32, "Base %s", _("Address"));
     } else if (msg->address_parameters.address_type ==
                CardanoAddressType_REWARD) {
-      snprintf(addr_type, 32, "Reward %s", _("Address:"));
+      snprintf(addr_type, 32, "Reward %s", _("Address"));
     }
     if (msg->address_parameters.address_n_count > 0) {
       if (!fsm_layoutAddress(resp->address, addr_type, desc, false, 0,
@@ -268,8 +268,9 @@ void fsm_msgCardanoSignMessage(CardanoSignMessage *msg) {
               "Invalid path");
   CHECK_PIN
 
-  if ((msg->network_id != 0) && (msg->network_id != 1)) {
-    fsm_sendFailure(FailureType_Failure_ProcessError, "Invalid Networ ID");
+  if (!msg->has_protocol_magic && (msg->network_id != 1)) {
+    fsm_sendFailure(FailureType_Failure_ProcessError,
+                    "Invalid Network ID, need protocol magic provide");
     return;
   }
   if (!ada_sign_messages(msg, resp)) {

legacy/firmware/fsm_msg_algorand.h

@@ -39,7 +39,7 @@ void fsm_msgAlgorandGetAddress(AlgorandGetAddress *msg) {
 
   if (msg->has_show_display && msg->show_display) {
     char desc[20] = {0};
-    snprintf(desc, 20, "%s %s", "Algorand", _("Address:"));
+    snprintf(desc, 20, "%s %s", "Algorand", _("Address"));
     if (!fsm_layoutAddress(resp->address, NULL, desc, false, 0, msg->address_n,
                            msg->address_n_count, true, NULL, 0, 0, NULL)) {
       return;

legacy/firmware/fsm_msg_aptos.h

@@ -40,8 +40,8 @@ void fsm_msgAptosGetAddress(const AptosGetAddress *msg) {
 
   if (msg->has_show_display && msg->show_display) {
     char desc[16] = {0};
-    strcat(desc, "Aptos");
-    strcat(desc, _("Address:"));
+    strcat(desc, "Aptos ");
+    strcat(desc, _("Address"));
     if (!fsm_layoutAddress(resp->address, NULL, desc, false, 0, msg->address_n,
                            msg->address_n_count, true, NULL, 0, 0, NULL)) {
       return;

legacy/firmware/fsm_msg_coin.h

@@ -308,7 +308,7 @@ void fsm_msgGetAddress(const GetAddress *msg) {
     } else {
       strcat(desc, coin->coin_name);
       strcat(desc, " ");
-      strlcpy(desc + strlen(desc), _("Address:"), sizeof(desc));
+      strlcpy(desc + strlen(desc), _("Address"), sizeof(desc));
     }
 
     uint32_t multisig_xpub_magic = coin->xpub_magic;

legacy/firmware/fsm_msg_conflux.h

@@ -66,7 +66,7 @@ void fsm_msgConfluxGetAddress(const ConfluxGetAddress *msg) {
   }
   if (msg->has_show_display && msg->show_display) {
     char desc[20] = {0};
-    snprintf(desc, 20, "%s %s", "Conflux", _("Address:"));
+    snprintf(desc, 20, "%s %s", "Conflux", _("Address"));
     if (!fsm_layoutAddress(resp->address, NULL, desc, false, 0, msg->address_n,
                            msg->address_n_count, false, NULL, 0, 0, NULL)) {
       return;

legacy/firmware/fsm_msg_cosmos.h

@@ -59,7 +59,7 @@ void fsm_msgCosmosGetAddress(CosmosGetAddress *msg) {
       strcat(desc, "Cosmos");
     }
     strcat(desc, " ");
-    strcat(desc, _("Address:"));
+    strcat(desc, _("Address"));
     if (!fsm_layoutAddress(resp->address, NULL, desc, false, 0, msg->address_n,
                            msg->address_n_count, true, NULL, 0, 0, NULL)) {
       return;