added permission constants

Author: david

src/main/java/net/onelitefeather/bettergopaint/BetterGoPaint.java

@@ -51,6 +51,11 @@ public class BetterGoPaint extends JavaPlugin implements Listener {
 
     public static final @NotNull String PAPER_DOCS = "https://jd.papermc.io/paper/1.20.6/org/bukkit/Material.html#enum-constant-summary";
 
+    public static final @NotNull String USE_PERMISSION = "bettergopaint.use";
+    public static final @NotNull String ADMIN_PERMISSION = "bettergopaint.admin";
+    public static final @NotNull String RELOAD_PERMISSION = "bettergopaint.command.admin.reload";
+    public static final @NotNull String WORLD_BYPASS_PERMISSION = "bettergopaint.world.bypass";
+
     private final @NotNull PlayerBrushManager brushManager = new PlayerBrushManager();
     private final @NotNull Metrics metrics = new Metrics(this, 18734);
 

src/main/java/net/onelitefeather/bettergopaint/command/GoPaintCommand.java

@@ -50,12 +50,12 @@ public boolean execute(
         }
         PlayerBrush pb = plugin.getBrushManager().getBrush(p);
         String prefix = Settings.settings().GENERIC.PREFIX;
-        if (!p.hasPermission("bettergopaint.use")) {
+        if (!p.hasPermission(BetterGoPaint.USE_PERMISSION)) {
             p.sendRichMessage(prefix + "<red>You are lacking the permission bettergopaint.use");
             return true;
         }
         if (args.length == 0) {
-            if (p.hasPermission("bettergopaint.admin")) {
+            if (p.hasPermission(BetterGoPaint.ADMIN_PERMISSION)) {
                 p.sendRichMessage(prefix + "<red>/gp size<gray>|<red>toggle<gray>|<red>info<gray>|<red>reload");
                 return true;
             }
@@ -75,7 +75,7 @@ public boolean execute(
                 }
                 return true;
             } else if ((args[0].equalsIgnoreCase("reload") || args[0].equalsIgnoreCase("r")) && p.hasPermission(
-                    "bettergopaint.admin")) {
+                    BetterGoPaint.ADMIN_PERMISSION)) {
                 plugin.reloadConfig();
                 p.sendRichMessage(prefix + "<green>Reloaded");
                 return true;
@@ -84,7 +84,7 @@ public boolean execute(
                 p.sendRichMessage(prefix + "<aqua>Links: <gold><click:open_url:https://twitter.com/themeinerlp'><u>Twitter</u></click>");
                 return true;
             }
-            if (p.hasPermission("bettergopaint.admin")) {
+            if (p.hasPermission(BetterGoPaint.ADMIN_PERMISSION)) {
                 p.sendRichMessage(prefix + "<red>/gp size<gray>|<red>toggle<gray>|<red>info<gray>|<red>reload");
                 return true;
             }
@@ -102,7 +102,7 @@ public boolean execute(
                     return true;
                 }
             }
-            if (p.hasPermission("bettergopaint.admin")) {
+            if (p.hasPermission(BetterGoPaint.ADMIN_PERMISSION)) {
                 p.sendRichMessage(prefix + "<red>/gp size<gray>|<red>toggle<gray>|<red>info<gray>|<red>reload");
                 return true;
             }

src/main/java/net/onelitefeather/bettergopaint/command/ReloadCommand.java

@@ -32,7 +32,7 @@ public ReloadCommand(final BetterGoPaint betterGoPaint) {
     }
 
     @Command("bgp|gp reload")
-    @Permission("bettergopaint.command.admin.reload")
+    @Permission(BetterGoPaint.RELOAD_PERMISSION)
     public void onReload(Player player) {
         betterGoPaint.reloadConfig();
     }

src/main/java/net/onelitefeather/bettergopaint/listeners/InteractListener.java

@@ -52,7 +52,7 @@ public InteractListener(BetterGoPaint plugin) {
     public void onClick(PlayerInteractEvent event) {
         Player player = event.getPlayer();
 
-        if (!player.hasPermission("bettergopaint.use")) {
+        if (!player.hasPermission(BetterGoPaint.USE_PERMISSION)) {
             return;
         }
 
@@ -85,7 +85,7 @@ public void onClick(PlayerInteractEvent event) {
             return;
         }
 
-        if (!player.hasPermission("bettergopaint.world.bypass") && Settings.settings().GENERIC.DISABLED_WORLDS
+        if (!player.hasPermission(BetterGoPaint.WORLD_BYPASS_PERMISSION) && Settings.settings().GENERIC.DISABLED_WORLDS
                 .contains(location.getWorld().getName())) {
             return;
         }