refactor(soundservice): replace dto parameter with uuid to unlink a sound source

Author: theEvilReaper

src/main/java/net/onelitefeather/vulpes/backend/controller/SoundController.java

@@ -376,7 +376,7 @@ public HttpResponse<SoundResponseDTO> updateSource(
     @Produces(MediaType.APPLICATION_JSON)
     public HttpResponse<SoundResponseDTO> deleteSource(
             @PathVariable("id") UUID soundEventId,
-            @Body SoundFileSourceDTO sourceDTO
+            @Body UUID sourceDTO
     ) {
         SoundResponseDTO result = soundService.deleteLinkedSource(soundEventId, sourceDTO);
         return HttpResponse.ok(result);

src/main/java/net/onelitefeather/vulpes/backend/service/SoundService.java

@@ -73,25 +73,28 @@ public interface SoundService {
 
     /**
      * Creates a new sound file source and links it to a sound event.
+     *
      * @param soundEventId the ID of the sound event to link the source to
-     * @param sourceDTO the source data to create
+     * @param sourceDTO    the source data to create
      * @return the created source response
      */
     SoundResponseDTO createAndLinkSource(UUID soundEventId, SoundFileSourceDTO sourceDTO);
 
     /**
      * Updates an existing sound file source linked to a sound event by ID.
+     *
      * @param soundEventId the ID of the sound event
-     * @param sourceDTO the source data to update
+     * @param sourceDTO    the source data to update
      * @return the updated source response
      */
     SoundResponseDTO updateLinkedSource(UUID soundEventId, SoundFileSourceDTO sourceDTO);
 
     /**
      * Deletes an existing sound file source linked to a sound event by ID.
+     *
      * @param soundEventId the ID of the sound event
-     * @param sourceDTO the source data to delete
+     * @param sourceId     the ID of the source to delete
      * @return the deleted source response
      */
-    SoundResponseDTO deleteLinkedSource(UUID soundEventId, SoundFileSourceDTO sourceDTO);
+    SoundResponseDTO deleteLinkedSource(UUID soundEventId, UUID sourceId);
 }

src/main/java/net/onelitefeather/vulpes/backend/service/impl/SoundServiceImpl.java

@@ -140,8 +140,8 @@ public SoundResponseDTO.SoundFileSourceDTO updateLinkedSource(UUID soundEventId,
 
     @Override
     @Transactional
-    public SoundResponseDTO.SoundFileSourceDTO deleteLinkedSource(UUID soundEventId, SoundFileSourceDTO sourceDTO) {
-        if (soundEventId == null || sourceDTO == null || sourceDTO.getId() == null) {
+    public SoundResponseDTO.SoundFileSourceDTO deleteLinkedSource(UUID soundEventId, UUID sourceID) {
+        if (soundEventId == null || sourceID == null) {
             throw new IllegalArgumentException("SoundEventId and SourceDTO and SourceDTO.Id must not be null");
         }
 
@@ -154,12 +154,12 @@ public SoundResponseDTO.SoundFileSourceDTO deleteLinkedSource(UUID soundEventId,
                 .stream()
                 .filter(SoundResponseDTO.SoundFileSourceDTO.class::isInstance)
                 .map(SoundResponseDTO.SoundFileSourceDTO.class::cast)
-                .filter(s -> s.id().equals(sourceDTO.getId()))
+                .filter(s -> s.id().equals(sourceID))
                 .findFirst();
         if (existingSourceOpt.isEmpty()) {
             throw new IllegalArgumentException("Sound source not found for the given sound event");
         }
-        soundFileSourceRepository.deleteById(sourceDTO.getId());
+        soundFileSourceRepository.deleteById(sourceID);
         return existingSourceOpt.get();
     }
 }

src/test/java/net/onelitefeather/vulpes/backend/controller/SoundControllerTest.java

@@ -76,7 +76,7 @@ public SoundResponseDTO.SoundFileSourceDTO updateLinkedSource(UUID soundEventId,
         }
 
         @Override
-        public SoundResponseDTO.SoundFileSourceDTO deleteLinkedSource(UUID soundEventId, SoundFileSourceDTO sourceDTO) {
+        public SoundResponseDTO.SoundFileSourceDTO deleteLinkedSource(UUID soundEventId, UUID sourceDTO) {
             return sourceResponse;
         }
     }