Skip to content

Commit 90b864b

Browse files
committed
chore: add more spans
1 parent fdf1be3 commit 90b864b

File tree

4 files changed

+20
-5
lines changed

4 files changed

+20
-5
lines changed

src/services/v1/field.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ use feedback_fusion_common::proto::{
3030
UpdateFieldRequest,
3131
};
3232

33+
#[instrument(skip_all)]
3334
pub async fn create_field(
3435
context: &FeedbackFusionV1Context,
3536
request: Request<CreateFieldRequest>,
@@ -51,6 +52,7 @@ pub async fn create_field(
5152
Ok(Response::new(field.into()))
5253
}
5354

55+
#[instrument(skip_all)]
5456
pub async fn get_active_fields(
5557
context: &PublicFeedbackFusionV1Context,
5658
request: Request<GetFieldsRequest>,
@@ -88,6 +90,7 @@ pub async fn get_active_fields(
8890
}))
8991
}
9092

93+
#[instrument(skip_all)]
9194
pub async fn get_fields(
9295
context: &FeedbackFusionV1Context,
9396
request: Request<GetFieldsRequest>,
@@ -117,6 +120,7 @@ pub async fn get_fields(
117120
}))
118121
}
119122

123+
#[instrument(skip_all)]
120124
pub async fn update_field(
121125
context: &FeedbackFusionV1Context,
122126
request: Request<UpdateFieldRequest>,
@@ -144,6 +148,7 @@ pub async fn update_field(
144148
Ok(Response::new(field.into()))
145149
}
146150

151+
#[instrument(skip_all)]
147152
pub async fn delete_field(
148153
context: &FeedbackFusionV1Context,
149154
request: Request<DeleteFieldRequest>,

src/services/v1/mod.rs

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ macro_rules! handler {
8585
)*
8686
];
8787

88-
match policy.evaluate(
88+
match policy.evaluate(
8989
$request
9090
.extensions()
9191
.get::<OIDCClaims>()
@@ -96,7 +96,10 @@ macro_rules! handler {
9696
handler!($handler, $self, $request)
9797
},
9898
Err(_) => {
99-
let target = async $target.await;
99+
let target = info_span!("Extracting referenced target")
100+
.in_scope(|| async {
101+
async $target.await
102+
}).await;
100103

101104
match target {
102105
Ok(target) => {
@@ -107,7 +110,7 @@ macro_rules! handler {
107110
)*
108111
];
109112

110-
policy
113+
policy
111114
.evaluate(
112115
$request
113116
.extensions()
@@ -139,7 +142,7 @@ macro_rules! handler {
139142
}
140143

141144
}
142-
}
145+
}
143146
}
144147
}};
145148
($handler:path, $self:ident, $request:ident, $($scope:literal $(,)?)*) => {{
@@ -150,7 +153,7 @@ macro_rules! handler {
150153
)*
151154
];
152155

153-
policy
156+
policy
154157
.evaluate(
155158
$request
156159
.extensions()

src/services/v1/prompt.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ use feedback_fusion_common::proto::{
2727
};
2828
use validator::Validate;
2929

30+
#[instrument(skip_all)]
3031
pub async fn create_prompt(
3132
context: &FeedbackFusionV1Context,
3233
request: Request<CreatePromptRequest>,
@@ -47,6 +48,7 @@ pub async fn create_prompt(
4748
Ok(Response::new(prompt.into()))
4849
}
4950

51+
#[instrument(skip_all)]
5052
pub async fn get_prompt(
5153
context: &PublicFeedbackFusionV1Context,
5254
request: Request<GetPromptRequest>,
@@ -65,6 +67,7 @@ pub async fn get_prompt(
6567
}
6668
}
6769

70+
#[instrument(skip_all)]
6871
pub async fn get_prompts(
6972
context: &FeedbackFusionV1Context,
7073
request: Request<GetPromptsRequest>,
@@ -91,6 +94,7 @@ pub async fn get_prompts(
9194
}))
9295
}
9396

97+
#[instrument(skip_all)]
9498
pub async fn update_prompt(
9599
context: &FeedbackFusionV1Context,
96100
request: Request<UpdatePromptRequest>,
@@ -112,6 +116,7 @@ pub async fn update_prompt(
112116
Ok(Response::new(prompt.into()))
113117
}
114118

119+
#[instrument(skip_all)]
115120
pub async fn delete_prompt(
116121
context: &FeedbackFusionV1Context,
117122
request: Request<DeletePromptRequest>,

src/services/v1/response.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ use feedback_fusion_common::proto::{
3232
use rbatis::rbatis_codegen::IntoSql;
3333
use std::collections::HashMap;
3434

35+
#[instrument(skip_all)]
3536
pub async fn create_responses(
3637
context: &PublicFeedbackFusionV1Context,
3738
request: Request<CreateResponsesRequest>,
@@ -107,6 +108,7 @@ async fn field_responses(
107108
impled!()
108109
}
109110

111+
#[instrument(skip_all)]
110112
pub async fn get_responses(
111113
context: &FeedbackFusionV1Context,
112114
request: Request<GetResponsesRequest>,

0 commit comments

Comments
 (0)