Commit 1b4c0b2
AR Abdul Azeez
fix(test): stabilize prevent-default-twice notification generation tests
Remove notification.display() after the second preventDefault(true). The
display waiter uses a CONFLATED channel; display() wakes with true and
overwrites preventDefault(true)'s wake(false), so the processor could
still call displayNotification — flaky on fast CI (see PR #2605).
Clarify IOMockHelper KDoc: top-level launchOnIO is not stubbed; only
OneSignalDispatchers.launchOnIO is.
Made-with: Cursor1 parent f1a719d commit 1b4c0b2
2 files changed
Lines changed: 4 additions & 3 deletions
File tree
- OneSignalSDK/onesignal
- notifications/src/test/java/com/onesignal/notifications/internal/generation
- testhelpers/src/main/java/com/onesignal/mocks
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
288 | 288 | | |
289 | 289 | | |
290 | 290 | | |
| 291 | + | |
| 292 | + | |
291 | 293 | | |
292 | | - | |
293 | 294 | | |
294 | 295 | | |
295 | 296 | | |
| |||
311 | 312 | | |
312 | 313 | | |
313 | 314 | | |
314 | | - | |
315 | 315 | | |
316 | 316 | | |
317 | 317 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
| 35 | + | |
35 | 36 | | |
36 | 37 | | |
37 | 38 | | |
| |||
0 commit comments