nit(style): fix spotless formatting and core detekt issues

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: nan-li

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/backend/impl/FeatureFlagsBackendService.kt

@@ -3,6 +3,7 @@ package com.onesignal.core.internal.backend.impl
 import com.onesignal.common.OneSignalUtils
 import com.onesignal.core.internal.backend.IFeatureFlagsBackendService
 import com.onesignal.core.internal.backend.RemoteFeatureFlagsFetchOutcome
+import com.onesignal.core.internal.http.HttpResponse
 import com.onesignal.core.internal.http.IHttpClient
 import com.onesignal.debug.LogLevel
 import com.onesignal.debug.internal.logging.Logging
@@ -43,8 +44,11 @@ internal class FeatureFlagsBackendService(
                 platform = TURBINE_FEATURES_PLATFORM_ANDROID,
                 sdkVersion = sdkVersion,
             )
+        return mapResponseToOutcome(http.get(path, null))
+    }
 
-        val response = http.get(path, null)
+    @Suppress("ReturnCount")
+    private fun mapResponseToOutcome(response: HttpResponse): RemoteFeatureFlagsFetchOutcome {
         val body = response.payload
         if (!response.isSuccess) {
             val msg =
@@ -56,12 +60,9 @@ internal class FeatureFlagsBackendService(
             return RemoteFeatureFlagsFetchOutcome.Unavailable
         }
         if (body.isNullOrBlank()) {
-            Logging.warn(
-                "FeatureFlagsBackendService: empty body for success status=${response.statusCode}",
-            )
+            Logging.warn("FeatureFlagsBackendService: empty body for success status=${response.statusCode}")
             return RemoteFeatureFlagsFetchOutcome.Unavailable
         }
-
         val parsed = FeatureFlagsJsonParser.parseSuccessful(body)
         return if (parsed != null) {
             RemoteFeatureFlagsFetchOutcome.Success(parsed)

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/backend/impl/FeatureFlagsJsonParser.kt

@@ -59,6 +59,7 @@ internal object FeatureFlagsJsonParser {
         }
     }
 
+    @Suppress("ReturnCount")
     private fun parseRootStrict(root: JsonObject): RemoteFeatureFlagsResult? {
         val featuresEl = root[FEATURES_PROPERTY] ?: return null
         val featuresArray = featuresEl as? JsonArray ?: return null
@@ -88,6 +89,7 @@ internal object FeatureFlagsJsonParser {
         return RemoteFeatureFlagsResult(keys, metaOut)
     }
 
+    @Suppress("ReturnCount")
     private fun findSiblingJsonObject(
         root: JsonObject,
         rawKeyFromFeaturesArray: String,
@@ -127,6 +129,7 @@ internal object FeatureFlagsJsonParser {
      * Decodes [ConfigModel.sdkRemoteFeatureFlagMetadata] (a JSON object of flag id → object) into a map.
      * Non-object values are skipped so each entry stays a [JsonObject] for nested decoding (e.g. with `Json.decodeFromJsonElement`).
      */
+    @Suppress("ReturnCount")
     fun parseStoredMetadataMap(raw: String?): Map<String, JsonObject> {
         if (raw.isNullOrBlank()) {
             return emptyMap()

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/backend/impl/TurbineSdkFeatureFlagsPath.kt

@@ -34,28 +34,36 @@ internal object TurbineSdkFeatureFlagsPath {
      */
     internal fun percentEncodePathSegmentUtf8(segment: String): String {
         val bytes = segment.encodeToByteArray()
-        return buildString(bytes.size * 3) {
+        return buildString(bytes.size * PERCENT_ENCODED_MAX_CHARS_PER_BYTE) {
             for (b in bytes) {
-                val u = b.toInt() and 0xff
+                val u = b.toInt() and BYTE_MASK
                 if (isUnreservedByte(u)) {
                     append(u.toChar())
                 } else {
                     append('%')
-                    append(HEX_DIGITS[u shr 4])
-                    append(HEX_DIGITS[u and 15])
+                    append(HEX_DIGITS[u shr NIBBLE_BITS])
+                    append(HEX_DIGITS[u and LOW_NIBBLE_MASK])
                 }
             }
         }
     }
 
-    private fun isUnreservedByte(u: Int): Boolean =
-        u in 0x41..0x5A ||
-            u in 0x61..0x7A ||
-            u in 0x30..0x39 ||
-            u == 0x2D ||
-            u == 0x2E ||
-            u == 0x5F ||
-            u == 0x7E
+    private fun isUnreservedByte(u: Int): Boolean {
+        val c = u.toChar()
+        return c in 'A'..'Z' ||
+            c in 'a'..'z' ||
+            c in '0'..'9' ||
+            c == '-' ||
+            c == '.' ||
+            c == '_' ||
+            c == '~'
+    }
 
     private const val HEX_DIGITS = "0123456789ABCDEF"
+    private const val BYTE_MASK = 0xFF
+    private const val NIBBLE_BITS = 4
+    private const val LOW_NIBBLE_MASK = 0x0F
+
+    // Worst-case characters per byte when percent-encoding: "%HH".
+    private const val PERCENT_ENCODED_MAX_CHARS_PER_BYTE = 3
 }

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/config/impl/FeatureFlagsRefreshService.kt

@@ -90,20 +90,27 @@ internal class FeatureFlagsRefreshService(
                         }
                         val appId = configModelStore.model.appId
                         if (appId.isNotEmpty()) {
-                            try {
-                                fetchAndApply(appId)
-                            } catch (e: CancellationException) {
-                                throw e
-                            } catch (e: Exception) {
-                                Logging.warn("FeatureFlagsRefreshService: fetch failed", e)
-                            }
+                            runFetchAndApplySafely(appId)
                         }
                         delay(REFRESH_INTERVAL_MS)
                     }
                 }
         }
     }
 
+    // Broad catch: the polling loop must not die on any per-iteration failure (HTTP, parsing,
+    // etc.). CancellationException is rethrown so structured concurrency still works.
+    @Suppress("TooGenericExceptionCaught")
+    private suspend fun runFetchAndApplySafely(appId: String) {
+        try {
+            fetchAndApply(appId)
+        } catch (e: CancellationException) {
+            throw e
+        } catch (e: Exception) {
+            Logging.warn("FeatureFlagsRefreshService: fetch failed", e)
+        }
+    }
+
     private suspend fun fetchAndApply(appId: String) {
         val result =
             when (val outcome = featureFlagsBackend.fetchRemoteFeatureFlags(appId)) {

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/features/FeatureManager.kt

@@ -90,7 +90,7 @@ internal class FeatureManager(
             (
                 model.sdkRemoteFeatureFlags.map { canonicalizeFeatureKey(it) } +
                     localFeatureOverrides.map { canonicalizeFeatureKey(it) }
-            ).toSet()
+                ).toSet()
         if (localFeatureOverrides.isNotEmpty()) {
             Logging.warn(
                 "OneSignal: Local feature override enabled for testing only: $localFeatureOverrides",

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/preferences/impl/PreferencesService.kt

@@ -241,11 +241,13 @@ internal class PreferencesService(
         }
 
     @Synchronized
+    @Suppress("TooGenericExceptionCaught", "SwallowedException")
     private fun getSharedPrefsByName(store: String): SharedPreferences? {
         return try {
             _applicationService.appContext.getSharedPreferences(store, Context.MODE_PRIVATE)
         } catch (t: Throwable) {
-            // App context may not be ready yet during early startup.
+            // App context may not be ready yet during early startup. Any access failure here is
+            // recoverable — callers tolerate null and retry on the next tick.
             null
         }
     }

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/internal/OneSignalImp.kt

@@ -381,7 +381,7 @@ internal class OneSignalImp(
             suspendifyOnIO { loginHelper.login(externalId, jwtBearerToken) }
         } else {
             if (!isInitialized) {
-                throw IllegalStateException("Must call 'initWithContext' before 'login'")
+                error("Must call 'initWithContext' before 'login'")
             }
             Thread {
                 runBlocking(runtimeIoDispatcher) {
@@ -399,7 +399,7 @@ internal class OneSignalImp(
             suspendifyOnIO { logoutHelper.logout() }
         } else {
             if (!isInitialized) {
-                throw IllegalStateException("Must call 'initWithContext' before 'logout'")
+                error("Must call 'initWithContext' before 'logout'")
             }
             Thread {
                 runBlocking(runtimeIoDispatcher) {
@@ -520,7 +520,7 @@ internal class OneSignalImp(
             if (isInitialized) {
                 getter()
             } else {
-                throw IllegalStateException("Must call 'initWithContext' before use")
+                error("Must call 'initWithContext' before use")
             }
         }
     }

OneSignalSDK/onesignal/core/src/test/java/com/onesignal/core/internal/features/FeatureManagerTests.kt

@@ -7,10 +7,10 @@ import com.onesignal.core.internal.config.ConfigModelStore
 import io.kotest.core.spec.style.FunSpec
 import io.kotest.matchers.shouldBe
 import io.mockk.every
-import kotlinx.serialization.json.jsonPrimitive
 import io.mockk.just
 import io.mockk.mockk
 import io.mockk.runs
+import kotlinx.serialization.json.jsonPrimitive
 
 class FeatureManagerTests : FunSpec({
     beforeEach {