|
1 | | -<?xml version="1.0" ?> |
| 1 | +<?xml version='1.0' encoding='UTF-8'?> |
2 | 2 | <SmellBaseline> |
3 | | - <ManuallySuppressedIssues></ManuallySuppressedIssues> |
| 3 | + <ManuallySuppressedIssues/> |
4 | 4 | <CurrentIssues> |
5 | | - <ID>ComplexCondition:SummaryNotificationDisplayer.kt$SummaryNotificationDisplayer$updateSummary && summaryList.size > 1 || !updateSummary && summaryList.size > 0</ID> |
| 5 | + <ID>ComplexCondition:SummaryNotificationDisplayer.kt$SummaryNotificationDisplayer$updateSummary && summaryList.size > 1 || !updateSummary && summaryList.size > 0</ID> |
6 | 6 | <ID>ComplexMethod:NotificationChannelManager.kt$NotificationChannelManager$@RequiresApi(api = Build.VERSION_CODES.O) @Throws( JSONException::class, ) private fun createChannel( context: Context, notificationManager: NotificationManager, payload: JSONObject, ): String</ID> |
7 | 7 | <ID>ComplexMethod:NotificationGenerationProcessor.kt$NotificationGenerationProcessor$override suspend fun processNotificationData( context: Context, androidNotificationId: Int, jsonPayload: JSONObject, isRestoring: Boolean, timestamp: Long, )</ID> |
8 | 8 | <ID>ComplexMethod:SummaryNotificationDisplayer.kt$SummaryNotificationDisplayer$override suspend fun createSummaryNotification( notificationJob: NotificationGenerationJob, notifBuilder: NotificationDisplayBuilder.OneSignalNotificationBuilder?, groupAlertBehavior: Int, )</ID> |
|
128 | 128 | <ID>LongMethod:NotificationGenerationProcessor.kt$NotificationGenerationProcessor$private suspend fun saveNotification( notificationJob: NotificationGenerationJob, opened: Boolean, )</ID> |
129 | 129 | <ID>LongMethod:NotificationLifecycleService.kt$NotificationLifecycleService$override suspend fun notificationOpened( activity: Activity, data: JSONArray, )</ID> |
130 | 130 | <ID>LongMethod:NotificationRepository.kt$NotificationRepository$override suspend fun createNotification( id: String, groupId: String?, collapseKey: String?, shouldDismissIdenticals: Boolean, isOpened: Boolean, androidId: Int, title: String?, body: String?, expireTime: Long, jsonPayload: String, )</ID> |
131 | | - <ID>LongMethod:NotificationRepository.kt$NotificationRepository$override suspend fun listNotificationsForGroup(summaryGroup: String): List<INotificationRepository.NotificationData></ID> |
132 | | - <ID>LongMethod:NotificationRepository.kt$NotificationRepository$override suspend fun listNotificationsForOutstanding(excludeAndroidIds: List<Int>?): List<INotificationRepository.NotificationData></ID> |
| 131 | + <ID>LongMethod:NotificationRepository.kt$NotificationRepository$override suspend fun listNotificationsForGroup(summaryGroup: String): List<INotificationRepository.NotificationData></ID> |
| 132 | + <ID>LongMethod:NotificationRepository.kt$NotificationRepository$override suspend fun listNotificationsForOutstanding(excludeAndroidIds: List<Int>?): List<INotificationRepository.NotificationData></ID> |
133 | 133 | <ID>LongMethod:NotificationRepository.kt$NotificationRepository$override suspend fun markAsConsumed( androidId: Int, dismissed: Boolean, summaryGroup: String?, clearGroupOnSummaryClick: Boolean, )</ID> |
134 | 134 | <ID>LongMethod:NotificationsModule.kt$NotificationsModule$override fun register(builder: ServiceBuilder)</ID> |
135 | 135 | <ID>LongMethod:SummaryNotificationDisplayer.kt$SummaryNotificationDisplayer$@RequiresApi(api = Build.VERSION_CODES.M) override suspend fun createGrouplessSummaryNotification( notificationJob: NotificationGenerationJob, intentGenerator: IntentGeneratorForAttachingToNotifications, grouplessNotifCount: Int, groupAlertBehavior: Int, )</ID> |
136 | 136 | <ID>LongMethod:SummaryNotificationDisplayer.kt$SummaryNotificationDisplayer$override suspend fun createSummaryNotification( notificationJob: NotificationGenerationJob, notifBuilder: NotificationDisplayBuilder.OneSignalNotificationBuilder?, groupAlertBehavior: Int, )</ID> |
137 | 137 | <ID>LongParameterList:INotificationGenerationWorkManager.kt$INotificationGenerationWorkManager$( context: Context, osNotificationId: String, androidNotificationId: Int, jsonPayload: JSONObject?, timestamp: Long, isRestoring: Boolean, isHighPriority: Boolean, )</ID> |
138 | 138 | <ID>LongParameterList:INotificationRepository.kt$INotificationRepository$( id: String, groupId: String?, collapseKey: String?, shouldDismissIdenticals: Boolean, isOpened: Boolean, androidId: Int, title: String?, body: String?, expireTime: Long, jsonPayload: String, )</ID> |
139 | 139 | <ID>LongParameterList:NotificationLifecycleService.kt$NotificationLifecycleService$( private val _applicationService: IApplicationService, private val _time: ITime, private val _configModelStore: ConfigModelStore, private val _influenceManager: IInfluenceManager, private val _subscriptionManager: ISubscriptionManager, private val _deviceService: IDeviceService, private val _backend: INotificationBackendService, private val _receiveReceiptWorkManager: IReceiveReceiptWorkManager, private val _analyticsTracker: IAnalyticsTracker, )</ID> |
140 | | - <ID>LoopWithTooManyJumpStatements:NotificationLifecycleService.kt$NotificationLifecycleService$for (i in 0 until data.length()) { val notificationId = NotificationFormatHelper.getOSNotificationIdFromJson(data[i] as JSONObject?) ?: continue if (postedOpenedNotifIds.contains(notificationId)) { continue } postedOpenedNotifIds.add(notificationId) suspendifyWithErrorHandling( useIO = true, // or false for CPU operations block = { _backend.updateNotificationAsOpened( appId, notificationId, subscriptionId, deviceType, ) }, onError = { ex -> if (ex is BackendException) { Logging.error("Notification opened confirmation failed with statusCode: ${ex.statusCode} response: ${ex.response}") } else { Logging.error("Unexpected error in notification opened confirmation", ex) } }, ) }</ID> |
| 140 | + <ID>LoopWithTooManyJumpStatements:NotificationLifecycleService.kt$NotificationLifecycleService$for (i in 0 until data.length()) { val notificationId = NotificationFormatHelper.getOSNotificationIdFromJson(data[i] as JSONObject?) ?: continue if (postedOpenedNotifIds.contains(notificationId)) { continue } postedOpenedNotifIds.add(notificationId) suspendifyWithErrorHandling( useIO = true, // or false for CPU operations block = { _backend.updateNotificationAsOpened( appId, notificationId, subscriptionId, deviceType, ) }, onError = { ex -> if (ex is BackendException) { Logging.error("Notification opened confirmation failed with statusCode: ${ex.statusCode} response: ${ex.response}") } else { Logging.error("Unexpected error in notification opened confirmation", ex) } }, ) }</ID> |
141 | 141 | <ID>MagicNumber:FirebaseAnalyticsTracker.kt$FirebaseAnalyticsTracker$1000</ID> |
142 | 142 | <ID>MagicNumber:FirebaseAnalyticsTracker.kt$FirebaseAnalyticsTracker$30</ID> |
143 | 143 | <ID>MagicNumber:FirebaseAnalyticsTracker.kt$FirebaseAnalyticsTracker$60</ID> |
|
164 | 164 | <ID>MagicNumber:NotificationDisplayer.kt$NotificationDisplayer$5000</ID> |
165 | 165 | <ID>MagicNumber:NotificationGenerationProcessor.kt$NotificationGenerationProcessor$1000</ID> |
166 | 166 | <ID>MagicNumber:NotificationGenerationProcessor.kt$NotificationGenerationProcessor$1000L</ID> |
167 | | - <ID>MagicNumber:NotificationGenerationProcessor.kt$NotificationGenerationProcessor$30000L</ID> |
168 | 167 | <ID>MagicNumber:NotificationGenerationWorkManager.kt$NotificationGenerationWorkManager.NotificationGenerationWorker$1000L</ID> |
169 | 168 | <ID>MagicNumber:NotificationHelper.kt$NotificationHelper$10</ID> |
170 | 169 | <ID>MagicNumber:NotificationQueryHelper.kt$NotificationQueryHelper$1000L</ID> |
|
214 | 213 | <ID>ReturnCount:NotificationHelper.kt$NotificationHelper$fun getNotificationIdFromFCMJson(fcmJson: JSONObject?): String?</ID> |
215 | 214 | <ID>ReturnCount:NotificationLifecycleService.kt$NotificationLifecycleService$private fun shouldInitDirectSessionFromNotificationOpen(context: Activity): Boolean</ID> |
216 | 215 | <ID>ReturnCount:NotificationPermissionController.kt$NotificationPermissionController$override suspend fun prompt(fallbackToSettings: Boolean): Boolean</ID> |
217 | | - <ID>ReturnCount:NotificationRestoreProcessor.kt$NotificationRestoreProcessor$private fun getVisibleNotifications(): List<Int>?</ID> |
| 216 | + <ID>ReturnCount:NotificationRestoreProcessor.kt$NotificationRestoreProcessor$private fun getVisibleNotifications(): List<Int>?</ID> |
218 | 217 | <ID>ReturnCount:NotificationRestoreWorkManager.kt$NotificationRestoreWorkManager.NotificationRestoreWorker$override suspend fun doWork(): Result</ID> |
219 | 218 | <ID>ReturnCount:NotificationSummaryManager.kt$NotificationSummaryManager$private suspend fun internalUpdateSummaryNotificationAfterChildRemoved( group: String, dismissed: Boolean, )</ID> |
220 | 219 | <ID>ReturnCount:PushRegistratorAbstractGoogle.kt$PushRegistratorAbstractGoogle$override suspend fun registerForPush(): IPushRegistrator.RegisterResult</ID> |
221 | 220 | <ID>ReturnCount:PushRegistratorAbstractGoogle.kt$PushRegistratorAbstractGoogle$private suspend fun attemptRegistration( senderId: String, currentRetry: Int, ): IPushRegistrator.RegisterResult?</ID> |
222 | | - <ID>ReturnCount:PushRegistratorHMS.kt$PushRegistratorHMS$@Synchronized @Throws(ApiException::class) private suspend fun getHMSTokenTask(context: Context): IPushRegistrator.RegisterResult</ID> |
| 221 | + <ID>ReturnCount:PushRegistratorHMS.kt$PushRegistratorHMS$@Throws(ApiException::class) private suspend fun getHMSTokenTask(context: Context): IPushRegistrator.RegisterResult</ID> |
223 | 222 | <ID>ReturnCount:ReceiveReceiptWorkManager.kt$ReceiveReceiptWorkManager.ReceiveReceiptWorker$override suspend fun doWork(): Result</ID> |
224 | 223 | <ID>StringLiteralDuplication:NotificationGenerationProcessor.kt$NotificationGenerationProcessor$"collapse_key"</ID> |
225 | 224 | <ID>StringLiteralDuplication:NotificationRepository.kt$NotificationRepository$" = 0 AND "</ID> |
|
280 | 279 | <ID>UndocumentedPublicClass:NotificationsManager.kt$INotificationActivityOpener</ID> |
281 | 280 | <ID>UndocumentedPublicClass:OSWorkManagerHelper.kt$OSWorkManagerHelper</ID> |
282 | 281 | <ID>UndocumentedPublicClass:UpgradeReceiver.kt$UpgradeReceiver : BroadcastReceiver</ID> |
| 282 | + <ID>UndocumentedPublicFunction:INotificationDisplayer.kt$INotificationDisplayer$suspend fun displayNotification(notificationJob: NotificationGenerationJob): Boolean</ID> |
| 283 | + <ID>UndocumentedPublicFunction:INotificationLifecycleCallback.kt$INotificationLifecycleCallback$suspend fun canOpenNotification( activity: Activity, jsonData: JSONObject, ): Boolean</ID> |
| 284 | + <ID>UndocumentedPublicFunction:INotificationLifecycleService.kt$INotificationLifecycleService$fun addExternalClickListener(listener: INotificationClickListener)</ID> |
| 285 | + <ID>UndocumentedPublicFunction:INotificationLifecycleService.kt$INotificationLifecycleService$fun addExternalForegroundLifecycleListener(listener: INotificationLifecycleListener)</ID> |
| 286 | + <ID>UndocumentedPublicFunction:INotificationLifecycleService.kt$INotificationLifecycleService$fun externalNotificationWillShowInForeground(willDisplayEvent: INotificationWillDisplayEvent)</ID> |
| 287 | + <ID>UndocumentedPublicFunction:INotificationLifecycleService.kt$INotificationLifecycleService$fun externalRemoteNotificationReceived(notificationReceivedEvent: INotificationReceivedEvent)</ID> |
| 288 | + <ID>UndocumentedPublicFunction:INotificationLifecycleService.kt$INotificationLifecycleService$fun removeExternalClickListener(listener: INotificationClickListener)</ID> |
| 289 | + <ID>UndocumentedPublicFunction:INotificationLifecycleService.kt$INotificationLifecycleService$fun removeExternalForegroundLifecycleListener(listener: INotificationLifecycleListener)</ID> |
| 290 | + <ID>UndocumentedPublicFunction:INotificationLifecycleService.kt$INotificationLifecycleService$fun setInternalNotificationLifecycleCallback(callback: INotificationLifecycleCallback?)</ID> |
| 291 | + <ID>UndocumentedPublicFunction:INotificationLifecycleService.kt$INotificationLifecycleService$suspend fun canOpenNotification( activity: Activity, data: JSONObject, ): Boolean</ID> |
| 292 | + <ID>UndocumentedPublicFunction:INotificationLifecycleService.kt$INotificationLifecycleService$suspend fun canReceiveNotification(jsonPayload: JSONObject): Boolean</ID> |
| 293 | + <ID>UndocumentedPublicFunction:INotificationLifecycleService.kt$INotificationLifecycleService$suspend fun notificationOpened( activity: Activity, data: JSONArray, )</ID> |
| 294 | + <ID>UndocumentedPublicFunction:INotificationLifecycleService.kt$INotificationLifecycleService$suspend fun notificationReceived(notificationJob: NotificationGenerationJob)</ID> |
| 295 | + <ID>UndocumentedPublicFunction:Notification.kt$Notification$fun hasNotificationId(): Boolean</ID> |
| 296 | + <ID>UndocumentedPublicFunction:Notification.kt$Notification$fun toJSONObject(): JSONObject</ID> |
| 297 | + <ID>UndocumentedPublicFunction:Notification.kt$Notification.ActionButton$fun toJSONObject(): JSONObject</ID> |
| 298 | + <ID>UndocumentedPublicFunction:NotificationGenerationJob.kt$NotificationGenerationJob$fun hasExtender(): Boolean</ID> |
| 299 | + <ID>UndocumentedPublicFunction:NotificationHelper.kt$NotificationHelper$@Throws(JSONException::class) fun getCustomJSONObject(jsonObject: JSONObject): JSONObject</ID> |
| 300 | + <ID>UndocumentedPublicFunction:NotificationHelper.kt$NotificationHelper$fun getCampaignNameFromNotification(notification: INotification): String</ID> |
| 301 | + <ID>UndocumentedPublicFunction:NotificationHelper.kt$NotificationHelper$fun getNotificationIdFromFCMJson(fcmJson: JSONObject?): String?</ID> |
| 302 | + <ID>UndocumentedPublicFunction:NotificationHelper.kt$NotificationHelper$fun getNotificationManager(context: Context): NotificationManager</ID> |
| 303 | + <ID>UndocumentedPublicFunction:NotificationHelper.kt$NotificationHelper$fun getSoundUri( context: Context, sound: String?, ): Uri?</ID> |
| 304 | + <ID>UndocumentedPublicFunction:NotificationHelper.kt$NotificationHelper$fun isGroupSummary(notif: StatusBarNotification): Boolean</ID> |
| 305 | + <ID>UndocumentedPublicFunction:NotificationHelper.kt$NotificationHelper$fun parseVibrationPattern(fcmBundle: JSONObject): LongArray?</ID> |
| 306 | + <ID>UndocumentedPublicFunction:NotificationsManager.kt$INotificationActivityOpener$suspend fun openDestinationActivity( activity: Activity, pushPayloads: JSONArray, )</ID> |
| 307 | + <ID>UndocumentedPublicFunction:OneSignalHmsEventBridge.kt$OneSignalHmsEventBridge$fun onMessageReceived( context: Context, message: RemoteMessage, )</ID> |
283 | 308 | <ID>UnusedPrivateMember:DeviceRegistrationListener.kt$DeviceRegistrationListener$val pushSubscription = _subscriptionManager.subscriptions.push</ID> |
284 | | - <ID>UnusedPrivateMember:NotificationDisplayBuilder.kt$NotificationDisplayBuilder$private fun addAlertButtons( context: Context, fcmJson: JSONObject, buttonsLabels: MutableList<String>, buttonsIds: MutableList<String>, )</ID> |
| 309 | + <ID>UnusedPrivateMember:NotificationDisplayBuilder.kt$NotificationDisplayBuilder$private fun addAlertButtons( context: Context, fcmJson: JSONObject, buttonsLabels: MutableList<String>, buttonsIds: MutableList<String>, )</ID> |
285 | 310 | <ID>UnusedPrivateMember:NotificationOpenedProcessor.kt$NotificationOpenedProcessor$private fun newContentValuesWithConsumed(intent: Intent): ContentValues</ID> |
286 | 311 | <ID>UnusedPrivateMember:OneSignalHmsEventBridge.kt$OneSignalHmsEventBridge$context: Context</ID> |
| 312 | + <ID>VariableNaming:NotificationGenerationProcessor.kt$NotificationGenerationProcessor$private val EXTERNAL_CALLBACKS_TIMEOUT get() = 30_000L</ID> |
287 | 313 | </CurrentIssues> |
288 | 314 | </SmellBaseline> |
0 commit comments