Skip to content

Commit 96bdf40

Browse files
abdulraqeeb33AR Abdul Azeez
andauthored
fix: R8 AutoValue + Huawei CI (cherry-pick #2592) (#2593)
Co-authored-by: AR Abdul Azeez <abdul@onesignal.com>
1 parent 596b94d commit 96bdf40

3 files changed

Lines changed: 10 additions & 3 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ jobs:
3232
working-directory: OneSignalSDK
3333
run: |
3434
./gradlew testDebugUnitTest --console=plain --continue
35-
- name: "[Build] Demo app (minified release)"
35+
- name: "[Build] Demo app (minified GMS + Huawei release)"
3636
working-directory: OneSignalSDK
3737
run: |
38-
./gradlew :app:assembleGmsRelease --console=plain
38+
./gradlew :app:assembleGmsRelease :app:assembleHuaweiRelease --console=plain
3939
- name: "[Diff Coverage] Check for bypass"
4040
id: coverage_bypass
4141
run: |
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
# OpenTelemetry OTLP exporter references Jackson core classes that are optional on Android.
22
# Suppress R8 missing-class errors when apps don't include jackson-core.
33
-dontwarn com.fasterxml.jackson.core.**
4+
5+
# OTel / disk buffering reference Google Auto Value types that are not on the app classpath.
6+
-dontwarn com.google.auto.value.AutoValue
7+
-dontwarn com.google.auto.value.AutoValue$Builder
8+
-dontwarn com.google.auto.value.AutoValue$CopyAnnotations

examples/demo/app/proguard-rules.pro

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@
2020
# hide the original source file name.
2121
#-renamesourcefileattribute SourceFile
2222

23-
# Demo-only suppression for optional OTel transitive classes.
23+
# Demo-only: optional transitive classes pulled in via OneSignal OTel / R8 (GMS + Huawei minified builds).
2424
-dontwarn com.fasterxml.jackson.core.JsonFactory
2525
-dontwarn com.fasterxml.jackson.core.JsonGenerator
26+
-dontwarn com.google.auto.value.AutoValue
27+
-dontwarn com.google.auto.value.AutoValue$Builder
2628
-dontwarn com.google.auto.value.AutoValue$CopyAnnotations

0 commit comments

Comments
 (0)