Merge pull request #2055 from OneSignal/improve/op-repo-never-set-flush

[Improvement] Never set OperationRepo.enqueue's flush to true

Author: jkasten2

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/operations/impl/OperationRepo.kt

@@ -110,6 +110,7 @@ internal class OperationRepo(
         return waiter.waitForWake()
     }
 
+    // WARNING: Never set to true, until budget rules are added, even for internal use!
     private fun internalEnqueue(
         queueItem: OperationQueueItem,
         flush: Boolean,

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/internal/OneSignalImp.kt

@@ -380,7 +380,6 @@ internal class OneSignalImp : IOneSignal, IServiceProvider {
                         externalId,
                         if (currentIdentityExternalId == null) currentIdentityOneSignalId else null,
                     ),
-                    true,
                 )
 
             if (!result) {
@@ -395,7 +394,6 @@ internal class OneSignalImp : IOneSignal, IServiceProvider {
                         configModel!!.appId,
                         identityModelStore!!.model.onesignalId,
                     ),
-                    true,
                 )
             }
         }

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/migrations/RecoverFromDroppedLoginBug.kt

@@ -79,7 +79,6 @@ class RecoverFromDroppedLoginBug(
                 _identityModelStore.model.externalId,
                 null,
             ),
-            true,
         )
     }
 }