only consider retrying on 404, don't include 410

If the backend returns 410 then it indicates it knows it existed at one
point and it is deleted now. Where a 404 is more abstract.

Author: jkasten2

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/operations/impl/executors/IdentityOperationExecutor.kt

@@ -69,7 +69,7 @@ internal class IdentityOperationExecutor(
                     NetworkUtils.ResponseStatusType.UNAUTHORIZED ->
                         ExecutionResponse(ExecutionResult.FAIL_UNAUTHORIZED)
                     NetworkUtils.ResponseStatusType.MISSING -> {
-                        if (_newRecordState.isInMissingRetryWindow(lastOperation.onesignalId)) {
+                        if (ex.statusCode == 404 && _newRecordState.isInMissingRetryWindow(lastOperation.onesignalId)) {
                             return ExecutionResponse(ExecutionResult.FAIL_RETRY)
                         }
 
@@ -109,7 +109,7 @@ internal class IdentityOperationExecutor(
                     NetworkUtils.ResponseStatusType.UNAUTHORIZED ->
                         ExecutionResponse(ExecutionResult.FAIL_UNAUTHORIZED)
                     NetworkUtils.ResponseStatusType.MISSING -> {
-                        return if (_newRecordState.isInMissingRetryWindow(lastOperation.onesignalId)) {
+                        return if (ex.statusCode == 404 && _newRecordState.isInMissingRetryWindow(lastOperation.onesignalId)) {
                             ExecutionResponse(ExecutionResult.FAIL_RETRY)
                         } else {
                             // This means either the User or the Alias was already

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/operations/impl/executors/RefreshUserOperationExecutor.kt

@@ -137,7 +137,7 @@ internal class RefreshUserOperationExecutor(
                 NetworkUtils.ResponseStatusType.UNAUTHORIZED ->
                     ExecutionResponse(ExecutionResult.FAIL_UNAUTHORIZED)
                 NetworkUtils.ResponseStatusType.MISSING -> {
-                    if (_newRecordState.isInMissingRetryWindow(op.onesignalId)) {
+                    if (ex.statusCode == 404 && _newRecordState.isInMissingRetryWindow(op.onesignalId)) {
                         return ExecutionResponse(ExecutionResult.FAIL_RETRY)
                     }
                     val operations = _buildUserService.getRebuildOperationsIfCurrentUser(op.appId, op.onesignalId)

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/operations/impl/executors/SubscriptionOperationExecutor.kt

@@ -138,7 +138,7 @@ internal class SubscriptionOperationExecutor(
                 NetworkUtils.ResponseStatusType.UNAUTHORIZED ->
                     ExecutionResponse(ExecutionResult.FAIL_UNAUTHORIZED)
                 NetworkUtils.ResponseStatusType.MISSING -> {
-                    if (_newRecordState.isInMissingRetryWindow(createOperation.onesignalId)) {
+                    if (ex.statusCode == 404 && _newRecordState.isInMissingRetryWindow(createOperation.onesignalId)) {
                         return ExecutionResponse(ExecutionResult.FAIL_RETRY)
                     }
                     val operations = _buildUserService.getRebuildOperationsIfCurrentUser(createOperation.appId, createOperation.onesignalId)
@@ -183,7 +183,8 @@ internal class SubscriptionOperationExecutor(
                 NetworkUtils.ResponseStatusType.RETRYABLE ->
                     ExecutionResponse(ExecutionResult.FAIL_RETRY)
                 NetworkUtils.ResponseStatusType.MISSING -> {
-                    if (listOf(
+                    if (ex.statusCode == 404 &&
+                        listOf(
                             lastOperation.onesignalId,
                             lastOperation.subscriptionId,
                         ).any { _newRecordState.isInMissingRetryWindow(it) }
@@ -262,7 +263,12 @@ internal class SubscriptionOperationExecutor(
 
             return when (responseType) {
                 NetworkUtils.ResponseStatusType.MISSING -> {
-                    if (listOf(op.onesignalId, op.subscriptionId).any { _newRecordState.isInMissingRetryWindow(it) }) {
+                    if (ex.statusCode == 404 &&
+                        listOf(
+                            op.onesignalId,
+                            op.subscriptionId,
+                        ).any { _newRecordState.isInMissingRetryWindow(it) }
+                    ) {
                         ExecutionResponse(ExecutionResult.FAIL_RETRY)
                     } else {
                         // if the subscription is missing, we are good!

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/operations/impl/executors/UpdateUserOperationExecutor.kt

@@ -165,7 +165,7 @@ internal class UpdateUserOperationExecutor(
                     NetworkUtils.ResponseStatusType.UNAUTHORIZED ->
                         ExecutionResponse(ExecutionResult.FAIL_UNAUTHORIZED)
                     NetworkUtils.ResponseStatusType.MISSING -> {
-                        if (_newRecordState.isInMissingRetryWindow(onesignalId)) {
+                        if (ex.statusCode == 404 && _newRecordState.isInMissingRetryWindow(onesignalId)) {
                             return ExecutionResponse(ExecutionResult.FAIL_RETRY)
                         }
                         val operations = _buildUserService.getRebuildOperationsIfCurrentUser(appId, onesignalId)