Detect timezone changes on new sessions

Tack onto existing SessionListener's TrackSessionStartOperation call so this update would be combined. Otherwise, because the TrackSessionStartOperation has flush = true, the timing may mean 2 user update requests are made when it could be combined.

Cons: the Session Listener is encroaching  beyond what its scope should be.

Author: nan-li

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/session/internal/session/impl/SessionListener.kt

@@ -11,6 +11,7 @@ import com.onesignal.session.internal.session.ISessionService
 import com.onesignal.user.internal.identity.IdentityModelStore
 import com.onesignal.user.internal.operations.TrackSessionEndOperation
 import com.onesignal.user.internal.operations.TrackSessionStartOperation
+import com.onesignal.user.internal.properties.PropertiesModelStore
 
 /**
  * The [SessionListener] is responsible for subscribing itself as an [ISessionLifecycleHandler]
@@ -33,13 +34,16 @@ internal class SessionListener(
     private val _sessionService: ISessionService,
     private val _configModelStore: ConfigModelStore,
     private val _identityModelStore: IdentityModelStore,
+    private val _propertiesModelStore: PropertiesModelStore,
     private val _outcomeEventsController: IOutcomeEventsController,
 ) : IStartableService, ISessionLifecycleHandler {
     override fun start() {
         _sessionService.subscribe(this)
     }
 
     override fun onSessionStarted() {
+        // Detect any user updates to send with the TrackSessionStartOperation
+        _propertiesModelStore.model.update()
         _operationRepo.enqueue(TrackSessionStartOperation(_configModelStore.model.appId, _identityModelStore.model.onesignalId), true)
     }
 

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/properties/PropertiesModel.kt

@@ -1,5 +1,6 @@
 package com.onesignal.user.internal.properties
 
+import com.onesignal.common.TimeUtils
 import com.onesignal.common.modeling.MapModel
 import com.onesignal.common.modeling.Model
 import org.json.JSONObject
@@ -122,4 +123,8 @@ class PropertiesModel : Model() {
 
         return null
     }
+
+    fun update() {
+        timezone = TimeUtils.getTimeZoneId()
+    }
 }