Skip to content

Conversation

@jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Dec 1, 2025

Description

One Line Summary

Remove sleep and delay from most OperationRepoTests tests.

Details

There are 2 edge-cases where delays needed to be kept, see the test code comments.

Motivation

Sleep and delay are not as reliable (in most cases) and/or slow the tests down.

Scope

Only effects operation repo tests

Testing

Unit testing

No new test, updated existing ones.

Manual testing

N/A

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Remove sleep and delay from most OperationRepoTests tests as they are
not as reliable and slow the tests down, in most cases.
* There are 2 edge-cases where delays needed to be kept
Copy link
Contributor

@jinliu9508 jinliu9508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from fix-flaky-operationrepo-execution-order to main December 1, 2025 21:22
@jkasten2 jkasten2 merged commit 5054a44 into main Dec 1, 2025
1 check passed
@jkasten2 jkasten2 deleted the chore-tests_clean-up-delays-on-operation-repo-tests branch December 1, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants