Skip to content

Conversation

@jinliu9508
Copy link
Contributor

@jinliu9508 jinliu9508 commented Dec 1, 2025

Description

One Line Summary

Fix a flaky test in StartupServiceTests that constantly failed.

Details

Scope

In the original test, there was no guarantee that all start calls in the scheduleStart will be delay. The fix add a block trigger to ensure that scheduleStart doesn't block the main thread even one of the start calls is blocking.

Testing

Unit testing

Fixed a flaky test in StartupServiceTests

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@jinliu9508 jinliu9508 force-pushed the chore-flaky-startupservice-test branch from 1e833ce to 98962cd Compare December 1, 2025 21:25
@jinliu9508
Copy link
Contributor Author

Rebased for the recent change

@jinliu9508 jinliu9508 merged commit 6f2d264 into main Dec 1, 2025
1 of 2 checks passed
@jinliu9508 jinliu9508 deleted the chore-flaky-startupservice-test branch December 1, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants