Skip to content

Chore: Tests: fix a flaky test in StartupServiceTests #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2025
Merged

Chore: Tests: fix a flaky test in StartupServiceTests #2498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions ...K/onesignal/core/src/test/java/com/onesignal/core/internal/startup/StartupServiceTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,15 @@ import com.onesignal.common.services.ServiceBuilder
import com.onesignal.common.services.ServiceProvider
import com.onesignal.debug.LogLevel
import com.onesignal.debug.internal.logging.Logging
import com.onesignal.mocks.IOMockHelper
import io.kotest.assertions.throwables.shouldThrowUnit
import io.kotest.core.spec.style.FunSpec
import io.kotest.matchers.shouldBe
import io.mockk.coVerifyOrder
import io.mockk.every
import io.mockk.mockk
import io.mockk.spyk
import io.mockk.verify
import kotlinx.coroutines.CompletableDeferred

class StartupServiceTests : FunSpec({
fun setupServiceProvider(
Expand All @@ -26,6 +27,8 @@ class StartupServiceTests : FunSpec({
return serviceBuilder.build()
}

listener(IOMockHelper)

beforeAny {
Logging.logLevel = LogLevel.NONE
}
Expand Down Expand Up @@ -97,21 +100,22 @@ class StartupServiceTests : FunSpec({
// Given
val mockStartableService1 = spyk<IStartableService>()
val mockStartableService2 = spyk<IStartableService>()
val mockStartableService3 = spyk<IStartableService>()
val startupService = StartupService(setupServiceProvider(listOf(), listOf(mockStartableService1)))

val startupService = StartupService(setupServiceProvider(listOf(), listOf(mockStartableService1, mockStartableService2)))
// Block the scheduled services until we're ready
val blockTrigger = CompletableDeferred<Unit>()
every { mockStartableService1.start() } coAnswers {
blockTrigger.await() // Block until released
}

// When
startupService.scheduleStart()
mockStartableService3.start()
mockStartableService2.start()

// Then
Thread.sleep(10)
coVerifyOrder {
// service3 will call start() first even though service1 and service2 are scheduled first
mockStartableService3.start()
mockStartableService1.start()
mockStartableService2.start()
}
// service2 does not block even though service1 is blocked
verify(exactly = 1) { mockStartableService2.start() }
blockTrigger.complete(Unit)
verify { mockStartableService1.start() }
}
})