pr feedback

Author: fadi-george

www/DebugNamespace.test.ts

@@ -14,48 +14,42 @@ describe('Debug', () => {
   });
 
   test.each([
-    [LogLevel.None, 'None'],
-    [LogLevel.Fatal, 'Fatal'],
-    [LogLevel.Error, 'Error'],
-    [LogLevel.Warn, 'Warn'],
-    [LogLevel.Info, 'Info'],
-    [LogLevel.Debug, 'Debug'],
-    [LogLevel.Verbose, 'Verbose'],
-  ])(
-    'should call cordova.exec for setLogLevel with %s',
-    (logLevel, levelName) => {
-      debug.setLogLevel(logLevel);
+    [LogLevel.None],
+    [LogLevel.Fatal],
+    [LogLevel.Error],
+    [LogLevel.Warn],
+    [LogLevel.Info],
+    [LogLevel.Debug],
+    [LogLevel.Verbose],
+  ])('should call cordova.exec for setLogLevel with %s', (logLevel) => {
+    debug.setLogLevel(logLevel);
 
-      expect(window.cordova.exec).toHaveBeenCalledWith(
-        expect.any(Function),
-        expect.any(Function),
-        'OneSignalPush',
-        'setLogLevel',
-        [logLevel],
-      );
-    },
-  );
+    expect(window.cordova.exec).toHaveBeenCalledWith(
+      expect.any(Function),
+      expect.any(Function),
+      'OneSignalPush',
+      'setLogLevel',
+      [logLevel],
+    );
+  });
 
   test.each([
-    [LogLevel.None, 'None'],
-    [LogLevel.Fatal, 'Fatal'],
-    [LogLevel.Error, 'Error'],
-    [LogLevel.Warn, 'Warn'],
-    [LogLevel.Info, 'Info'],
-    [LogLevel.Debug, 'Debug'],
-    [LogLevel.Verbose, 'Verbose'],
-  ])(
-    'should call cordova.exec for setAlertLevel with %s',
-    (logLevel, levelName) => {
-      debug.setAlertLevel(logLevel);
+    [LogLevel.None],
+    [LogLevel.Fatal],
+    [LogLevel.Error],
+    [LogLevel.Warn],
+    [LogLevel.Info],
+    [LogLevel.Debug],
+    [LogLevel.Verbose],
+  ])('should call cordova.exec for setAlertLevel with %s', (logLevel) => {
+    debug.setAlertLevel(logLevel);
 
-      expect(window.cordova.exec).toHaveBeenCalledWith(
-        expect.any(Function),
-        expect.any(Function),
-        'OneSignalPush',
-        'setAlertLevel',
-        [logLevel],
-      );
-    },
-  );
+    expect(window.cordova.exec).toHaveBeenCalledWith(
+      expect.any(Function),
+      expect.any(Function),
+      'OneSignalPush',
+      'setAlertLevel',
+      [logLevel],
+    );
+  });
 });

www/InAppMessagesNamespace.test.ts

@@ -75,7 +75,7 @@ describe('InAppMessages', () => {
           [],
         );
 
-        // call to process listner
+        // call to process listener
         mockExec.mock.calls[0][0](data);
 
         expect(mockListener).toHaveBeenCalledWith(data);

www/NotificationsNamespace.ts

@@ -51,7 +51,6 @@ export default class Notifications {
     );
 
     this.addEventListener('permissionChange', (result) => {
-      console.log('permissionChange', result);
       this._permission = result;
     });
   }

www/PushSubscriptionNamespace.test.ts

@@ -43,7 +43,6 @@ describe('PushSubscription', () => {
       const listener = mockExec.mock.calls.find(
         (call) => call[3] === 'addPushSubscriptionObserver',
       )?.[0];
-      console.log(listener);
       listener?.({ current: { id: SUB_ID, token: SUB_TOKEN, optedIn: true } });
       expect(pushSubscription.id).toBe(SUB_ID);
     });
@@ -66,7 +65,6 @@ describe('PushSubscription', () => {
       const listener = mockExec.mock.calls.find(
         (call) => call[3] === 'addPushSubscriptionObserver',
       )?.[0];
-      console.log(listener);
       listener?.({ current: { id: SUB_ID, token: SUB_TOKEN, optedIn: true } });
       expect(pushSubscription.token).toBe(SUB_TOKEN);
     });

www/PushSubscriptionNamespace.ts

@@ -78,7 +78,6 @@ export default class PushSubscription {
     );
 
     this.addEventListener('change', (subscriptionChange) => {
-      console.log('subscriptionChange', subscriptionChange);
       this._id = subscriptionChange.current.id;
       this._token = subscriptionChange.current.token;
       this._optedIn = subscriptionChange.current.optedIn;