-
Notifications
You must be signed in to change notification settings - Fork 62
Unity SDK Custom Events #793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unity SDK Custom Events #793
Conversation
d6b78e1 to
7d7a571
Compare
jkasten2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is based on the branch name rel/5.2-beta can we rename this to 5.3-main?
- Since 5.3 is the native SDK version with custom events in it it, will make things a bit less confusing. Also will let us slot in JWT as
5.2-mainin the future to this repo.
We can then cut releases from 5.3-main, such as rel/5.3.0-alpha-01.
com.onesignal.unity.android/Runtime/Utilities/AndroidJavaObjectExtensions.cs
Outdated
Show resolved
Hide resolved
But JWT is lower priority so I think 5.2 beta is fine. |
fix bug with tomap
add default app id for example app
345866d to
ea8ae18
Compare
ea8ae18 to
e6a4b41
Compare
jkasten2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the #794 PR and rebasing it here, appreciate the yak shaving done here!
Description
One Line Summary
Details
TrackEventtoMapoverride to handle Dictionary<string, object>Dashboard logs:


Track event button:


Motivation
We want to allow using custom events for more platforms / sdks.
Scope
Adds a new method for the user namespace. Also updates the required android/ios versions.
Testing
Manual testing
Tested on ios and android emulators by switching build profiles and running them. See screenshots above.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is