Skip to content

Conversation

@fadi-george
Copy link
Collaborator

@fadi-george fadi-george commented Oct 7, 2025

Description

One Line Summary

  • adds custom events logic to the unity sdk

Details

  • updates unity example behavior script to now include trackEvent test example with complex properties
  • updates unity scene to have trackEvent button under login button for easy testing
  • updates AndroidUserManager to expose TrackEvent
  • updates AndroidJavaObjectExtentions to have a toMap override to handle Dictionary<string, object>
  • Updates ios dependency (OneSignaliOSDependencies.xml) to use 5.4 alpha 01
  • Updates android depedency (AndroidResolverDependencies) to use 5.3 alpha 01
  • Updates OneSignalUnityBridgeUser and iOUSUserManager to expose track event call from ios sdk

Dashboard logs:
Screenshot 2025-10-07 at 3 48 23 PM
Screenshot 2025-10-07 at 3 00 39 PM

Track event button:
Screenshot 2025-10-07 at 3 26 33 PM
Screenshot 2025-10-07 at 3 00 08 PM

Motivation

We want to allow using custom events for more platforms / sdks.

Scope

Adds a new method for the user namespace. Also updates the required android/ios versions.

Testing

Manual testing

Tested on ios and android emulators by switching build profiles and running them. See screenshots above.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@fadi-george fadi-george requested a review from jkasten2 October 7, 2025 22:51
@fadi-george fadi-george force-pushed the fadi/sdk-2963-add-custom-events-for-unity-package branch 2 times, most recently from d6b78e1 to 7d7a571 Compare October 7, 2025 22:56
@fadi-george fadi-george changed the base branch from main to rel/5.2-beta October 7, 2025 23:10
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is based on the branch name rel/5.2-beta can we rename this to 5.3-main?

  • Since 5.3 is the native SDK version with custom events in it it, will make things a bit less confusing. Also will let us slot in JWT as 5.2-main in the future to this repo.

We can then cut releases from 5.3-main, such as rel/5.3.0-alpha-01.

@fadi-george
Copy link
Collaborator Author

This PR is based on the branch name rel/5.2-beta can we rename this to 5.3-main?

  • Since 5.3 is the native SDK version with custom events in it it, will make things a bit less confusing. Also will let us slot in JWT as 5.2-main in the future to this repo.

We can then cut releases from 5.3-main, such as rel/5.3.0-alpha-01.

But JWT is lower priority so I think 5.2 beta is fine.

@fadi-george fadi-george force-pushed the fadi/sdk-2963-add-custom-events-for-unity-package branch 2 times, most recently from 345866d to ea8ae18 Compare October 8, 2025 21:43
@fadi-george fadi-george force-pushed the fadi/sdk-2963-add-custom-events-for-unity-package branch from ea8ae18 to e6a4b41 Compare October 8, 2025 21:48
@fadi-george fadi-george requested a review from jkasten2 October 8, 2025 21:48
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the #794 PR and rebasing it here, appreciate the yak shaving done here!

@fadi-george fadi-george merged commit 58ebe11 into rel/5.2-beta Oct 8, 2025
2 checks passed
@fadi-george fadi-george deleted the fadi/sdk-2963-add-custom-events-for-unity-package branch October 8, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants