Add location prompt handling for IAM clicks (#629)

Jeasmine · Jeasmine · commit 02b7060ef218 · 2020-03-18T20:53:45.000-03:00
* Add location prompt to IAM action
   * Show location prompt when available
   * Show multiple prompts when available
   * Add completionHandler to promptLocation
   * Add test for prompt and multiple prompts
   * Pause IAM display if user prompt displayed
   * Wait for app to be active for IAM evaluation
diff --git a/iOS_SDK/OneSignalSDK/OneSignal.xcodeproj/project.pbxproj b/iOS_SDK/OneSignalSDK/OneSignal.xcodeproj/project.pbxproj
@@ -99,6 +99,9 @@
 		7A9173A2231971E5007848FA /* OneSignalReceiveReceiptsController.m in Sources */ = {isa = PBXBuildFile; fileRef = 7A9173A1231971E5007848FA /* OneSignalReceiveReceiptsController.m */; };
 		7AA2848A2406FC6400C25D76 /* OSInAppMessageTag.m in Sources */ = {isa = PBXBuildFile; fileRef = 7A1F2D8E2406EFC5007799A9 /* OSInAppMessageTag.m */; };
 		7AA2848B2406FC6500C25D76 /* OSInAppMessageTag.m in Sources */ = {isa = PBXBuildFile; fileRef = 7A1F2D8E2406EFC5007799A9 /* OSInAppMessageTag.m */; };
+		7AD172382416D53B00A78B19 /* OSInAppMessageLocationPrompt.m in Sources */ = {isa = PBXBuildFile; fileRef = 7AD172372416D53B00A78B19 /* OSInAppMessageLocationPrompt.m */; };
+		7AD172392416D53B00A78B19 /* OSInAppMessageLocationPrompt.m in Sources */ = {isa = PBXBuildFile; fileRef = 7AD172372416D53B00A78B19 /* OSInAppMessageLocationPrompt.m */; };
+		7AD1723A2416D53B00A78B19 /* OSInAppMessageLocationPrompt.m in Sources */ = {isa = PBXBuildFile; fileRef = 7AD172372416D53B00A78B19 /* OSInAppMessageLocationPrompt.m */; };
 		7AD8DDE7234BD3BE00747A8A /* OneSignalUserDefaults.m in Sources */ = {isa = PBXBuildFile; fileRef = 7AD8DDE6234BD3BE00747A8A /* OneSignalUserDefaults.m */; };
 		7ADE379422E8B69C00263048 /* OneSignalOutcomeEventsController.m in Sources */ = {isa = PBXBuildFile; fileRef = 7ADE379322E8B69C00263048 /* OneSignalOutcomeEventsController.m */; };
 		7ADE37AD22F2554400263048 /* OneSignalOutcomeEventsController.m in Sources */ = {isa = PBXBuildFile; fileRef = 7ADE379322E8B69C00263048 /* OneSignalOutcomeEventsController.m */; };
@@ -422,6 +425,8 @@
 		7A880F302404AE7B0081F5E8 /* OSInAppMessagePushPrompt.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = OSInAppMessagePushPrompt.m; sourceTree = "<group>"; };
 		7A9173A1231971E5007848FA /* OneSignalReceiveReceiptsController.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = OneSignalReceiveReceiptsController.m; sourceTree = "<group>"; };
 		7A9173A3231971F8007848FA /* OneSignalReceiveReceiptsController.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = OneSignalReceiveReceiptsController.h; sourceTree = "<group>"; };
+		7AD172362416D52D00A78B19 /* OSInAppMessageLocationPrompt.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = OSInAppMessageLocationPrompt.h; sourceTree = "<group>"; };
+		7AD172372416D53B00A78B19 /* OSInAppMessageLocationPrompt.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = OSInAppMessageLocationPrompt.m; sourceTree = "<group>"; };
 		7AD8DDE6234BD3BE00747A8A /* OneSignalUserDefaults.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = OneSignalUserDefaults.m; sourceTree = "<group>"; };
 		7AD8DDE8234BD3CF00747A8A /* OneSignalUserDefaults.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = OneSignalUserDefaults.h; sourceTree = "<group>"; };
 		7ADE379322E8B69C00263048 /* OneSignalOutcomeEventsController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = OneSignalOutcomeEventsController.m; sourceTree = "<group>"; };
@@ -967,6 +972,8 @@
 				7A880F2E2404AD010081F5E8 /* OSInAppMessagePrompt.h */,
 				7A880F2F2404AD920081F5E8 /* OSInAppMessagePushPrompt.h */,
 				7A880F302404AE7B0081F5E8 /* OSInAppMessagePushPrompt.m */,
+				7AD172362416D52D00A78B19 /* OSInAppMessageLocationPrompt.h */,
+				7AD172372416D53B00A78B19 /* OSInAppMessageLocationPrompt.m */,
 			);
 			name = Model;
 			sourceTree = "<group>";
@@ -1237,6 +1244,7 @@
 			files = (
 				9D1BD968237A28FC00A064F7 /* OSUniqueOutcomeNotification.m in Sources */,
 				7A9173A2231971E5007848FA /* OneSignalReceiveReceiptsController.m in Sources */,
+				7AD172382416D53B00A78B19 /* OSInAppMessageLocationPrompt.m in Sources */,
 				9124120E1E73342200E41FD7 /* OneSignal.m in Sources */,
 				CACBAA97218A6243000ACAA5 /* OSMessagingController.m in Sources */,
 				CA36F35921C33A2500300C77 /* OSInAppMessageController.m in Sources */,
@@ -1310,6 +1318,7 @@
 			files = (
 				9D1BD969237A28FC00A064F7 /* OSUniqueOutcomeNotification.m in Sources */,
 				9124120F1E73342200E41FD7 /* OneSignal.m in Sources */,
+				7AD172392416D53B00A78B19 /* OSInAppMessageLocationPrompt.m in Sources */,
 				CACBAA98218A6243000ACAA5 /* OSMessagingController.m in Sources */,
 				CA36F35A21C33A2500300C77 /* OSInAppMessageController.m in Sources */,
 				CA08FC741FE99AFF004C445F /* OneSignalClient.m in Sources */,
@@ -1452,6 +1461,7 @@
 				CACBAAAA218A65AE000ACAA5 /* InAppMessagingTests.m in Sources */,
 				4529DEE71FA82CDC00CEAB1D /* UNUserNotificationCenterOverrider.m in Sources */,
 				4529DEDB1FA8284E00CEAB1D /* NSDataOverrider.m in Sources */,
+				7AD1723A2416D53B00A78B19 /* OSInAppMessageLocationPrompt.m in Sources */,
 				CA7FC8A221927229002C4FD9 /* OSDynamicTriggerController.m in Sources */,
 				9D3300F623145AF3000F0A83 /* OneSignalViewHelper.m in Sources */,
 				4529DEF31FA8440A00CEAB1D /* UIAlertViewOverrider.m in Sources */,
diff --git a/iOS_SDK/OneSignalSDK/Source/OSInAppMessageAction.m b/iOS_SDK/OneSignalSDK/Source/OSInAppMessageAction.m
@@ -27,6 +27,7 @@
 
 #import "OSInAppMessageAction.h"
 #import "OSInAppMessagePushPrompt.h"
+#import "OSInAppMessageLocationPrompt.h"
 
 @implementation OSInAppMessageAction
 
@@ -94,8 +95,11 @@ + (instancetype)instanceWithJson:(NSDictionary *)json {
         NSArray<NSString *> *promptActionsStrings = json[@"prompts"];
         
         for (NSString *prompt in promptActionsStrings) {
+            // TODO: We should refactor this string handling to enums
             if ([prompt isEqualToString:@"push"]) {
                 [promptActions addObject:[[OSInAppMessagePushPrompt alloc] init]];
+            } else if ([prompt isEqualToString:@"location"]) {
+                [promptActions addObject:[[OSInAppMessageLocationPrompt alloc] init]];
             }
         }
 
@@ -105,8 +109,7 @@ + (instancetype)instanceWithJson:(NSDictionary *)json {
     return action;
 }
 
-- (NSString *)description
-{
+- (NSString *)description {
     return [NSString stringWithFormat:@"OSInAppMessageAction outcome: %@ \ntag: %@ promptAction: %@", _outcomes, _tags, [_promptActions description]];
 }
 
diff --git a/iOS_SDK/OneSignalSDK/Source/OSInAppMessageLocationPrompt.h b/iOS_SDK/OneSignalSDK/Source/OSInAppMessageLocationPrompt.h
@@ -0,0 +1,39 @@
+/**
+* Modified MIT License
+*
+* Copyright 2020 OneSignal
+*
+* Permission is hereby granted, free of charge, to any person obtaining a copy
+* of this software and associated documentation files (the "Software"), to deal
+* in the Software without restriction, including without limitation the rights
+* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+* copies of the Software, and to permit persons to whom the Software is
+* furnished to do so, subject to the following conditions:
+*
+* 1. The above copyright notice and this permission notice shall be included in
+* all copies or substantial portions of the Software.
+*
+* 2. All copies of substantial portions of the Software may only be used in connection
+* with services provided by OneSignal.
+*
+* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+* THE SOFTWARE.
+*/
+
+#ifndef OSInAppMessageLocationPrompt_h
+#define OSInAppMessageLocationPrompt_h
+
+#import "OSInAppMessagePrompt.h"
+
+@interface OSInAppMessageLocationPrompt : NSObject <OSInAppMessagePrompt>
+
+@property (nonatomic) BOOL hasPrompted;
+
+@end
+
+#endif /* OSInAppMessageLocationPrompt_h */
diff --git a/iOS_SDK/OneSignalSDK/Source/OSInAppMessageLocationPrompt.m b/iOS_SDK/OneSignalSDK/Source/OSInAppMessageLocationPrompt.m
@@ -0,0 +1,56 @@
+/**
+* Modified MIT License
+*
+* Copyright 2020 OneSignal
+*
+* Permission is hereby granted, free of charge, to any person obtaining a copy
+* of this software and associated documentation files (the "Software"), to deal
+* in the Software without restriction, including without limitation the rights
+* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+* copies of the Software, and to permit persons to whom the Software is
+* furnished to do so, subject to the following conditions:
+*
+* 1. The above copyright notice and this permission notice shall be included in
+* all copies or substantial portions of the Software.
+*
+* 2. All copies of substantial portions of the Software may only be used in connection
+* with services provided by OneSignal.
+*
+* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+* THE SOFTWARE.
+*/
+
+#import <Foundation/Foundation.h>
+#import "OSInAppMessageLocationPrompt.h"
+
+@interface OneSignal ()
+
++ (void)promptLocation:(void (^)(BOOL accepted))completionHandler;
+
+@end
+
+@implementation OSInAppMessageLocationPrompt
+
+- (instancetype)init
+{
+    self = [super init];
+    if (self) {
+        _hasPrompted = NO;
+    }
+    return self;
+}
+
+- (void)handlePrompt:(void (^)(BOOL accepted))completionHandler {
+    [OneSignal promptLocation:completionHandler];
+}
+
+- (NSString *)description {
+    return [NSString stringWithFormat:@"OSInAppMessageLocationPrompt hasPrompted:%@", _hasPrompted ? @"YES" : @"NO"];
+}
+
+@end
diff --git a/iOS_SDK/OneSignalSDK/Source/OSInAppMessageOutcome.m b/iOS_SDK/OneSignalSDK/Source/OSInAppMessageOutcome.m
@@ -65,4 +65,8 @@ + (instancetype _Nullable)instancePreviewFromPayload:(OSNotificationPayload * _N
     return nil;
 }
 
+- (NSString *)description {
+    return [NSString stringWithFormat:@"OSInAppMessageOutcome name: %@\nweight: %@unique: %s\n", _name, _weight, _unique ? "YES" : "NO"];
+}
+
 @end
diff --git a/iOS_SDK/OneSignalSDK/Source/OSInAppMessagePrompt.h b/iOS_SDK/OneSignalSDK/Source/OSInAppMessagePrompt.h
@@ -34,7 +34,7 @@
 
 @protocol OSInAppMessagePrompt <NSObject>
 
-@property (nonatomic) BOOL didAppear;
+@property (nonatomic) BOOL hasPrompted;
 
 - (void)handlePrompt:(void (^)(BOOL accepted))completionHandler;
 
diff --git a/iOS_SDK/OneSignalSDK/Source/OSInAppMessagePushPrompt.h b/iOS_SDK/OneSignalSDK/Source/OSInAppMessagePushPrompt.h
@@ -32,7 +32,7 @@
 
 @interface OSInAppMessagePushPrompt : NSObject <OSInAppMessagePrompt>
 
-@property (nonatomic) BOOL didAppear;
+@property (nonatomic) BOOL hasPrompted;
 
 @end
 
diff --git a/iOS_SDK/OneSignalSDK/Source/OSInAppMessagePushPrompt.m b/iOS_SDK/OneSignalSDK/Source/OSInAppMessagePushPrompt.m
@@ -34,7 +34,7 @@ - (instancetype)init
 {
     self = [super init];
     if (self) {
-        _didAppear = NO;
+        _hasPrompted = NO;
     }
     return self;
 }
@@ -43,9 +43,8 @@ - (void)handlePrompt:(void (^)(BOOL accepted))completionHandler {
     [OneSignal promptForPushNotificationsWithUserResponse:completionHandler fallbackToSettings:YES];
 }
 
-- (NSString *)description
-{
-    return [NSString stringWithFormat:@"OSInAppMessagePushPrompt didappear:%@", _didAppear ? @"YES" : @"NO"];
+- (NSString *)description {
+    return [NSString stringWithFormat:@"OSInAppMessagePushPrompt hasPrompted:%@", _hasPrompted ? @"YES" : @"NO"];
 }
 
 @end
diff --git a/iOS_SDK/OneSignalSDK/Source/OSMessagingController.h b/iOS_SDK/OneSignalSDK/Source/OSMessagingController.h
@@ -33,7 +33,13 @@
 
 NS_ASSUME_NONNULL_BEGIN
 
-@interface OSMessagingController : NSObject <OSInAppMessageViewControllerDelegate, OSTriggerControllerDelegate>
+@protocol OSMessagingControllerDelegate <NSObject>
+
+- (void)onApplicationDidBecomeActive;
+
+@end
+
+@interface OSMessagingController : NSObject <OSInAppMessageViewControllerDelegate, OSTriggerControllerDelegate, OSMessagingControllerDelegate>
 
 @property (class, readonly) BOOL isInAppMessagingPaused;
 
diff --git a/iOS_SDK/OneSignalSDK/Source/OSMessagingController.m b/iOS_SDK/OneSignalSDK/Source/OSMessagingController.m
@@ -72,6 +72,8 @@ @interface OSMessagingController ()
 
 @property (nonatomic, nullable) NSObject<OSInAppMessagePrompt>*currentPromptAction;
 
+@property (nonatomic) BOOL isAppInactive;
+
 @end
 
 @implementation OSMessagingController
@@ -138,6 +140,7 @@ - (instancetype)init {
         self.clickedClickIds = [[NSMutableSet alloc] initWithSet:[standardUserDefaults getSavedSetForKey:OS_IAM_CLICKED_SET_KEY defaultValue:nil]];
         self.impressionedInAppMessages = [[NSMutableSet alloc] initWithSet:[standardUserDefaults getSavedSetForKey:OS_IAM_IMPRESSIONED_SET_KEY defaultValue:nil]];
         self.currentPromptAction = nil;
+        self.isAppInactive = NO;
         // BOOL that controls if in-app messaging is paused or not (false by default)
         [self setInAppMessagingPaused:false];
     }
@@ -212,7 +215,12 @@ - (void)presentInAppMessage:(OSInAppMessage *)message {
         // Return early if an IAM is already showing
         if (self.isInAppMessageShowing)
             return;
-        
+        // Return early if the app is not active
+        if ([[UIApplication sharedApplication] applicationState] != UIApplicationStateActive) {
+            [OneSignal onesignal_Log:ONE_S_LL_VERBOSE message:@"Pause IAMs display due to app inactivity"];
+            _isAppInactive = YES;
+            return;
+        }
         [self displayMessage:message];
     };
 }
@@ -355,7 +363,6 @@ - (void)setDataForRedisplay:(OSInAppMessage *)message {
             [self.impressionedInAppMessages removeObject:message.messageId];
             [message clearClickIds];
             return;
-            
         }
     }
 }
@@ -439,7 +446,9 @@ - (void)messageViewControllerWasDismissed {
 
         if (!_currentPromptAction) {
             [self evaluateMessageDisplayQueue];
-        } // else do nothing prompt is handling the re-showing
+        } else { //do nothing prompt is handling the re-showing
+            [OneSignal onesignal_Log:ONE_S_LL_VERBOSE message:@"Stop evaluateMessageDisplayQueue because prompt is currently displayed"];
+        }
     }
 }
 
@@ -488,26 +497,25 @@ - (void)persistInAppMessageForRedisplay:(OSInAppMessage *)message {
     [OneSignal onesignal_Log:ONE_S_LL_VERBOSE message:[NSString stringWithFormat:@"persistInAppMessageForRedisplay: %@ \nredisplayedInAppMessages: %@", [message description], [_redisplayedInAppMessages description]]];
 }
 
-- (void)handlePromptAction:(NSArray<NSObject<OSInAppMessagePrompt> *> *)promptActions {
+- (void)handlePromptActions:(NSArray<NSObject<OSInAppMessagePrompt> *> *)promptActions {
     for (NSObject<OSInAppMessagePrompt> *promptAction in promptActions) {
-        if (![promptAction didAppear]) {
+        // Don't show prompt twice
+        if (!promptAction.hasPrompted) {
             _currentPromptAction = promptAction;
+            break;
         }
-        break;
     }
 
     if (_currentPromptAction) {
         [OneSignal onesignal_Log:ONE_S_LL_VERBOSE message:[NSString stringWithFormat:@"IAM prompt to handle: %@", [_currentPromptAction description]]];
-        _currentPromptAction.didAppear = YES;
+        _currentPromptAction.hasPrompted = YES;
         [_currentPromptAction handlePrompt:^(BOOL accepted) {
             _currentPromptAction = nil;
-            // IAM dismissed by action
-            if (!_viewController) {
-                [OneSignal onesignal_Log:ONE_S_LL_VERBOSE message:@"IAM with prompt dismissed from actionTaken"];
-                [self evaluateMessageDisplayQueue];
-            }
-            //TODO: continue handling more than one prompt
+            [self handlePromptActions:promptActions];
         }];
+    } else if (!_viewController) { // IAM dismissed by action
+        [OneSignal onesignal_Log:ONE_S_LL_VERBOSE message:@"IAM with prompt dismissed from actionTaken"];
+        [self evaluateMessageDisplayQueue];
     }
 }
 
@@ -518,7 +526,7 @@ - (void)messageViewDidSelectAction:(OSInAppMessage *)message withAction:(OSInApp
     if (action.clickUrl)
         [self handleMessageActionWithURL:action];
     
-    [self handlePromptAction:action.promptActions];
+    [self handlePromptActions:action.promptActions];
 
     if (self.actionClickBlock)
         self.actionClickBlock(action);
@@ -624,6 +632,16 @@ - (void)triggerConditionChanged {
     [self evaluateMessages];
 }
 
+#pragma mark OSMessagingControllerDelegate Methods
+- (void)onApplicationDidBecomeActive {
+    // To avoid excesive message evaluation
+    // we should re-evaluate all in-app messages only if it was paused by inactive
+    if (_isAppInactive) {
+        [OneSignal onesignal_Log:ONE_S_LL_VERBOSE message:@"Evaluating messages due to inactive app"];
+        _isAppInactive = NO;
+        [self evaluateMessages];
+    }
+}
 @end
 
 @implementation DummyOSMessagingController
diff --git a/iOS_SDK/OneSignalSDK/Source/OneSignal.m b/iOS_SDK/OneSignalSDK/Source/OneSignal.m
@@ -556,7 +556,7 @@ + (id)initWithLaunchOptions:(NSDictionary*)launchOptions
     _outcomeEventsController = [[OneSignalOutcomeEventsController alloc] init:self.sessionManager];
     
     if (appId && mShareLocation)
-       [OneSignalLocation getLocation:false];
+       [OneSignalLocation getLocation:false withCompletionHandler:nil];
     
     /*
      * No need to call the handleNotificationOpened:userInfo as it will be called from one of the following selectors
@@ -1393,12 +1393,16 @@ + (void)setLocationShared:(BOOL)enable {
     }
 }
 
-+ (void) promptLocation {
++ (void)promptLocation {
+    [self promptLocation:nil];
+}
+
++ (void)promptLocation:(void (^)(BOOL accepted))completionHandler {
     // return if the user has not granted privacy permissions
     if ([self shouldLogMissingPrivacyConsentErrorWithMethodName:@"promptLocation"])
         return;
     
-    [OneSignalLocation getLocation:true];
+    [OneSignalLocation getLocation:true withCompletionHandler:completionHandler];
 }
 
 + (BOOL)isLocationShared {
diff --git a/iOS_SDK/OneSignalSDK/Source/OneSignalLocation.h b/iOS_SDK/OneSignalSDK/Source/OneSignalLocation.h
@@ -47,11 +47,11 @@ typedef struct os_last_location {
 + (bool)started;
 + (void)internalGetLocation:(bool)prompt;
 - (void)locationManager:(id)manager didUpdateLocations:(NSArray *)locations;
-+ (void) getLocation:(bool)prompt;
-+ (void) sendLocation;
++ (void)getLocation:(bool)prompt withCompletionHandler:(void (^)(BOOL accepted))completionHandler;
++ (void)sendLocation;
 + (os_last_location*)lastLocation;
 + (void)clearLastLocation;
-+ (void)onfocus:(BOOL)isActive;
++ (void)onFocus:(BOOL)isActive;
 
 @end
 
diff --git a/iOS_SDK/OneSignalSDK/Source/OneSignalLocation.m b/iOS_SDK/OneSignalSDK/Source/OneSignalLocation.m
diff --git a/iOS_SDK/OneSignalSDK/Source/UIApplicationDelegate+OneSignal.m b/iOS_SDK/OneSignalSDK/Source/UIApplicationDelegate+OneSignal.m
diff --git a/iOS_SDK/OneSignalSDK/UnitTests/InAppMessagingIntegrationTests.m b/iOS_SDK/OneSignalSDK/UnitTests/InAppMessagingIntegrationTests.m
diff --git a/iOS_SDK/OneSignalSDK/UnitTests/OutcomeIntegrationTests.m b/iOS_SDK/OneSignalSDK/UnitTests/OutcomeIntegrationTests.m
diff --git a/iOS_SDK/OneSignalSDK/UnitTests/Shadows/OSMessagingControllerOverrider.h b/iOS_SDK/OneSignalSDK/UnitTests/Shadows/OSMessagingControllerOverrider.h
diff --git a/iOS_SDK/OneSignalSDK/UnitTests/Shadows/OSMessagingControllerOverrider.m b/iOS_SDK/OneSignalSDK/UnitTests/Shadows/OSMessagingControllerOverrider.m

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@`
`27`	`27`
`28`	`28`	`#import "OSInAppMessageAction.h"`
`29`	`29`	`#import "OSInAppMessagePushPrompt.h"`
	`30`	`+#import "OSInAppMessageLocationPrompt.h"`
`30`	`31`
`31`	`32`	`@implementation OSInAppMessageAction`
`32`	`33`
`@@ -94,8 +95,11 @@ + (instancetype)instanceWithJson:(NSDictionary *)json {`
`94`	`95`	`NSArray<NSString > promptActionsStrings = json[@"prompts"];`
`95`	`96`
`96`	`97`	`for (NSString *prompt in promptActionsStrings) {`
	`98`	`+ // TODO: We should refactor this string handling to enums`
`97`	`99`	`if ([prompt isEqualToString:@"push"]) {`
`98`	`100`	`[promptActions addObject:[[OSInAppMessagePushPrompt alloc] init]];`
	`101`	`+ } else if ([prompt isEqualToString:@"location"]) {`
	`102`	`+ [promptActions addObject:[[OSInAppMessageLocationPrompt alloc] init]];`
`99`	`103`	`}`
`100`	`104`	`}`
`101`	`105`
`@@ -105,8 +109,7 @@ + (instancetype)instanceWithJson:(NSDictionary *)json {`
`105`	`109`	`return action;`
`106`	`110`	`}`
`107`	`111`
`108`		`-- (NSString *)description`
`109`		`-{`
	`112`	`+- (NSString *)description {`
`110`	`113`	`return [NSString stringWithFormat:@"OSInAppMessageAction outcome: %@ \ntag: %@ promptAction: %@", _outcomes, _tags, [_promptActions description]];`
`111`	`114`	`}`
`112`	`115`
Original file line number	Diff line number	Diff line change
`@@ -65,4 +65,8 @@ + (instancetype _Nullable)instancePreviewFromPayload:(OSNotificationPayload * _N`
`65`	`65`	`return nil;`
`66`	`66`	`}`
`67`	`67`
	`68`	`+- (NSString *)description {`
	`69`	`+ return [NSString stringWithFormat:@"OSInAppMessageOutcome name: %@\nweight: %@unique: %s\n", _name, _weight, _unique ? "YES" : "NO"];`
	`70`	`+}`
	`71`	`+`
`68`	`72`	`@end`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ - (instancetype)init`
`34`	`34`	`{`
`35`	`35`	`self = [super init];`
`36`	`36`	`if (self) {`
`37`		`- _didAppear = NO;`
	`37`	`+ _hasPrompted = NO;`
`38`	`38`	`}`
`39`	`39`	`return self;`
`40`	`40`	`}`
`@@ -43,9 +43,8 @@ - (void)handlePrompt:(void (^)(BOOL accepted))completionHandler {`
`43`	`43`	`[OneSignal promptForPushNotificationsWithUserResponse:completionHandler fallbackToSettings:YES];`
`44`	`44`	`}`
`45`	`45`
`46`		`-- (NSString *)description`
`47`		`-{`
`48`		`- return [NSString stringWithFormat:@"OSInAppMessagePushPrompt didappear:%@", _didAppear ? @"YES" : @"NO"];`
	`46`	`+- (NSString *)description {`
	`47`	`+ return [NSString stringWithFormat:@"OSInAppMessagePushPrompt hasPrompted:%@", _hasPrompted ? @"YES" : @"NO"];`
`49`	`48`	`}`
`50`	`49`
`51`	`50`	`@end`