Skip to content

Commit 08c2b5d

Browse files
author
Vivek Ayer
committed
iOS_SDK: add one more constructor to just take appId and launchOptions
Xamarin does some strict enforcement for parameters at runtime. It was agreed that there needs to be a constructor that just takes the OneSignal application id and launch options, but not the notification handler callback.
1 parent 285168f commit 08c2b5d

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

iOS_SDK/OneSignal/OneSignal.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@ typedef NS_ENUM(NSUInteger, ONE_S_LOG_LEVEL) {
6161

6262
- (id)initWithLaunchOptions:(NSDictionary*)launchOptions autoRegister:(BOOL)autoRegister;
6363

64+
- (id)initWithLaunchOptions:(NSDictionary*)launchOptions appId:(NSString*)appId;
65+
6466
- (id)initWithLaunchOptions:(NSDictionary*)launchOptions handleNotification:(OneSignalHandleNotificationBlock)callback;
6567

6668
- (id)initWithLaunchOptions:(NSDictionary*)launchOptions appId:(NSString*)appId handleNotification:(OneSignalHandleNotificationBlock)callback;

iOS_SDK/OneSignal/OneSignal.m

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,10 @@ - (id)initWithLaunchOptions:(NSDictionary*)launchOptions autoRegister:(BOOL)auto
102102
return [self initWithLaunchOptions:launchOptions appId:nil handleNotification:nil autoRegister:autoRegister];
103103
}
104104

105+
- (id)initWithLaunchOptions:(NSDictionary*)launchOptions appId:(NSString*)appId {
106+
return [self initWithLaunchOptions:launchOptions appId:appId handleNotification:nil autoRegister:true];
107+
}
108+
105109
- (id)initWithLaunchOptions:(NSDictionary*)launchOptions handleNotification:(OneSignalHandleNotificationBlock)callback {
106110
return [self initWithLaunchOptions:launchOptions appId:nil handleNotification:callback autoRegister:true];
107111
}

0 commit comments

Comments
 (0)