Skip to content

Commit 0b60af4

Browse files
author
Adam Schlesinger
committed
Update unit test for unescaping EID
1 parent e885e3e commit 0b60af4

File tree

1 file changed

+9
-19
lines changed

1 file changed

+9
-19
lines changed

iOS_SDK/OneSignalSDK/UnitTests/RequestTests.m

Lines changed: 9 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -724,6 +724,15 @@ - (void)testSendExternalUserId {
724724
XCTAssertTrue(checkHttpBody(request.urlRequest.HTTPBody, @{@"app_id" : testAppId, @"external_user_id" : testExternalUserId}));
725725
}
726726

727+
- (void)testSendExternalUserIdWithForwardSlashes {
728+
let externalUserId = @"abc/123";
729+
let request = [OSRequestUpdateExternalUserId withUserId:externalUserId withUserIdHashToken:nil withOneSignalUserId:testUserId appId:testAppId];
730+
let correctUrl = correctUrlWithPath([NSString stringWithFormat:@"players/%@", testUserId]);
731+
732+
XCTAssertTrue([correctUrl isEqualToString:request.urlRequest.URL.absoluteString]);
733+
XCTAssertTrue(checkHttpBody(request.urlRequest.HTTPBody, @{@"app_id" : testAppId, @"external_user_id" : externalUserId}));
734+
}
735+
727736
- (void)testSendExternalWithAuthUserId {
728737
let request = [OSRequestUpdateExternalUserId withUserId:testExternalUserId withUserIdHashToken:testExternalUserIdHashToken withOneSignalUserId:testUserId appId:testAppId];
729738

@@ -734,23 +743,4 @@ - (void)testSendExternalWithAuthUserId {
734743
XCTAssertTrue(checkHttpBody(request.urlRequest.HTTPBody, @{@"app_id" : testAppId, @"external_user_id" : testExternalUserId, @"external_user_id_auth_hash" : testExternalUserIdHashToken}));
735744
}
736745

737-
- (void)testConstructPut {
738-
let oneSignalRequest = [OneSignalRequest new];
739-
oneSignalRequest.path = @"test";
740-
oneSignalRequest.method = PUT;
741-
oneSignalRequest.parameters = @{
742-
@"int": @(123),
743-
@"double": @(1.23),
744-
@"string_normal": @"thisisastring",
745-
@"string_slashes": @"this/string/has/slashes",
746-
@"string_escapedchars": @"this\nstring\\has\"escape\tchars",
747-
};
748-
749-
let urlRequest = [oneSignalRequest urlRequest];
750-
let urlRequestBodyString = [NSString stringWithUTF8String:[urlRequest.HTTPBody bytes]];
751-
let expectedBodyString = @"{\"double\":1.23,\"int\":123,\"string_normal\":\"thisisastring\",\"string_slashes\":\"this/string/has/slashes\",\"string_escapedchars\":\"this\\nstring\\\\has\\\"escape\\tchars\"}";
752-
753-
XCTAssertTrue([urlRequestBodyString isEqualToString:expectedBodyString]);
754-
}
755-
756746
@end

0 commit comments

Comments
 (0)