Skip to content

Commit 1125c56

Browse files
author
Joseph Kalash
committed
Fixed issue where InAppAlerts would be prioritized over InFocusDiplayOption in pre-iOS 10.
1 parent 3162445 commit 1125c56

File tree

5 files changed

+7
-7
lines changed

5 files changed

+7
-7
lines changed

OneSignal.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = "OneSignal"
3-
s.version = "2.1.14"
3+
s.version = "2.1.16"
44
s.summary = "OneSignal push notification library for mobile apps."
55
s.homepage = "https://onesignal.com"
66
s.license = { :type => 'MIT', :file => 'LICENSE' }

iOS_SDK/Framework/OneSignal.framework/Versions/A/Headers/OneSignal.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ typedef NS_ENUM(NSUInteger, ONE_S_LOG_LEVEL) {
233233
+ (id)initWithLaunchOptions:(NSDictionary*)launchOptions appId:(NSString*)appId;
234234
+ (id)initWithLaunchOptions:(NSDictionary*)launchOptions appId:(NSString*)appId handleNotificationAction:(OSHandleNotificationActionBlock)actionCallback;
235235
+ (id)initWithLaunchOptions:(NSDictionary*)launchOptions appId:(NSString*)appId handleNotificationAction:(OSHandleNotificationActionBlock)actionCallback settings:(NSDictionary*)settings;
236-
+ (id)initWithLaunchOptions:(NSDictionary*)launchOptions appId:(NSString*)appId handleNotificationReceived:(OSHandleNotificationReceivedBlock)receivedCallback handleNotificationAction:(OSHandleNotificationActionBlock)actionCallback settings:(NSDictionary*)settings;
236+
+ (id)initWithLaunchOptions:(NSDictionary*)launchOptions appId:(NSString*)appId handleNotificationReceived:(OSHandleNotificationReceivedBlock)erceivedCallback handleNotificationAction:(OSHandleNotificationActionBlock)actionCallback settings:(NSDictionary*)settings;
237237

238238
+ (NSString*)app_id;
239239

-1.13 KB
Binary file not shown.

iOS_SDK/OneSignal/OneSignal.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ typedef NS_ENUM(NSUInteger, ONE_S_LOG_LEVEL) {
233233
+ (id)initWithLaunchOptions:(NSDictionary*)launchOptions appId:(NSString*)appId;
234234
+ (id)initWithLaunchOptions:(NSDictionary*)launchOptions appId:(NSString*)appId handleNotificationAction:(OSHandleNotificationActionBlock)actionCallback;
235235
+ (id)initWithLaunchOptions:(NSDictionary*)launchOptions appId:(NSString*)appId handleNotificationAction:(OSHandleNotificationActionBlock)actionCallback settings:(NSDictionary*)settings;
236-
+ (id)initWithLaunchOptions:(NSDictionary*)launchOptions appId:(NSString*)appId handleNotificationReceived:(OSHandleNotificationReceivedBlock)receivedCallback handleNotificationAction:(OSHandleNotificationActionBlock)actionCallback settings:(NSDictionary*)settings;
236+
+ (id)initWithLaunchOptions:(NSDictionary*)launchOptions appId:(NSString*)appId handleNotificationReceived:(OSHandleNotificationReceivedBlock)erceivedCallback handleNotificationAction:(OSHandleNotificationActionBlock)actionCallback settings:(NSDictionary*)settings;
237237

238238
+ (NSString*)app_id;
239239

iOS_SDK/OneSignal/OneSignal.m

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@
7575

7676
@implementation OneSignal
7777

78-
NSString* const ONESIGNAL_VERSION = @"020115";
78+
NSString* const ONESIGNAL_VERSION = @"020116";
7979
static NSString* mSDKType = @"native";
8080
static BOOL coldStartFromTapOnNotification = NO;
8181
static BOOL registeredWithApple = NO; //Has attempted to register for push notifications with Apple.
@@ -199,10 +199,10 @@ + (id)initWithLaunchOptions:(NSDictionary*)launchOptions appId:(NSString*)appId
199199
if(!inAppAlertsPassed && !inFocusDisplayPassed)
200200
[self setNotificationDisplayOptions:@(OSNotificationDisplayTypeInAppAlert)];
201201

202-
else if(!inAppAlertsPassed || (inFocusDisplayPassed && [OneSignalHelper isiOS10Plus]))
203-
[self setNotificationDisplayOptions:IFDSetting];
202+
else if(!inFocusDisplayPassed)
203+
[self setNotificationDisplayOptions:IAASetting];
204204

205-
else [self setNotificationDisplayOptions:IAASetting];
205+
else [self setNotificationDisplayOptions:IFDSetting];
206206

207207

208208
if (mUserId != nil)

0 commit comments

Comments
 (0)