Skip to content

Commit 1507c27

Browse files
committed
calling set after hydrating aliases to ensure that the aliases get saved to user defaults
Also included convenience shortcut for getting pushSubscriptionId
1 parent 2adc39b commit 1507c27

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

iOS_SDK/OneSignalSDK/OneSignalUser/Source/OSIdentityModel.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ class OSIdentityModel: OSModel {
9696
default:
9797
aliases[property.key] = property.value as? String
9898
}
99+
self.set(property: "aliases", newValue: aliases)
99100
}
100101
}
101102
}

iOS_SDK/OneSignalSDK/OneSignalUser/Source/OneSignalUserManagerImpl.swift

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,10 @@ public class OneSignalUserManagerImpl: NSObject, OneSignalUserManager {
9494
@objc public var onesignalId: String? {
9595
return _user?.identityModel.onesignalId
9696
}
97+
98+
@objc public var pushSubscriptionId: String? {
99+
return _user?.pushSubscriptionModel.subscriptionId
100+
}
97101

98102
private var hasCalledStart = false
99103

@@ -180,8 +184,6 @@ public class OneSignalUserManagerImpl: NSObject, OneSignalUserManager {
180184
let propertiesModel = propertiesModelStore.getModels()[OS_PROPERTIES_MODEL_KEY],
181185
let pushSubscription = subscriptionModelStore.getModels()[OS_PUSH_SUBSCRIPTION_MODEL_KEY] {
182186
_user = OSUserInternalImpl(identityModel: identityModel, propertiesModel: propertiesModel, pushSubscriptionModel: pushSubscription)
183-
184-
// TODO: Pull user data here in init or on every new session?
185187
}
186188

187189
// Creates an anonymous user if there isn't one in the cache

0 commit comments

Comments
 (0)