cleanup IAM window on the main thread when we get a error loading message content

emawby · emawby · commit 1ae11e6629b2 · 2024-05-30T13:19:01.000-07:00
All other cleanups are coming from the UI thread, but this one is not. This fixes a crash that happens if multiple IAMs have the same trigger and one of the IAMs after the first fails to load
diff --git a/iOS_SDK/OneSignalSDK/OneSignalInAppMessages/Controller/OSMessagingController.m b/iOS_SDK/OneSignalSDK/OneSignalInAppMessages/Controller/OSMessagingController.m
@@ -901,7 +901,9 @@ - (void)messageViewDidDisplayPage:(OSInAppMessageInternal *)message withPageId:(
 
 - (void)messageIsNotActive:(OSInAppMessageInternal *)message {
     [self deleteInactiveMessage:message];
-    [self cleanUpInAppWindow];
+    dispatch_async(dispatch_get_main_queue(), ^{
+        [self cleanUpInAppWindow];
+    });
 }
 
 - (void)messageWillDisplay:(nonnull OSInAppMessageInternal *)message {

Original file line number	Diff line number	Diff line change
`@@ -901,7 +901,9 @@ - (void)messageViewDidDisplayPage:(OSInAppMessageInternal *)message withPageId:(`
`901`	`901`
`902`	`902`	`- (void)messageIsNotActive:(OSInAppMessageInternal *)message {`
`903`	`903`	`[self deleteInactiveMessage:message];`
`904`		`- [self cleanUpInAppWindow];`
	`904`	`+ dispatch_async(dispatch_get_main_queue(), ^{`
	`905`	`+ [self cleanUpInAppWindow];`
	`906`	`+ });`
`905`	`907`	`}`
`906`	`908`
`907`	`909`	`- (void)messageWillDisplay:(nonnull OSInAppMessageInternal *)message {`