update email and sms subscriptions API

* addSms becomes addSms
* removeSmsNumber becomes removeSms
* return void when removing, not bool

Author: nan-li

iOS_SDK/OneSignalDevApp/OneSignalDevApp/ViewController.m

@@ -100,13 +100,13 @@ - (IBAction)removeEmailButton:(id)sender {
 - (IBAction)addSmsButton:(id)sender {
     NSString *sms = self.smsTextField.text;
     NSLog(@"Dev App: Add sms: %@", sms);
-    [OneSignal.User addSmsNumber:sms];
+    [OneSignal.User addSms:sms];
 }
 
 - (IBAction)removeSmsButton:(id)sender {
     NSString *sms = self.smsTextField.text;
     NSLog(@"Dev App: Removing sms: %@", sms);
-    [OneSignal.User removeSmsNumber:sms];
+    [OneSignal.User removeSms:sms];
 }
 
 - (IBAction)addAliasButton:(UIButton *)sender {

iOS_SDK/OneSignalSDK/OneSignalOSCore/Source/OSModelStore.swift

@@ -112,7 +112,7 @@ open class OSModelStore<TModel: OSModel>: NSObject {
      Returns false if this model does not exist in the store.
      This can happen if remove email or SMS is called and it doesn't exist in the store.
      */
-    public func remove(_ id: String) -> Bool {
+    public func remove(_ id: String) {
         OneSignalLog.onesignalLog(.LL_VERBOSE, message: "OSModelStore remove() called with model \(id)")
         // TODO: Nothing will happen if model doesn't exist in the store
         if let model = models[id] {
@@ -127,9 +127,7 @@ open class OSModelStore<TModel: OSModel>: NSObject {
             self.changeSubscription.fire { modelStoreListener in
                 modelStoreListener.onRemoved(model)
             }
-            return true
         }
-        return false
     }
 
     /**

iOS_SDK/OneSignalSDK/OneSignalUser/Source/OneSignalUserManagerImpl.swift

@@ -60,10 +60,10 @@ import OneSignalNotifications
     func removeTags(_ tags: [String])
     // Email
     func addEmail(_ email: String)
-    func removeEmail(_ email: String) -> Bool
+    func removeEmail(_ email: String)
     // SMS
-    func addSmsNumber(_ number: String)
-    func removeSmsNumber(_ number: String) -> Bool
+    func addSms(_ number: String)
+    func removeSms(_ number: String)
     // Language
     func setLanguage(_ language: String)
     // JWT Token Expire
@@ -612,16 +612,16 @@ extension OneSignalUserManagerImpl: OSUser {
      This will be a no-op and no request will be made.
      Error handling needs to be implemented in the future.
      */
-    public func removeEmail(_ email: String) -> Bool {
+    public func removeEmail(_ email: String) {
         guard !OneSignalConfigManager.shouldAwaitAppIdAndLogMissingPrivacyConsent(forMethod: "removeEmail") else {
-            return false
+            return
         }
         // Check if is valid email?
         createUserIfNil()
-        return self.subscriptionModelStore.remove(email)
+        self.subscriptionModelStore.remove(email)
     }
 
-    public func addSmsNumber(_ number: String) {
+    public func addSms(_ number: String) {
         guard !OneSignalConfigManager.shouldAwaitAppIdAndLogMissingPrivacyConsent(forMethod: "addSmsNumber") else {
             return
         }
@@ -644,13 +644,13 @@ extension OneSignalUserManagerImpl: OSUser {
      This will be a no-op and no request will be made.
      Error handling needs to be implemented in the future.
      */
-    public func removeSmsNumber(_ number: String) -> Bool {
+    public func removeSms(_ number: String) {
         guard !OneSignalConfigManager.shouldAwaitAppIdAndLogMissingPrivacyConsent(forMethod: "removeSmsNumber") else {
-            return false
+            return
         }
         // Check if is valid SMS?
         createUserIfNil()
-        return self.subscriptionModelStore.remove(number)
+        self.subscriptionModelStore.remove(number)
     }
 
     public func setLanguage(_ language: String) {