Skip to content

Commit 1e1482c

Browse files
committed
Move LanguageContext update prior to network call
* Move LanguageContext to OneSignal.setLanguage from OneSignal.setLanguageOnServer * Update happens before network call * On network failure, LanguageContext is stored for future synchronization
1 parent 124bb8c commit 1e1482c

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

iOS_SDK/OneSignalSDK/Source/OneSignal.m

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2705,6 +2705,10 @@ + (void)setLanguage:(NSString * _Nonnull)language {
27052705
if ([self shouldLogMissingPrivacyConsentErrorWithMethodName:@"setLanguage"])
27062706
return;
27072707

2708+
let languageProviderAppDefined = [LanguageProviderAppDefined new];
2709+
[languageProviderAppDefined setLanguage:language];
2710+
[languageContext setStrategy:languageProviderAppDefined];
2711+
27082712
//Can't send Language if there exists no language
27092713
if (language)
27102714
[self setLanguageOnServer:language WithSuccess:nil withFailure:nil];
@@ -2723,9 +2727,6 @@ + (void)setLanguage:(NSString * _Nonnull)language withSuccess:(OSUpdateLanguageS
27232727
+ (void)setLanguageOnServer:(NSString * _Nonnull)language WithSuccess:(OSUpdateLanguageSuccessBlock)successBlock withFailure:(OSUpdateLanguageFailureBlock)failureBlock {
27242728

27252729
[OneSignal.stateSynchronizer updateLanguage:language appId:appId withSuccess:^(NSDictionary *results) {
2726-
let languageProviderAppDefined = [LanguageProviderAppDefined new];
2727-
[languageProviderAppDefined setLanguage:language];
2728-
[languageContext setStrategy:languageProviderAppDefined];
27292730
if (successBlock)
27302731
successBlock(results);
27312732
} withFailure:^(NSError *error) {

0 commit comments

Comments
 (0)