add push subscription observer returns void

* Don't return the current state when the observer is added, return void

Author: nan-li

iOS_SDK/OneSignalDevApp/OneSignalDevApp/AppDelegate.m

@@ -90,8 +90,8 @@ - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(
     [OneSignal.Notifications setNotificationWillShowInForegroundHandler:notificationReceiverBlock];
     [OneSignal.Notifications setNotificationOpenedHandler:openNotificationHandler];
 
-    OSPushSubscriptionState* state = [OneSignal.User.pushSubscription addObserver:self];
-    NSLog(@"OneSignal Demo App push subscription observer added, current state: %@", state);
+    [OneSignal.User.pushSubscription addObserver:self];
+    NSLog(@"OneSignal Demo App push subscription observer added");
 
     [OneSignal.Notifications addPermissionObserver:self];
 

iOS_SDK/OneSignalSDK/OneSignalUser/Source/OneSignalUserManagerImpl.swift

@@ -82,7 +82,7 @@ import OneSignalNotifications
 
     func optIn()
     func optOut()
-    func addObserver(_ observer: OSPushSubscriptionObserver) -> OSPushSubscriptionState?
+    func addObserver(_ observer: OSPushSubscriptionObserver)
     func removeObserver(_ observer: OSPushSubscriptionObserver)
 }
 
@@ -669,12 +669,11 @@ extension OneSignalUserManagerImpl: OSUser {
 
 extension OneSignalUserManagerImpl: OSPushSubscription {
 
-    public func addObserver(_ observer: OSPushSubscriptionObserver) -> OSPushSubscriptionState? {
+    public func addObserver(_ observer: OSPushSubscriptionObserver) {
         guard !OneSignalConfigManager.shouldAwaitAppIdAndLogMissingPrivacyConsent(forMethod: "pushSubscription.addObserver") else {
-            return nil
+            return
         }
         self.pushSubscriptionStateChangesObserver.addObserver(observer)
-        return user.pushSubscriptionModel.currentPushSubscriptionState
     }
 
     public func removeObserver(_ observer: OSPushSubscriptionObserver) {

iOS_SDK/OneSignalSDK/Source/OSMessagingController.m

@@ -111,10 +111,7 @@ + (void)removeInstance {
 
 + (void)start {
     OSMessagingController *shared = OSMessagingController.sharedInstance;
-    #pragma clang diagnostic push
-    #pragma clang diagnostic ignored "-Wunused-variable"
-    OSPushSubscriptionState *_ = [OneSignalUserManagerImpl.sharedInstance addObserver:shared];
-    #pragma clang diagnostic pop
+    [OneSignalUserManagerImpl.sharedInstance addObserver:shared];
 }
 
 static BOOL _isInAppMessagingPaused = false;

iOS_SDK/OneSignalSDK/Source/OneSignalLiveActivityController.m

@@ -79,10 +79,7 @@ + (OneSignalLiveActivityController *)sharedInstance {
 + (void)initialize {
     subscriptionId = OneSignalUserManagerImpl.sharedInstance.pushSubscriptionId;
     OneSignalLiveActivityController *shared = OneSignalLiveActivityController.sharedInstance;
-    #pragma clang diagnostic push
-    #pragma clang diagnostic ignored "-Wunused-variable"
-    OSPushSubscriptionState *_ = [OneSignalUserManagerImpl.sharedInstance addObserver:shared];
-    #pragma clang diagnostic pop
+    [OneSignalUserManagerImpl.sharedInstance addObserver:shared];
 }
 
 - (void)onOSPushSubscriptionChangedWithStateChanges:(OSPushSubscriptionStateChanges * _Nonnull)stateChanges {