[nits] logging

* Remove messy logging
* Add informational log for background task expiring

Author: nan-li

iOS_SDK/OneSignalSDK/OneSignalOSCore/Source/OSModelStore.swift

@@ -87,7 +87,6 @@ open class OSModelStore<TModel: OSModel>: NSObject {
     }
 
     public func add(id: String, model: TModel, hydrating: Bool) {
-        OneSignalLog.onesignalLog(.LL_VERBOSE, message: "OSModelStore add() called with model \(model)")
         // TODO: Check if we are adding the same model? Do we replace?
             // For example, calling addEmail multiple times with the same email
             // Check API endpoint for behavior
@@ -127,6 +126,8 @@ open class OSModelStore<TModel: OSModel>: NSObject {
             self.changeSubscription.fire { modelStoreListener in
                 modelStoreListener.onRemoved(model)
             }
+        } else {
+            OneSignalLog.onesignalLog(.LL_ERROR, message: "OSModelStore cannot remove \(id) because it doesn't exist in the store.")
         }
     }
 
@@ -151,8 +152,6 @@ open class OSModelStore<TModel: OSModel>: NSObject {
 
 extension OSModelStore: OSModelChangedHandler {
     public func onModelUpdated(args: OSModelChangedArgs, hydrating: Bool) {
-        OneSignalLog.onesignalLog(.LL_VERBOSE, message: "OSModelStore.onChanged() called with OSModelChangedArgs: \(args)")
-
         // persist the changed models to storage
         OneSignalUserDefaults.initShared().saveCodeableData(forKey: self.storeKey, withValue: self.models)
 

iOS_SDK/OneSignalSDK/OneSignalOSCore/Source/OSModelStoreListener.swift

@@ -52,7 +52,6 @@ extension OSModelStoreListener {
     }
 
     public func onAdded(_ model: OSModel) {
-        OneSignalLog.onesignalLog(.LL_VERBOSE, message: "OSModelStoreListener.onAdded() with model \(model)")
         guard let addedModel = model as? Self.TModel else {
             // log error
             return
@@ -63,7 +62,6 @@ extension OSModelStoreListener {
     }
 
     public func onUpdated(_ args: OSModelChangedArgs) {
-        OneSignalLog.onesignalLog(.LL_VERBOSE, message: "OSModelStoreListener.onUpdated() with args \(args)")
         if let delta = getUpdateModelDelta(args) {
             OSOperationRepo.sharedInstance.enqueueDelta(delta)
         }

iOS_SDK/OneSignalSDK/Source/OSBackgroundTaskManagerImpl.m

@@ -45,6 +45,9 @@ - (void)beginBackgroundTask:(NSString * _Nonnull)taskIdentifier {
                      message:[NSString stringWithFormat:
                               @"OSBackgroundTaskManagerImpl:beginBackgroundTask: %@", taskIdentifier]];
     UIBackgroundTaskIdentifier uiIdentifier = [UIApplication.sharedApplication beginBackgroundTaskWithExpirationHandler:^{
+        [OneSignalLog onesignalLog:ONE_S_LL_DEBUG
+                         message:[NSString stringWithFormat:
+                                  @"OSBackgroundTaskManagerImpl: expirationHandler called for %@", taskIdentifier]];
         [self endBackgroundTask:taskIdentifier];
     }];
     tasks[taskIdentifier] = [NSNumber numberWithUnsignedLong:uiIdentifier];