Skip to content

Commit 2258690

Browse files
authored
Improves Email Demos (#344)
* Observer Crash • Fixes an issue where, in rare cases, users who call OneSignal.removeSubscriptionObserver() inside of the onOSSubscriptionChanged() delegate method would cause a crash because the observers array gets mutated while it is being enumerated. • This should have been a relatively rare crash since the delegate selector gets offloaded to the main thread which generally would introduce enough of a delay to prevent the crash. * Fix Null Crash • Fixes a crash highlighted in #343 where nil userId is inserted into dictionary • Changed to better syntax instead of a category on NSNull * Add Email to Demos • Adds email to both the Swift and Objective-C Demos * Add Missing Files • The previous commit was missing some project class files & launch screen storyboard. * Add Icons to Swift Demo • Adds OneSignal icons to Swift demo * Fix getPermissionSubscriptionState() Bug • getPermissionSubscriptionState() was not properly returning email subscription state, which was a contributing factor in bug #89 in the Unity SDK repo.
1 parent 286b862 commit 2258690

File tree

80 files changed

+1162
-494
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

80 files changed

+1162
-494
lines changed

Examples/ObjectiveCExample/AppIcon.xcassets/AppIcon.appiconset/Contents.json

Lines changed: 0 additions & 190 deletions
This file was deleted.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
-10.1 KB
Binary file not shown.

0 commit comments

Comments
 (0)