[nits] logging, old temp code

* override `description` for OSModelChangedArgs, OSDelta to print more details for them

* remove unnecessary logs
* remove old code / temp code
* Remove some overly verbose logs, prints

Author: nan-li

iOS_SDK/OneSignalSDK/OneSignalNotifications/OSNotificationsManager.m

@@ -226,7 +226,6 @@ + (BOOL)canRequestPermission {
 }
 
 + (void)requestPermission:(OSUserResponseBlock)block {
-    NSLog(@"🔥 requestPermission:(OSUserResponseBlock)block called");
     // return if the user has not granted privacy permissions
     if ([OSPrivacyConsentController shouldLogMissingPrivacyConsentErrorWithMethodName:@"requestPermission:"])
         return;

iOS_SDK/OneSignalSDK/OneSignalOSCore/Source/OSDelta.swift

@@ -38,6 +38,10 @@ open class OSDelta: NSObject, NSCoding {
     public let property: String
     public let value: Any
 
+    override open var description: String {
+        return "OSDelta \(name) with property: \(property) value: \(value)"
+    }
+
     public init(name: String, model: OSModel, property: String, value: Any) {
         self.name = name
         self.deltaId = UUID().uuidString

iOS_SDK/OneSignalSDK/OneSignalOSCore/Source/OSModelChangedHandler.swift

@@ -43,6 +43,10 @@ public class OSModelChangedArgs: NSObject {
      */
     public let newValue: Any
 
+    override public var description: String {
+        return "OSModelChangedArgs for model: \(model) with property: \(property) value: \(newValue)"
+    }
+    
     init(model: OSModel, property: String, newValue: Any) {
         self.model = model
         self.property = property

iOS_SDK/OneSignalSDK/OneSignalOSCore/Source/OSModelStore.swift

@@ -117,9 +117,7 @@ open class OSModelStore<TModel: OSModel>: NSObject {
      We may still need references to model(s) in this store!
      */
     @objc func removeModelsFromUserDefaults() {
-        print("🔥 OSModelStore \(self.storeKey): removeModelsFromUserDefaults() called.")
-        // Clear the UserDefaults models cache when OS_ON_USER_WILL_CHANGE
-
+        // Clear the UserDefaults models cache when OS_ON_USER_WILL_CHANGEclearModelsFromStore() called
         OneSignalUserDefaults.initShared().removeValue(forKey: self.storeKey)
     }
 
@@ -129,7 +127,6 @@ open class OSModelStore<TModel: OSModel>: NSObject {
      In contrast, it is not necessary for the Identity or Properties Model Stores to do so.
      */
     public func clearModelsFromStore() {
-        print("🔥 OSModelStore \(self.storeKey): clearModelsFromStore() called.")
         self.models = [:]
     }
 }

iOS_SDK/OneSignalSDK/OneSignalOSCore/Source/OSOperationRepo.swift

@@ -90,7 +90,6 @@ public class OSOperationRepo: NSObject {
             return
         }
         start()
-        print("🔥 OSOperationRepo addExecutor: \(executor)")
         executors.append(executor)
         for delta in executor.supportedDeltas {
             deltasToExecutorMap[delta] = executor

iOS_SDK/OneSignalSDK/OneSignalUser/Source/OSUserInternalImpl.swift

@@ -46,9 +46,6 @@ protocol OSUserInternal {
     func setLocation(lat:Float, long:Float)
     // Language
     func setLanguage(_ language: String?)
-
-    // TODO: UM This is a temporary function to create a push subscription for testing
-    func testCreatePushSubscription(subscriptionId: String, token: String, enabled: Bool) -> OSSubscriptionModel
 }
 
 /**
@@ -68,13 +65,6 @@ class OSUserInternalImpl: NSObject, OSUserInternal {
 
     // Sessions will be outside this?
 
-    // TODO: UM This is a temporary function to create a push subscription for testing
-    func testCreatePushSubscription(subscriptionId: String, token: String, enabled: Bool) -> OSSubscriptionModel {
-        pushSubscriptionModel = OSSubscriptionModel(type: .push, address: token, subscriptionId: subscriptionId, accepted: true, isDisabled: false, changeNotifier: OSEventProducer())
-        print("🔥 OSUserInternalImpl has set pushSubcription for testing")
-        return pushSubscriptionModel
-    }
-
     init(identityModel: OSIdentityModel, propertiesModel: OSPropertiesModel, pushSubscriptionModel: OSSubscriptionModel) {
         self.identityModel = identityModel
         self.propertiesModel = propertiesModel

iOS_SDK/OneSignalSDK/OneSignalUser/Source/OSUserRequests.swift

@@ -235,6 +235,7 @@ class OSRequestCreateUser: OneSignalRequest, OSUserRequest {
 
     func prepareForExecution() -> Bool {
         guard let appId = OneSignalConfigManager.getAppId() else {
+            OneSignalLog.onesignalLog(.LL_DEBUG, message: "Cannot generate the create user request due to null app ID.")
             return false
         }
         self.addJWTHeader(identityModel:identityModel)

iOS_SDK/OneSignalSDK/OneSignalUser/Source/OneSignalUserManagerImpl.swift

@@ -70,9 +70,6 @@ import OneSignalNotifications
     typealias OSJwtCompletionBlock = (_ newJwtToken: String) -> Void
     typealias OSJwtExpiredHandler =  (_ externalId: String, _ completion: OSJwtCompletionBlock) -> Void
     func onJwtExpired(expiredHandler: @escaping OSJwtExpiredHandler)
-
-    // TODO: UM This is a temporary function to create a push subscription for testing
-    func testCreatePushSubscription(subscriptionId: String, token: String, enabled: Bool)
 }
 
 /**
@@ -313,6 +310,7 @@ public class OneSignalUserManagerImpl: NSObject, OneSignalUserManager {
      and the operation repo flushing the current (soon to be old) user's operations.
      */
     private func prepareForNewUser() {
+        OneSignalLog.onesignalLog(.LL_VERBOSE, message: "OneSignalUserManagerImpl prepareForNewUser called")
         NotificationCenter.default.post(name: Notification.Name(OS_ON_USER_WILL_CHANGE), object: nil)
 
         // This store MUST be cleared, Identity and Properties do not.
@@ -607,13 +605,6 @@ extension OneSignalUserManagerImpl: OSUser {
         }
         user.setLanguage(language)
     }
-
-    public func testCreatePushSubscription(subscriptionId: String, token: String, enabled: Bool) {
-        guard !OneSignalConfigManager.shouldAwaitAppIdAndLogMissingPrivacyConsent(forMethod: nil) else {
-            return
-        }
-        user.testCreatePushSubscription(subscriptionId: subscriptionId, token: token, enabled: enabled)
-    }
 }
 
 extension OneSignalUserManagerImpl: OSPushSubscription {

iOS_SDK/OneSignalSDK/Source/OneSignal.m

@@ -406,8 +406,6 @@ + (void)startNewSessionInternal {
 
     sessionLaunchTime = [NSDate date];
 
-    [OneSignalLog onesignalLog:ONE_S_LL_VERBOSE message:@"Calling OneSignal `create/on_session`"];
-
     // TODO: Figure out if Create User also sets session_count automatically on backend
     [OneSignalUserManagerImpl.sharedInstance startNewSession];