Skip to content

Commit 2398cf2

Browse files
authored
Disable Clang Module Debugging (#443)
* Disable Clang Module Debugging • This commit disables clang module debugging for the OneSignalFramework target, to resolve DSYM warnings some developers have seen when using our static framework (#440) * Change Buildscript • Changes the buildscript to disable clang module debugging directly instead of modifying Xcode target project settings for the framework.
1 parent 04486aa commit 2398cf2

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

iOS_SDK/OneSignalSDK/OneSignal.xcodeproj/project.pbxproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1010,6 +1010,7 @@
10101010
CLANG_ANALYZER_NONNULL = YES;
10111011
CLANG_ENABLE_CODE_COVERAGE = NO;
10121012
CLANG_ENABLE_MODULES = YES;
1013+
CLANG_ENABLE_MODULE_DEBUGGING = YES;
10131014
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
10141015
CODE_SIGN_IDENTITY = "";
10151016
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "";
@@ -1158,6 +1159,7 @@
11581159
CLANG_ANALYZER_NONNULL = YES;
11591160
CLANG_ENABLE_CODE_COVERAGE = NO;
11601161
CLANG_ENABLE_MODULES = YES;
1162+
CLANG_ENABLE_MODULE_DEBUGGING = YES;
11611163
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
11621164
CODE_SIGN_IDENTITY = "";
11631165
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "";

iOS_SDK/OneSignalSDK/build_fat_framework.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ set -e
1515
set -o pipefail
1616

1717
# Build x86 based framework to support iOS simulator
18-
xcodebuild -configuration "${CONFIGURATION}" -project "${PROJECT_NAME}.xcodeproj" -target ${ONESIGNAL_TARGET_NAME} -sdk "iphonesimulator${SDK_VERSION}" "${ACTION}" ONLY_ACTIVE_ARCH=NO BITCODE_GENERATION_MODE=bitcode RUN_CLANG_STATIC_ANALYZER=NO BUILD_DIR="${BUILD_DIR}" BUILD_ROOT="${BUILD_ROOT}" SYMROOT="${SYMROOT}" MACH_O_TYPE=${ONESIGNAL_MACH_O_TYPE} -UseModernBuildSystem=NO
18+
xcodebuild -configuration "${CONFIGURATION}" -project "${PROJECT_NAME}.xcodeproj" -target ${ONESIGNAL_TARGET_NAME} -sdk "iphonesimulator${SDK_VERSION}" "${ACTION}" ONLY_ACTIVE_ARCH=NO BITCODE_GENERATION_MODE=bitcode RUN_CLANG_STATIC_ANALYZER=NO CLANG_ENABLE_MODULE_DEBUGGING=NO BUILD_DIR="${BUILD_DIR}" BUILD_ROOT="${BUILD_ROOT}" SYMROOT="${SYMROOT}" MACH_O_TYPE=${ONESIGNAL_MACH_O_TYPE} -UseModernBuildSystem=NO
1919

2020
# Build arm based framework to support actual iOS devices
21-
xcodebuild -configuration "${CONFIGURATION}" -project "${PROJECT_NAME}.xcodeproj" -target ${ONESIGNAL_TARGET_NAME} -sdk "iphoneos${SDK_VERSION}" "${ACTION}" ONLY_ACTIVE_ARCH=NO BITCODE_GENERATION_MODE=bitcode RUN_CLANG_STATIC_ANALYZER=NO BUILD_DIR="${BUILD_DIR}" BUILD_ROOT="${BUILD_ROOT}" SYMROOT="${SYMROOT}" MACH_O_TYPE=${ONESIGNAL_MACH_O_TYPE} -UseModernBuildSystem=NO
21+
xcodebuild -configuration "${CONFIGURATION}" -project "${PROJECT_NAME}.xcodeproj" -target ${ONESIGNAL_TARGET_NAME} -sdk "iphoneos${SDK_VERSION}" "${ACTION}" ONLY_ACTIVE_ARCH=NO BITCODE_GENERATION_MODE=bitcode RUN_CLANG_STATIC_ANALYZER=NO CLANG_ENABLE_MODULE_DEBUGGING=NO BUILD_DIR="${BUILD_DIR}" BUILD_ROOT="${BUILD_ROOT}" SYMROOT="${SYMROOT}" MACH_O_TYPE=${ONESIGNAL_MACH_O_TYPE} -UseModernBuildSystem=NO
2222

2323
CURRENTCONFIG_DEVICE_DIR=${SYMROOT}/${CONFIGURATION}-iphoneos/${ONESIGNAL_OUTPUT_NAME}.framework
2424
CURRENTCONFIG_SIMULATOR_DIR=${SYMROOT}/${CONFIGURATION}-iphonesimulator/${ONESIGNAL_OUTPUT_NAME}.framework

0 commit comments

Comments
 (0)