Skip to content

Commit 2d0552c

Browse files
committed
Fixed issue deleting non-string tags
* Fixed issue #230
1 parent 8cd8a89 commit 2d0552c

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

iOS_SDK/OneSignalSDK/Source/OneSignal.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -729,7 +729,7 @@ + (void)deleteTags:(NSArray*)keys onSuccess:(OSResultSuccessBlock)successBlock o
729729

730730
for(NSString* key in keys) {
731731
if (tagsToSend && tagsToSend[key]) {
732-
if (![tagsToSend[key] isEqualToString:@""])
732+
if (![tagsToSend[key] isEqual:@""])
733733
[tagsToSend removeObjectForKey:key];
734734
}
735735
else

iOS_SDK/OneSignalSDK/UnitTests/UnitTests.m

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1965,6 +1965,10 @@ - (void)testDeleteTags {
19651965
XCTAssertNil(lastHTTPRequset[@"tags"][@"key"]);
19661966
XCTAssertEqualObjects(lastHTTPRequset[@"tags"][@"key2"], @"value2");
19671967
XCTAssertEqual(networkRequestCount, 2);
1968+
1969+
1970+
[OneSignal sendTags:@{@"someKey": @NO}];
1971+
[OneSignal deleteTag:@"someKey"];
19681972
}
19691973

19701974
- (void)testSendTagsBeforeRegisterComplete {

0 commit comments

Comments
 (0)