Merge pull request #962 from OneSignal/fix/capability_error_detection

Fix missing push notification capability error detection

Author: jkasten2

iOS_SDK/OneSignalSDK/Source/OneSignal.m

@@ -1603,15 +1603,8 @@ + (void)handleDidFailRegisterForRemoteNotification:(NSError*)err {
     waitingForApnsResponse = false;
 
     if (err.code == 3000) {
-        if ([((NSString*)[err.userInfo objectForKey:NSLocalizedDescriptionKey]) rangeOfString:@"no valid 'aps-environment'"].location != NSNotFound) {
-            // User did not enable push notification capability
-            [OneSignal setSubscriptionErrorStatus:ERROR_PUSH_CAPABLILITY_DISABLED];
-            [OneSignal onesignal_Log:ONE_S_LL_ERROR message:@"ERROR! 'Push Notification' capability not turned on! Enable it in Xcode under 'Project Target' -> Capability."];
-        }
-        else {
-            [OneSignal setSubscriptionErrorStatus:ERROR_PUSH_OTHER_3000_ERROR];
-            [OneSignal onesignal_Log:ONE_S_LL_ERROR message:[NSString stringWithFormat:@"ERROR! Unknown 3000 error returned from APNs when getting a push token: %@", err]];
-        }
+        [OneSignal setSubscriptionErrorStatus:ERROR_PUSH_CAPABLILITY_DISABLED];
+        [OneSignal onesignal_Log:ONE_S_LL_ERROR message:@"ERROR! 'Push Notifications' capability missing! Add the capability in Xcode under 'Target' -> '<MyAppName(MainTarget)>' -> 'Signing & Capabilities' then click the '+ Capability' button."];
     }
     else if (err.code == 3010) {
         [OneSignal setSubscriptionErrorStatus:ERROR_PUSH_SIMULATOR_NOT_SUPPORTED];

iOS_SDK/OneSignalSDK/Source/OneSignalCommonDefines.h

@@ -221,7 +221,7 @@ typedef enum {GET, POST, HEAD, PUT, DELETE, OPTIONS, CONNECT, TRACE} HTTPMethod;
 #define ERROR_PUSH_DELEGATE_NEVER_FIRED    -14
 #define ERROR_PUSH_SIMULATOR_NOT_SUPPORTED -15
 #define ERROR_PUSH_UNKNOWN_APNS_ERROR      -16
-#define ERROR_PUSH_OTHER_3000_ERROR        -17
+#define ERROR_PUSH_OTHER_3000_ERROR_UNUSED_RESERVED -17
 #define ERROR_PUSH_NEVER_PROMPTED          -18
 #define ERROR_PUSH_PROMPT_NEVER_ANSWERED   -19