Skip to content

Commit 2e2ec42

Browse files
committed
update setLanguage method
* Don't allow setting language to nil (language param is not optional) * Don't let setting language to ""
1 parent 85e56f7 commit 2e2ec42

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

iOS_SDK/OneSignalSDK/OneSignalUser/Source/OneSignalUserManagerImpl.swift

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ import OneSignalNotifications
6565
func addSmsNumber(_ number: String)
6666
func removeSmsNumber(_ number: String) -> Bool
6767
// Language
68-
func setLanguage(_ language: String?) // TODO: why optional? As a remove?
68+
func setLanguage(_ language: String)
6969
// JWT Token Expire
7070
typealias OSJwtCompletionBlock = (_ newJwtToken: String) -> Void
7171
typealias OSJwtExpiredHandler = (_ externalId: String, _ completion: OSJwtCompletionBlock) -> Void
@@ -646,10 +646,16 @@ extension OneSignalUserManagerImpl: OSUser {
646646
return self.subscriptionModelStore.remove(number)
647647
}
648648

649-
public func setLanguage(_ language: String?) {
649+
public func setLanguage(_ language: String) {
650650
guard !OneSignalConfigManager.shouldAwaitAppIdAndLogMissingPrivacyConsent(forMethod: "setLanguage") else {
651651
return
652652
}
653+
654+
if language == "" {
655+
OneSignalLog.onesignalLog(.LL_ERROR, message: "OneSignal.User.setLanguage cannot be called with an empty language code.")
656+
return
657+
}
658+
653659
user.setLanguage(language)
654660
}
655661
}

0 commit comments

Comments
 (0)