Skip to content

Commit 2fe6e89

Browse files
authored
Merge pull request #1401 from OneSignal/test_code_signing
[CD] code sign release binaries
2 parents f373135 + 1c6736f commit 2fe6e89

File tree

1 file changed

+24
-2
lines changed

1 file changed

+24
-2
lines changed

.github/workflows/cd.yml

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,20 @@ jobs:
2727
with:
2828
ref: ${{github.event.inputs.release_branch}}
2929

30-
- name: Install the Apple certificate and provisioning profile
30+
- name: Install the Apple distribution certificate and provisioning profile
3131
uses: apple-actions/import-codesign-certs@v2
32-
with:
32+
with:
33+
keychain-password: ${{ secrets.CERTIFICATES_P12_PASSWORD }}
3334
p12-file-base64: ${{ secrets.CERTIFICATES_P12 }}
3435
p12-password: ${{ secrets.CERTIFICATES_P12_PASSWORD }}
36+
37+
- name: Install the Apple distribution certificate and provisioning profile
38+
uses: apple-actions/import-codesign-certs@v2
39+
with:
40+
create-keychain: false # do not create a new keychain for this value
41+
keychain-password: ${{ secrets.CERTIFICATES_P12_PASSWORD }}
42+
p12-file-base64: ${{ secrets.DEV_CERTIFICATES_P12 }}
43+
p12-password: ${{ secrets.DEV_CERTIFICATES_P12_PASSWORD }}
3544
# - name: Bump Version Number
3645
# run: |
3746
- name: Build Binaries
@@ -46,6 +55,19 @@ jobs:
4655
chmod +x ./update_swift_package.sh
4756
./update_swift_package.sh ${{github.event.inputs.version}}
4857
shell: bash
58+
- name: Code Sign
59+
run: |
60+
cd iOS_SDK/OneSignalSDK
61+
codesign --timestamp -v --sign "Apple Distribution: OneSignal, Inc. (J3J28YJX9L)" OneSignal_Core/OneSignalCore.xcframework
62+
codesign --timestamp -v --sign "Apple Distribution: OneSignal, Inc. (J3J28YJX9L)" OneSignal_Extension/OneSignalExtension.xcframework
63+
codesign --timestamp -v --sign "Apple Distribution: OneSignal, Inc. (J3J28YJX9L)" OneSignal_InAppMessages/OneSignalInAppMessages.xcframework
64+
codesign --timestamp -v --sign "Apple Distribution: OneSignal, Inc. (J3J28YJX9L)" OneSignal_Location/OneSignalLocation.xcframework
65+
codesign --timestamp -v --sign "Apple Distribution: OneSignal, Inc. (J3J28YJX9L)" OneSignal_Notifications/OneSignalNotifications.xcframework
66+
codesign --timestamp -v --sign "Apple Distribution: OneSignal, Inc. (J3J28YJX9L)" OneSignal_OSCore/OneSignalOSCore.xcframework
67+
codesign --timestamp -v --sign "Apple Distribution: OneSignal, Inc. (J3J28YJX9L)" OneSignal_Outcomes/OneSignalOutcomes.xcframework
68+
codesign --timestamp -v --sign "Apple Distribution: OneSignal, Inc. (J3J28YJX9L)" OneSignal_User/OneSignalUser.xcframework
69+
codesign --timestamp -v --sign "Apple Distribution: OneSignal, Inc. (J3J28YJX9L)" OneSignal_XCFramework/OneSignalFramework.xcframework
70+
shell: bash
4971
- name: Commit Changes
5072
run: |
5173
git config --local user.email "[email protected]"

0 commit comments

Comments
 (0)