Skip to content

Commit 37ede25

Browse files
authored
Merge pull request #1446 from OneSignal/fix/live_activities_mac_catalyst
OneSignalLiveActivities framework included for mac catalyst
2 parents 25f0657 + b105eba commit 37ede25

File tree

6 files changed

+21
-36
lines changed

6 files changed

+21
-36
lines changed

iOS_SDK/OneSignalSDK/OneSignal.xcodeproj/project.pbxproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5413,7 +5413,7 @@
54135413
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
54145414
SKIP_INSTALL = YES;
54155415
SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
5416-
SUPPORTS_MACCATALYST = NO;
5416+
SUPPORTS_MACCATALYST = YES;
54175417
SWIFT_COMPILATION_MODE = wholemodule;
54185418
SWIFT_EMIT_LOC_STRINGS = YES;
54195419
SWIFT_VERSION = 5.0;
@@ -5486,7 +5486,7 @@
54865486
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
54875487
SKIP_INSTALL = YES;
54885488
SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
5489-
SUPPORTS_MACCATALYST = NO;
5489+
SUPPORTS_MACCATALYST = YES;
54905490
SWIFT_ACTIVE_COMPILATION_CONDITIONS = "DEBUG $(inherited)";
54915491
SWIFT_EMIT_LOC_STRINGS = YES;
54925492
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
@@ -5554,7 +5554,7 @@
55545554
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
55555555
SKIP_INSTALL = YES;
55565556
SUPPORTED_PLATFORMS = "iphoneos iphonesimulator";
5557-
SUPPORTS_MACCATALYST = NO;
5557+
SUPPORTS_MACCATALYST = YES;
55585558
SWIFT_COMPILATION_MODE = wholemodule;
55595559
SWIFT_EMIT_LOC_STRINGS = YES;
55605560
SWIFT_VERSION = 5.0;

iOS_SDK/OneSignalSDK/OneSignalLiveActivities/Source/DefaultLiveActivityAttributes.swift

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@
2525
THE SOFTWARE.
2626
*/
2727

28+
// Effectively blanks out this file for Mac Catalyst
29+
#if targetEnvironment(macCatalyst)
30+
#else
31+
2832
/**
2933
A default struct conforming to OneSignalLiveActivityAttributes which is registered with OneSignal as a Live Activity
3034
through `OneSignal.LiveActivities.setupDefault`. The only action required by the customer app is
@@ -74,3 +78,4 @@ public struct DefaultLiveActivityAttributes: OneSignalLiveActivityAttributes {
7478
public var data: [String: AnyCodable]
7579
public var onesignal: OneSignalLiveActivityAttributeData
7680
}
81+
#endif

iOS_SDK/OneSignalSDK/OneSignalLiveActivities/Source/OSLiveActivitiesExtension.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@
2525
THE SOFTWARE.
2626
*/
2727

28+
// Effectively blanks out this file for Mac Catalyst
29+
#if targetEnvironment(macCatalyst)
30+
#else
2831
import OneSignalOSCore
2932
import ActivityKit
3033

@@ -116,3 +119,4 @@ public class LiveActivitySetupOptions: NSObject {
116119
self.enablePushToUpdate = enablePushToUpdate
117120
}
118121
}
122+
#endif

iOS_SDK/OneSignalSDK/OneSignalLiveActivities/Source/OneSignalLiveActivitiesManagerImpl.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@
2525
THE SOFTWARE.
2626
*/
2727

28+
// Effectively blanks out this file for Mac Catalyst
29+
#if targetEnvironment(macCatalyst)
30+
#else
2831
import OneSignalCore
2932
import OneSignalOSCore
3033
import ActivityKit
@@ -238,3 +241,4 @@ public class OneSignalLiveActivitiesManagerImpl: NSObject, OSLiveActivities {
238241
}
239242
}
240243
}
244+
#endif

iOS_SDK/OneSignalSDK/OneSignalLiveActivities/Source/OneSignalLiveActivityAttributes.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@
2525
THE SOFTWARE.
2626
*/
2727

28+
// Effectively blanks out this file for Mac Catalyst
29+
#if targetEnvironment(macCatalyst)
30+
#else
2831
import ActivityKit
2932

3033
/**
@@ -83,3 +86,4 @@ public protocol OneSignalLiveActivityContentState: Decodable, Encodable, Hashabl
8386
public struct OneSignalLiveActivityContentStateData: Decodable, Encodable, Hashable {
8487
public var notificationId: String
8588
}
89+
#endif

iOS_SDK/OneSignalSDK/build_all_frameworks.sh

Lines changed: 1 addition & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -39,38 +39,6 @@ create_xcframework() {
3939
rm -rf "${CATALYST_ARCHIVE_PATH}"
4040
}
4141

42-
create_xcframework_no_catalyst() {
43-
FRAMEWORK_FOLDER_NAME=$1
44-
45-
FRAMEWORK_NAME=$2
46-
47-
FRAMEWORK_PATH="${WORKING_DIR}/${FRAMEWORK_FOLDER_NAME}/${FRAMEWORK_NAME}.xcframework"
48-
49-
BUILD_SCHEME=$3
50-
51-
SIMULATOR_ARCHIVE_PATH="${WORKING_DIR}/${FRAMEWORK_FOLDER_NAME}/simulator.xcarchive"
52-
53-
IOS_DEVICE_ARCHIVE_PATH="${WORKING_DIR}/${FRAMEWORK_FOLDER_NAME}/iOS.xcarchive"
54-
55-
rm -rf "${WORKING_DIR}/${FRAMEWORK_FOLDER_NAME}"
56-
echo "Deleted ${FRAMEWORK_FOLDER_NAME}"
57-
mkdir "${FRAMEWORK_FOLDER_NAME}"
58-
echo "Created ${FRAMEWORK_FOLDER_NAME}"
59-
echo "Archiving ${FRAMEWORK_NAME}"
60-
61-
xcodebuild -list
62-
63-
xcodebuild archive ONLY_ACTIVE_ARCH=NO -scheme ${BUILD_SCHEME} -destination="generic/platform=iOS Simulator" -archivePath "${SIMULATOR_ARCHIVE_PATH}" -sdk iphonesimulator SKIP_INSTALL=NO BUILD_LIBRARIES_FOR_DISTRIBUTION=YES
64-
65-
xcodebuild archive -scheme ${BUILD_SCHEME} -destination="generic/platform=iOS" -archivePath "${IOS_DEVICE_ARCHIVE_PATH}" -sdk iphoneos SKIP_INSTALL=NO BUILD_LIBRARIES_FOR_DISTRIBUTION=YES
66-
67-
xcodebuild -create-xcframework -framework ${SIMULATOR_ARCHIVE_PATH}/Products/Library/Frameworks/${FRAMEWORK_NAME}.framework -framework ${IOS_DEVICE_ARCHIVE_PATH}/Products/Library/Frameworks/${FRAMEWORK_NAME}.framework -output "${FRAMEWORK_PATH}"
68-
69-
rm -rf "${SIMULATOR_ARCHIVE_PATH}"
70-
rm -rf "${IOS_DEVICE_ARCHIVE_PATH}"
71-
rm -rf "${CATALYST_ARCHIVE_PATH}"
72-
}
73-
7442
# BUILD ONESIGNAL CORE ##
7543
create_xcframework "OneSignal_Core" "OneSignalCore" "OneSignalCore"
7644

@@ -90,7 +58,7 @@ create_xcframework "OneSignal_Notifications" "OneSignalNotifications" "OneSignal
9058
create_xcframework "OneSignal_User" "OneSignalUser" "OneSignalUser"
9159

9260
## BUILD ONESIGNAL LIVE ACTIVITIES ##
93-
create_xcframework_no_catalyst "OneSignal_LiveActivities" "OneSignalLiveActivities" "OneSignalLiveActivities"
61+
create_xcframework "OneSignal_LiveActivities" "OneSignalLiveActivities" "OneSignalLiveActivities"
9462

9563
## BUILD ONESIGNAL USER ##
9664
create_xcframework "OneSignal_Location" "OneSignalLocation" "OneSignalLocation"

0 commit comments

Comments
 (0)