Skip to content

Commit 431863a

Browse files
committed
Fix LanguageTest
* Remove runBackgroundThreads to avoid redundancy * Fix comments
1 parent 7c8cad1 commit 431863a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

iOS_SDK/OneSignalSDK/UnitTests/LanguageTest.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,20 +59,19 @@ - (void)testSetLanguageOnPlayerCreate {
5959

6060
- (void)testSetLanguageRequest {
6161
[UnitTestCommonMethods initOneSignal_andThreadWait];
62-
[UnitTestCommonMethods runBackgroundThreads];
6362
[OneSignal setLanguage:@"fr"];
6463
[UnitTestCommonMethods runBackgroundThreads];
6564

6665
XCTAssertEqualObjects(OneSignalClientOverrider.lastHTTPRequest[@"language"], @"fr");
6766
}
6867

6968
-(void)testSetLanguage_afterOnSession {
70-
// 2. Open app
69+
// 1. Open app
7170
[UnitTestCommonMethods initOneSignal_andThreadWait];
7271
[UnitTestCommonMethods foregroundApp];
7372
[UnitTestCommonMethods runBackgroundThreads];
7473

75-
// 3. Kill the app and wait 31 seconds
74+
// 2. Kill the app and wait 31 seconds
7675
[UnitTestCommonMethods backgroundApp];
7776
[UnitTestCommonMethods clearStateForAppRestart:self];
7877
[NSDateOverrider advanceSystemTimeBy:31];
@@ -83,6 +82,7 @@ -(void)testSetLanguage_afterOnSession {
8382
[UnitTestCommonMethods foregroundApp];
8483
[UnitTestCommonMethods runBackgroundThreads];
8584

85+
// 5. Set language
8686
[OneSignal setLanguage:@"fr"];
8787
[UnitTestCommonMethods runBackgroundThreads];
8888

0 commit comments

Comments
 (0)