Fix URLs (#356)

* Fix URLs

• Sending an image URL with query parameters used to not work.
• The SDK was checking the end of URL's to make sure they were an image or other media type (ie. making sure it ended in .jpeg, .mp3, etc)
• Changed the SDK so that it will now remove query parameters from the end of URL's before attempting to type check the file extension

* Add URL Test

• Adds a test to make sure the SDK appropriately handles media URL's even if they have query parameters

Author: Nightsd01

iOS_SDK/OneSignalSDK/Source/OneSignalHelper.m

@@ -710,7 +710,12 @@ + (void)addNotificationRequest:(OSNotificationPayload*)payload
 
 // Synchroneously downloads a media
 // On success returns bundle resource name, otherwise returns nil
-+ (NSString*)downloadMediaAndSaveInBundle:(NSString*)url {
++ (NSString*)downloadMediaAndSaveInBundle:(NSString*)urlString {
+    
+    let inputUrl = [NSURL URLWithString:urlString];
+    
+    //removes any unnecessary query parameters that would break extension type checking
+    let url = [[NSURL alloc] initWithScheme:inputUrl.scheme host:inputUrl.host path:inputUrl.path].absoluteString;
 
     NSArray<NSString*>* supportedExtensions = @[@"aiff", @"wav", @"mp3", @"mp4", @"jpg", @"jpeg", @"png", @"gif", @"mpeg", @"mpg", @"avi", @"m4a", @"m4v"];
     NSArray* components = [url componentsSeparatedByString:@"."];

iOS_SDK/OneSignalSDK/UnitTests/UnitTests.m

@@ -79,6 +79,10 @@
 #import "OneSignalClientOverrider.h"
 #import "OneSignalCommonDefines.h"
 
+@interface OneSignalHelper (TestHelper)
++ (NSString*)downloadMediaAndSaveInBundle:(NSString*)urlString;
+@end
+
 
 @interface UnitTests : XCTestCase
 
@@ -1837,4 +1841,13 @@ -(void)testDelayedSubscriptionUpdate {
     XCTAssertTrue(observer->last.to.subscribed);
 }
 
+// Checks to make sure that media URL's will not fail the extension-type check if they have query parameters
+- (void)testHandlingMediaUrlExtensions {
+    let testUrl = @"https://images.pexels.com/photos/104827/cat-pet-animal-domestic-104827.jpeg?auto=compress&cs=tinysrgb&dpr=2&h=100";
+    
+    let cacheName = [OneSignalHelper downloadMediaAndSaveInBundle:testUrl];
+    
+    XCTAssertNotNil(cacheName);
+}
+
 @end