Fix Invalid App ID Error

Nightsd01 · Nightsd01 · commit 4624a2c03d2d · 2018-01-29T13:22:04.000-08:00
• Fixes an iOS specific issue with the OneSignal Unity SDK where "Fatal: Invalid AppId Format" error was printed to console and initialization didn't finish on the first init() call (OneSignal-Unity-SDK Error #77)
diff --git a/iOS_SDK/OneSignalSDK/Source/OneSignal.m b/iOS_SDK/OneSignalSDK/Source/OneSignal.m
@@ -431,9 +431,11 @@ +(bool)initAppId:(NSString*)appId withUserDefaults:(NSUserDefaults*)userDefaults
     }
     
     if (!app_id) {
+        app_id  = [userDefaults stringForKey:@"GT_APP_ID"];
         if (![settings[kOSSettingsKeyInOmitNoAppIdLogging] boolValue])
             onesignal_Log(ONE_S_LL_FATAL, @"OneSignal AppId never set!");
-        app_id  = [userDefaults stringForKey:@"GT_APP_ID"];
+        else
+            return true;
     }
     else if (![app_id isEqualToString:[userDefaults stringForKey:@"GT_APP_ID"]]) {
         // Handle changes to the app id. This might happen on a developer's device when testing

Original file line number	Diff line number	Diff line change
`@@ -431,9 +431,11 @@ +(bool)initAppId:(NSString)appId withUserDefaults:(NSUserDefaults)userDefaults`
`431`	`431`	`}`
`432`	`432`
`433`	`433`	`if (!app_id) {`
	`434`	`+ app_id = [userDefaults stringForKey:@"GT_APP_ID"];`
`434`	`435`	`if (![settings[kOSSettingsKeyInOmitNoAppIdLogging] boolValue])`
`435`	`436`	`onesignal_Log(ONE_S_LL_FATAL, @"OneSignal AppId never set!");`
`436`		`- app_id = [userDefaults stringForKey:@"GT_APP_ID"];`
	`437`	`+ else`
	`438`	`+ return true;`
`437`	`439`	`}`
`438`	`440`	`else if (![app_id isEqualToString:[userDefaults stringForKey:@"GT_APP_ID"]]) {`
`439`	`441`	`// Handle changes to the app id. This might happen on a developer's device when testing`