Skip to content

Commit 58cad6f

Browse files
committed
[nit] remove some old non-existent methods
OSInAppMessageDelegate and handleMessageAction not used by anything
1 parent 9695f85 commit 58cad6f

File tree

6 files changed

+6
-24
lines changed

6 files changed

+6
-24
lines changed

iOS_SDK/OneSignalDevApp/OneSignalDevApp/AppDelegate.m

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -117,11 +117,6 @@ - (void)onPushSubscriptionDidChangeWithState:(OSPushSubscriptionChangedState *)s
117117

118118
#pragma mark OSInAppMessageDelegate
119119

120-
- (void)handleMessageAction:(OSInAppMessageAction *)action {
121-
NSLog(@"OSInAppMessageDelegate: handling message action: %@",action);
122-
return;
123-
}
124-
125120
- (void)onClickInAppMessage:(OSInAppMessageClickEvent * _Nonnull)event {
126121
NSLog(@"Dev App onClickInAppMessage event: %@", [event jsonRepresentation]);
127122
}
@@ -135,22 +130,22 @@ - (void)onWillDisplayNotification:(OSNotificationWillDisplayEvent *)event {
135130
}
136131

137132
- (void)onWillDisplayInAppMessage:(OSInAppMessageWillDisplayEvent *)event {
138-
NSLog(@"OSInAppMessageDelegate: onWillDisplay Message: %@",event.message);
133+
NSLog(@"Dev App OSInAppMessageLifecycleListener: onWillDisplay Message: %@",event.message);
139134
return;
140135
}
141136

142137
- (void)onDidDisplayInAppMessage:(OSInAppMessageDidDisplayEvent *)event {
143-
NSLog(@"OSInAppMessageDelegate: onDidDisplay Message: %@",event.message);
138+
NSLog(@"Dev App OSInAppMessageLifecycleListener: onDidDisplay Message: %@",event.message);
144139
return;
145140
}
146141

147142
- (void)onWillDismissInAppMessage:(OSInAppMessageWillDismissEvent *)event {
148-
NSLog(@"OSInAppMessageDelegate: onWillDismiss Message: %@",event.message);
143+
NSLog(@"Dev App OSInAppMessageLifecycleListener: onWillDismiss Message: %@",event.message);
149144
return;
150145
}
151146

152147
- (void)onDidDismissInAppMessage:(OSInAppMessageDidDismissEvent *)event {
153-
NSLog(@"OSInAppMessageDelegate: onDidDismiss Message: %@",event.message);
148+
NSLog(@"Dev App OSInAppMessageLifecycleListener: onDidDismiss Message: %@",event.message);
154149
return;
155150
}
156151

iOS_SDK/OneSignalDevApp/OneSignalDevApp/ViewController.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
#import <UIKit/UIKit.h>
3232
#import <OneSignalFramework/OneSignalFramework.h>
3333

34-
@interface ViewController : UIViewController <OSInAppMessageDelegate>
34+
@interface ViewController : UIViewController
3535

3636
@property (weak, nonatomic) IBOutlet UIActivityIndicatorView *activityIndicatorView;
3737
@property (weak, nonatomic) IBOutlet UISegmentedControl *consentSegmentedControl;

iOS_SDK/OneSignalDevApp/OneSignalDevApp/ViewController.m

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -190,10 +190,6 @@ - (IBAction)inAppMessagingSegmentedControlValueChanged:(UISegmentedControl *)sen
190190
[OneSignal.InAppMessages paused:(bool) !sender.selectedSegmentIndex];
191191
}
192192

193-
- (void)handleMessageAction:(NSString *)actionId {
194-
NSLog(@"View controller did get action: %@", actionId);
195-
}
196-
197193
- (IBAction)loginExternalUserId:(UIButton *)sender {
198194
NSString* externalUserId = self.externalUserIdTextField.text;
199195
NSLog(@"Dev App: Logging in to external user ID %@", externalUserId);

iOS_SDK/OneSignalDevApp/OneSignalDevAppClip/ViewController.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
#import <UIKit/UIKit.h>
3232
#import <OneSignalFramework/OneSignalFramework.h>
3333

34-
@interface ViewController : UIViewController <OSInAppMessageDelegate>
34+
@interface ViewController : UIViewController
3535

3636
@property (weak, nonatomic) IBOutlet UIActivityIndicatorView *activityIndicatorView;
3737
@property (weak, nonatomic) IBOutlet UISegmentedControl *consentSegmentedControl;

iOS_SDK/OneSignalDevApp/OneSignalDevAppClip/ViewController.m

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -144,10 +144,6 @@ - (IBAction)inAppMessagingSegmentedControlValueChanged:(UISegmentedControl *)sen
144144
[OneSignal.InAppMessages paused:(bool) !sender.selectedSegmentIndex];
145145
}
146146

147-
- (void)handleMessageAction:(NSString *)actionId {
148-
NSLog(@"View controller did get action: %@", actionId);
149-
}
150-
151147
- (IBAction)loginExternalUserId:(UIButton *)sender {
152148
NSLog(@"setExternalUserId is no longer supported. Please use login or addAlias.");
153149
// TODO: Update

iOS_SDK/OneSignalSDK/Source/OneSignalInAppMessaging.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,6 @@ typedef NS_ENUM(NSUInteger, OSInAppMessageActionUrlType) {
7676

7777
@end
7878

79-
@protocol OSInAppMessageDelegate <NSObject>
80-
@optional
81-
- (void)handleMessageAction:(OSInAppMessageClickResult * _Nonnull)action NS_SWIFT_NAME(handleMessageAction(action:));
82-
@end
83-
8479
@interface OSInAppMessageWillDisplayEvent : NSObject
8580
@property (nonatomic, readonly, nonnull) OSInAppMessage *message;
8681
@end

0 commit comments

Comments
 (0)