Skip to content

Commit 59599ee

Browse files
committed
renamed loadedTags to calledLoadTags for clarity
The intent of the boolean is to ensure we only make the server call once per session.
1 parent f175725 commit 59599ee

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

iOS_SDK/OneSignalSDK/Source/OSMessagingController.m

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ @interface OSMessagingController ()
8181

8282
@property (nonatomic) BOOL isAppInactive;
8383

84-
@property (nonatomic) BOOL loadedTags;
84+
@property (nonatomic) BOOL calledLoadTags;
8585

8686
@end
8787

@@ -173,7 +173,7 @@ - (void)updateInAppMessagesFromOnSession:(NSArray<OSInAppMessage *> *)newMessage
173173
if (self.messages)
174174
[OneSignalUserDefaults.initStandard saveCodeableDataForKey:OS_IAM_MESSAGES_ARRAY withValue:self.messages];
175175

176-
self.loadedTags = NO;
176+
self.calledLoadTags = NO;
177177
[self resetRedisplayMessagesBySession];
178178
[self evaluateMessages];
179179
[self deleteOldRedisplayedInAppMessages];
@@ -280,7 +280,7 @@ - (void)displayMessage:(OSInAppMessage *)message {
280280

281281
- (void)showAndImpressMessage:(OSInAppMessage *)message {
282282
self.viewController = [[OSInAppMessageViewController alloc] initWithMessage:message delegate:self];
283-
if (message.hasLiquid && !self.loadedTags) {
283+
if (message.hasLiquid && !self.calledLoadTags) {
284284
self.viewController.waitForTags = YES;
285285
[self loadTags];
286286
}
@@ -291,7 +291,7 @@ - (void)showAndImpressMessage:(OSInAppMessage *)message {
291291
}
292292

293293
- (void)loadTags {
294-
self.loadedTags = YES;
294+
self.calledLoadTags = YES;
295295
[OneSignal getTags:^(NSDictionary *result) {
296296
if (self.viewController) {
297297
self.viewController.waitForTags = NO;

0 commit comments

Comments
 (0)