Skip to content

Commit 59cf17d

Browse files
committed
renaming OSInAppMessage to OSInAppMessageInternal
1 parent 59b7cb4 commit 59cf17d

22 files changed

+179
-179
lines changed

iOS_SDK/OneSignalSDK/OneSignal.xcodeproj/project.pbxproj

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -464,10 +464,10 @@
464464
CACBAA9D218A6243000ACAA5 /* OSInAppMessageView.m in Sources */ = {isa = PBXBuildFile; fileRef = CACBAA92218A6242000ACAA5 /* OSInAppMessageView.m */; };
465465
CACBAA9E218A6243000ACAA5 /* OSInAppMessageView.m in Sources */ = {isa = PBXBuildFile; fileRef = CACBAA92218A6242000ACAA5 /* OSInAppMessageView.m */; };
466466
CACBAA9F218A6243000ACAA5 /* OSInAppMessageView.m in Sources */ = {isa = PBXBuildFile; fileRef = CACBAA92218A6242000ACAA5 /* OSInAppMessageView.m */; };
467-
CACBAAA0218A6243000ACAA5 /* OSInAppMessage.h in Headers */ = {isa = PBXBuildFile; fileRef = CACBAA93218A6243000ACAA5 /* OSInAppMessage.h */; };
468-
CACBAAA1218A6243000ACAA5 /* OSInAppMessage.m in Sources */ = {isa = PBXBuildFile; fileRef = CACBAA94218A6243000ACAA5 /* OSInAppMessage.m */; };
469-
CACBAAA2218A6243000ACAA5 /* OSInAppMessage.m in Sources */ = {isa = PBXBuildFile; fileRef = CACBAA94218A6243000ACAA5 /* OSInAppMessage.m */; };
470-
CACBAAA3218A6243000ACAA5 /* OSInAppMessage.m in Sources */ = {isa = PBXBuildFile; fileRef = CACBAA94218A6243000ACAA5 /* OSInAppMessage.m */; };
467+
CACBAAA0218A6243000ACAA5 /* OSInAppMessageInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = CACBAA93218A6243000ACAA5 /* OSInAppMessageInternal.h */; };
468+
CACBAAA1218A6243000ACAA5 /* OSInAppMessageInternal.m in Sources */ = {isa = PBXBuildFile; fileRef = CACBAA94218A6243000ACAA5 /* OSInAppMessageInternal.m */; };
469+
CACBAAA2218A6243000ACAA5 /* OSInAppMessageInternal.m in Sources */ = {isa = PBXBuildFile; fileRef = CACBAA94218A6243000ACAA5 /* OSInAppMessageInternal.m */; };
470+
CACBAAA3218A6243000ACAA5 /* OSInAppMessageInternal.m in Sources */ = {isa = PBXBuildFile; fileRef = CACBAA94218A6243000ACAA5 /* OSInAppMessageInternal.m */; };
471471
CACBAAA4218A6243000ACAA5 /* OSInAppMessageViewController.m in Sources */ = {isa = PBXBuildFile; fileRef = CACBAA95218A6243000ACAA5 /* OSInAppMessageViewController.m */; };
472472
CACBAAA5218A6243000ACAA5 /* OSInAppMessageViewController.m in Sources */ = {isa = PBXBuildFile; fileRef = CACBAA95218A6243000ACAA5 /* OSInAppMessageViewController.m */; };
473473
CACBAAA6218A6243000ACAA5 /* OSInAppMessageViewController.m in Sources */ = {isa = PBXBuildFile; fileRef = CACBAA95218A6243000ACAA5 /* OSInAppMessageViewController.m */; };
@@ -818,8 +818,8 @@
818818
CACBAA90218A6242000ACAA5 /* OSMessagingController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = OSMessagingController.h; sourceTree = "<group>"; };
819819
CACBAA91218A6242000ACAA5 /* OSInAppMessageView.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = OSInAppMessageView.h; sourceTree = "<group>"; };
820820
CACBAA92218A6242000ACAA5 /* OSInAppMessageView.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = OSInAppMessageView.m; sourceTree = "<group>"; };
821-
CACBAA93218A6243000ACAA5 /* OSInAppMessage.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = OSInAppMessage.h; sourceTree = "<group>"; };
822-
CACBAA94218A6243000ACAA5 /* OSInAppMessage.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = OSInAppMessage.m; sourceTree = "<group>"; };
821+
CACBAA93218A6243000ACAA5 /* OSInAppMessageInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = OSInAppMessageInternal.h; sourceTree = "<group>"; };
822+
CACBAA94218A6243000ACAA5 /* OSInAppMessageInternal.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = OSInAppMessageInternal.m; sourceTree = "<group>"; };
823823
CACBAA95218A6243000ACAA5 /* OSInAppMessageViewController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = OSInAppMessageViewController.m; sourceTree = "<group>"; };
824824
CACBAAA7218A6280000ACAA5 /* OSJSONHandling.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = OSJSONHandling.h; sourceTree = "<group>"; };
825825
CACBAAA9218A65AE000ACAA5 /* InAppMessagingTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = InAppMessagingTests.m; sourceTree = "<group>"; };
@@ -1413,8 +1413,8 @@
14131413
children = (
14141414
CA47439B2190FEA80020DC8C /* OSTrigger.h */,
14151415
CA47439C2190FEA80020DC8C /* OSTrigger.m */,
1416-
CACBAA93218A6243000ACAA5 /* OSInAppMessage.h */,
1417-
CACBAA94218A6243000ACAA5 /* OSInAppMessage.m */,
1416+
CACBAA93218A6243000ACAA5 /* OSInAppMessageInternal.h */,
1417+
CACBAA94218A6243000ACAA5 /* OSInAppMessageInternal.m */,
14181418
CAB269D721B0B6F000F8A43C /* OSInAppMessageAction.h */,
14191419
CAB269D821B0B6F000F8A43C /* OSInAppMessageAction.m */,
14201420
CAB269DD21B2038B00F8A43C /* OSInAppMessageBridgeEvent.h */,
@@ -1583,7 +1583,7 @@
15831583
7A1232A5235E179B002B6CE3 /* OSIndirectInfluence.h in Headers */,
15841584
91F58D7F1E7C7F5F0017D24D /* OneSignalNotificationSettingsIOS10.h in Headers */,
15851585
912412391E73342200E41FD7 /* OneSignalWebView.h in Headers */,
1586-
CACBAAA0218A6243000ACAA5 /* OSInAppMessage.h in Headers */,
1586+
CACBAAA0218A6243000ACAA5 /* OSInAppMessageInternal.h in Headers */,
15871587
91C7725E1E7CCE1000D612D0 /* OneSignalInternal.h in Headers */,
15881588
CAB269DF21B2038B00F8A43C /* OSInAppMessageBridgeEvent.h in Headers */,
15891589
9129C6BD1E89E7AB009CB6A0 /* OSSubscription.h in Headers */,
@@ -1884,7 +1884,7 @@
18841884
A6D7093D26962C95007B3347 /* OneSignalSetLanguageParameters.m in Sources */,
18851885
7AF9865E2447C13C00C36EAE /* OSInfluenceDataRepository.m in Sources */,
18861886
7AECE59E23675F6300537907 /* OSFocusTimeProcessorFactory.m in Sources */,
1887-
CACBAAA1218A6243000ACAA5 /* OSInAppMessage.m in Sources */,
1887+
CACBAAA1218A6243000ACAA5 /* OSInAppMessageInternal.m in Sources */,
18881888
CA63AFC32022670A00E340FB /* ReattemptRequest.m in Sources */,
18891889
912412221E73342200E41FD7 /* OneSignalLocation.m in Sources */,
18901890
CACBAAA4218A6243000ACAA5 /* OSInAppMessageViewController.m in Sources */,
@@ -1985,7 +1985,7 @@
19851985
A63E9E3C26742B5F00EA273E /* LanguageContext.m in Sources */,
19861986
7AC8D3A924993A0F0023EDE8 /* OSDeviceState.m in Sources */,
19871987
CA810FD2202BA97600A60FED /* OSEmailSubscription.m in Sources */,
1988-
CACBAAA2218A6243000ACAA5 /* OSInAppMessage.m in Sources */,
1988+
CACBAAA2218A6243000ACAA5 /* OSInAppMessageInternal.m in Sources */,
19891989
7A674F1C2360D82E001F9ACD /* OSBaseFocusTimeProcessor.m in Sources */,
19901990
7AF9868124497BE100C36EAE /* OSOutcomeEventsV1Repository.m in Sources */,
19911991
7AFE856C2368DDB80091D6A5 /* OSFocusCallParams.m in Sources */,
@@ -2112,7 +2112,7 @@
21122112
CAE2E5AA215D80380036FD32 /* OneSignalNotificationServiceExtensionHandler.m in Sources */,
21132113
4529DEDE1FA828E500CEAB1D /* NSDateOverrider.m in Sources */,
21142114
CA08FC871FE99BB4004C445F /* OneSignalClientOverrider.m in Sources */,
2115-
CACBAAA3218A6243000ACAA5 /* OSInAppMessage.m in Sources */,
2115+
CACBAAA3218A6243000ACAA5 /* OSInAppMessageInternal.m in Sources */,
21162116
7AF5174C24FE980400B076BC /* RemoteParamsTests.m in Sources */,
21172117
CACBAAA6218A6243000ACAA5 /* OSInAppMessageViewController.m in Sources */,
21182118
912412401E73342200E41FD7 /* UIApplicationDelegate+OneSignal.m in Sources */,

iOS_SDK/OneSignalSDK/Source/OSInAppMessageController.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,12 @@
2626
*/
2727

2828
#import <Foundation/Foundation.h>
29-
#import "OSInAppMessage.h"
29+
#import "OSInAppMessageInternal.h"
3030
#import "OneSignalClient.h"
3131

3232
NS_ASSUME_NONNULL_BEGIN
3333

34-
@interface OSInAppMessage (OSInAppMessageController)
34+
@interface OSInAppMessageInternal (OSInAppMessageController)
3535

3636
- (void)loadMessageHTMLContentWithResult:(OSResultSuccessBlock _Nullable)successBlock failure:(OSFailureBlock _Nullable)failureBlock;
3737
- (void)loadPreviewMessageHTMLContentWithUUID:(NSString * _Nonnull)previewUUID success:(OSResultSuccessBlock _Nullable)successBlock failure:(OSFailureBlock _Nullable)failureBlock;

iOS_SDK/OneSignalSDK/Source/OSInAppMessageController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
#import "OSInAppMessagingDefines.h"
3131

3232

33-
@implementation OSInAppMessage (OSInAppMessageController)
33+
@implementation OSInAppMessageInternal (OSInAppMessageController)
3434

3535
- (void)loadMessageHTMLContentWithResult:(OSResultSuccessBlock _Nullable)successBlock failure:(OSFailureBlock _Nullable)failureBlock {
3636
let variantId = [self variantId];

iOS_SDK/OneSignalSDK/Source/OSInAppMessage.h renamed to iOS_SDK/OneSignalSDK/Source/OSInAppMessageInternal.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434

3535
NS_ASSUME_NONNULL_BEGIN
3636

37-
@interface OSInAppMessage : NSObject <NSCoding, OSJSONDecodable, OSJSONEncodable>
37+
@interface OSInAppMessageInternal : NSObject <NSCoding, OSJSONDecodable, OSJSONEncodable>
3838

3939
@property (strong, nonatomic, nonnull) NSString *messageId;
4040
@property (strong, nonatomic, nonnull) NSDictionary<NSString *, NSDictionary <NSString *, NSString *> *> *variants;

iOS_SDK/OneSignalSDK/Source/OSInAppMessage.m renamed to iOS_SDK/OneSignalSDK/Source/OSInAppMessageInternal.m

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,18 +25,18 @@
2525
* THE SOFTWARE.
2626
*/
2727

28-
#import "OSInAppMessage.h"
28+
#import "OSInAppMessageInternal.h"
2929
#import "OneSignalHelper.h"
3030
#import "OneSignalCommonDefines.h"
3131

32-
@interface OSInAppMessage ()
32+
@interface OSInAppMessageInternal ()
3333

3434
@property (strong, nonatomic, nonnull) NSMutableSet <NSString *> *clickedClickIds;
3535
@property (strong, nonatomic, nonnull) NSMutableSet <NSString *> *viewedPageIds;
3636

3737
@end
3838

39-
@implementation OSInAppMessage
39+
@implementation OSInAppMessageInternal
4040

4141
- (instancetype)init {
4242
if (self = [super init]) {
@@ -87,7 +87,7 @@ + (instancetype)instanceWithData:(NSData *)data {
8787
}
8888

8989
+ (instancetype)instanceWithJson:(NSDictionary * _Nonnull)json {
90-
let message = [OSInAppMessage new];
90+
let message = [OSInAppMessageInternal new];
9191

9292
if (json[@"id"] && [json[@"id"] isKindOfClass:[NSString class]])
9393
message.messageId = json[@"id"];
@@ -144,7 +144,7 @@ + (instancetype)instanceWithJson:(NSDictionary * _Nonnull)json {
144144
}
145145

146146
+ (instancetype)instancePreviewFromNotification:(OSNotification *)notification {
147-
let message = [OSInAppMessage new];
147+
let message = [OSInAppMessageInternal new];
148148
message.messageId = [notification additionalData][ONESIGNAL_IAM_PREVIEW];
149149
message.isPreview = true;
150150
return message;
@@ -191,11 +191,11 @@ - (BOOL)isEqual:(id)object {
191191
return YES;
192192
}
193193

194-
if (![object isKindOfClass:[OSInAppMessage class]]) {
194+
if (![object isKindOfClass:[OSInAppMessageInternal class]]) {
195195
return NO;
196196
}
197197

198-
OSInAppMessage *iam = object;
198+
OSInAppMessageInternal *iam = object;
199199

200200
return [self.messageId isEqualToString:iam.messageId];
201201
}

iOS_SDK/OneSignalSDK/Source/OSInAppMessageView.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
*/
2727

2828
#import <UIKit/UIKit.h>
29-
#import "OSInAppMessage.h"
29+
#import "OSInAppMessageInternal.h"
3030
#import <WebKit/WebKit.h>
3131

3232
NS_ASSUME_NONNULL_BEGIN
@@ -42,7 +42,7 @@ NS_ASSUME_NONNULL_BEGIN
4242

4343
@property (weak, nonatomic, nullable) id<OSInAppMessageViewDelegate> delegate;
4444

45-
- (instancetype _Nonnull)initWithMessage:(OSInAppMessage *)inAppMessage withScriptMessageHandler:(id<WKScriptMessageHandler>)messageHandler;
45+
- (instancetype _Nonnull)initWithMessage:(OSInAppMessageInternal *)inAppMessage withScriptMessageHandler:(id<WKScriptMessageHandler>)messageHandler;
4646
- (void)resetWebViewToMaxBoundsAndResizeHeight:(void (^) (NSNumber *newHeight)) completion;
4747
- (void)setupWebViewConstraints;
4848
- (void)loadReplacementURL:(NSURL *)url;

iOS_SDK/OneSignalSDK/Source/OSInAppMessageView.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535

3636
@interface OSInAppMessageView () <UIScrollViewDelegate, WKUIDelegate, WKNavigationDelegate>
3737

38-
@property (strong, nonatomic, nonnull) OSInAppMessage *message;
38+
@property (strong, nonatomic, nonnull) OSInAppMessageInternal *message;
3939
@property (strong, nonatomic, nonnull) WKWebView *webView;
4040
@property (nonatomic) BOOL loaded;
4141

@@ -44,7 +44,7 @@ @interface OSInAppMessageView () <UIScrollViewDelegate, WKUIDelegate, WKNavigati
4444

4545
@implementation OSInAppMessageView
4646

47-
- (instancetype _Nonnull)initWithMessage:(OSInAppMessage *)inAppMessage withScriptMessageHandler:(id<WKScriptMessageHandler>)messageHandler {
47+
- (instancetype _Nonnull)initWithMessage:(OSInAppMessageInternal *)inAppMessage withScriptMessageHandler:(id<WKScriptMessageHandler>)messageHandler {
4848
if (self = [super init]) {
4949
self.message = inAppMessage;
5050
self.translatesAutoresizingMaskIntoConstraints = false;

iOS_SDK/OneSignalSDK/Source/OSInAppMessageViewController.h

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
#import <Foundation/Foundation.h>
2929
#import <UIKit/UIKit.h>
30-
#import "OSInAppMessage.h"
30+
#import "OSInAppMessageInternal.h"
3131
#import "OSInAppMessageView.h"
3232
#import "OSInAppMessageAction.h"
3333
#import <WebKit/WebKit.h>
@@ -36,22 +36,22 @@ NS_ASSUME_NONNULL_BEGIN
3636

3737
@protocol OSInAppMessageViewControllerDelegate <NSObject>
3838

39-
- (void)messageViewDidSelectAction:(OSInAppMessage *)message withAction:(OSInAppMessageAction *)action;
40-
- (void)messageViewDidDisplayPage:(OSInAppMessage *)message withPageId:(NSString *)pageId;
39+
- (void)messageViewDidSelectAction:(OSInAppMessageInternal *)message withAction:(OSInAppMessageAction *)action;
40+
- (void)messageViewDidDisplayPage:(OSInAppMessageInternal *)message withPageId:(NSString *)pageId;
4141
- (void)messageViewControllerWasDismissed;
42-
- (void)webViewContentFinishedLoading:(OSInAppMessage *)message;
43-
- (void)messageIsNotActive:(OSInAppMessage *)message;
42+
- (void)webViewContentFinishedLoading:(OSInAppMessageInternal *)message;
43+
- (void)messageIsNotActive:(OSInAppMessageInternal *)message;
4444

4545
@end
4646

4747

4848
@interface OSInAppMessageViewController : UIViewController <OSInAppMessageViewDelegate, WKScriptMessageHandler>
4949

5050
@property (weak, nonatomic, nullable) id<OSInAppMessageViewControllerDelegate> delegate;
51-
@property (strong, nonatomic, nonnull) OSInAppMessage *message;
51+
@property (strong, nonatomic, nonnull) OSInAppMessageInternal *message;
5252
@property (nonatomic) BOOL waitForTags;
5353

54-
- (instancetype _Nonnull)initWithMessage:(OSInAppMessage *)inAppMessage delegate:(id<OSInAppMessageViewControllerDelegate>)delegate;
54+
- (instancetype _Nonnull)initWithMessage:(OSInAppMessageInternal *)inAppMessage delegate:(id<OSInAppMessageViewControllerDelegate>)delegate;
5555
- (void)dismissCurrentInAppMessage;
5656

5757
@end

iOS_SDK/OneSignalSDK/Source/OSInAppMessageViewController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ @interface OSInAppMessageViewController ()
9797

9898
@implementation OSInAppMessageViewController
9999

100-
- (instancetype _Nonnull)initWithMessage:(OSInAppMessage *)inAppMessage delegate:(id<OSInAppMessageViewControllerDelegate>)delegate {
100+
- (instancetype _Nonnull)initWithMessage:(OSInAppMessageInternal *)inAppMessage delegate:(id<OSInAppMessageViewControllerDelegate>)delegate {
101101
if (self = [super init]) {
102102
self.message = inAppMessage;
103103
self.delegate = delegate;

iOS_SDK/OneSignalSDK/Source/OSMessagingController.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
*/
2727

2828
#import <Foundation/Foundation.h>
29-
#import "OSInAppMessage.h"
29+
#import "OSInAppMessageInternal.h"
3030
#import "OSInAppMessageViewController.h"
3131
#import "OneSignal.h"
3232
#import "OSTriggerController.h"
@@ -49,12 +49,12 @@ NS_ASSUME_NONNULL_BEGIN
4949

5050
+ (OSMessagingController *)sharedInstance;
5151
+ (void)removeInstance;
52-
- (void)presentInAppMessage:(OSInAppMessage *)message;
53-
- (void)presentInAppPreviewMessage:(OSInAppMessage *)message;
52+
- (void)presentInAppMessage:(OSInAppMessageInternal *)message;
53+
- (void)presentInAppPreviewMessage:(OSInAppMessageInternal *)message;
5454
- (void)updateInAppMessagesFromCache;
55-
- (void)updateInAppMessagesFromOnSession:(NSArray<OSInAppMessage *> *)newMessages;
56-
- (void)messageViewImpressionRequest:(OSInAppMessage *)message;
57-
- (void)messageViewPageImpressionRequest:(OSInAppMessage *)message withPageId:(NSString *)pageId;
55+
- (void)updateInAppMessagesFromOnSession:(NSArray<OSInAppMessageInternal *> *)newMessages;
56+
- (void)messageViewImpressionRequest:(OSInAppMessageInternal *)message;
57+
- (void)messageViewPageImpressionRequest:(OSInAppMessageInternal *)message withPageId:(NSString *)pageId;
5858

5959
- (BOOL)isInAppMessagingPaused;
6060
- (void)setInAppMessagingPaused:(BOOL)pause;

0 commit comments

Comments
 (0)