Skip to content

Commit 67f35f9

Browse files
emawbyemawby
committed
addressing warnings exposed from modularization
1 parent fedb611 commit 67f35f9

File tree

15 files changed

+62
-33
lines changed

15 files changed

+62
-33
lines changed

‎iOS_SDK/OneSignalDevApp/OneSignalExample.xcodeproj/project.pbxproj‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -714,6 +714,7 @@
714714
9150E77B1E73BEDD00C5D46A /* Debug */ = {
715715
isa = XCBuildConfiguration;
716716
buildSettings = {
717+
CLANG_WARN_STRICT_PROTOTYPES = NO;
717718
CODE_SIGN_ENTITLEMENTS = OneSignalNotificationServiceExtension/OneSignalNotificationServiceExtension.entitlements;
718719
CURRENT_PROJECT_VERSION = 1.4.4;
719720
DERIVE_MACCATALYST_PRODUCT_BUNDLE_IDENTIFIER = YES;
@@ -740,6 +741,7 @@
740741
9150E77C1E73BEDD00C5D46A /* Release */ = {
741742
isa = XCBuildConfiguration;
742743
buildSettings = {
744+
CLANG_WARN_STRICT_PROTOTYPES = NO;
743745
CODE_SIGN_ENTITLEMENTS = OneSignalNotificationServiceExtension/OneSignalNotificationServiceExtension.entitlements;
744746
CURRENT_PROJECT_VERSION = 1.4.4;
745747
DERIVE_MACCATALYST_PRODUCT_BUNDLE_IDENTIFIER = YES;
@@ -778,7 +780,7 @@
778780
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
779781
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
780782
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
781-
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
783+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = NO;
782784
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
783785
CLANG_WARN_STRICT_PROTOTYPES = YES;
784786
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
@@ -822,7 +824,7 @@
822824
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
823825
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
824826
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
825-
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
827+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = NO;
826828
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
827829
CLANG_WARN_STRICT_PROTOTYPES = YES;
828830
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;

‎iOS_SDK/OneSignalSDK/OneSignal.xcodeproj/project.pbxproj‎

Lines changed: 36 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -2712,6 +2712,7 @@
27122712
DYLIB_COMPATIBILITY_VERSION = 1;
27132713
DYLIB_CURRENT_VERSION = 1;
27142714
DYLIB_INSTALL_NAME_BASE = "@rpath";
2715+
GCC_WARN_64_TO_32_BIT_CONVERSION = NO;
27152716
INFOPLIST_FILE = OneSignalFramework/Info.plist;
27162717
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
27172718
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
@@ -2726,6 +2727,7 @@
27262727
TARGETED_DEVICE_FAMILY = "1,2";
27272728
VERSIONING_SYSTEM = "apple-generic";
27282729
VERSION_INFO_PREFIX = "";
2730+
WARNING_CFLAGS = "-Wno-nullability-completeness";
27292731
};
27302732
name = Release;
27312733
};
@@ -2868,6 +2870,7 @@
28682870
DYLIB_COMPATIBILITY_VERSION = 1;
28692871
DYLIB_CURRENT_VERSION = 1;
28702872
DYLIB_INSTALL_NAME_BASE = "@rpath";
2873+
GCC_WARN_64_TO_32_BIT_CONVERSION = NO;
28712874
INFOPLIST_FILE = OneSignalFramework/Info.plist;
28722875
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
28732876
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
@@ -2883,6 +2886,7 @@
28832886
TARGETED_DEVICE_FAMILY = "1,2";
28842887
VERSIONING_SYSTEM = "apple-generic";
28852888
VERSION_INFO_PREFIX = "";
2889+
WARNING_CFLAGS = "-Wno-nullability-completeness";
28862890
};
28872891
name = Debug;
28882892
};
@@ -2950,16 +2954,17 @@
29502954
CLANG_ENABLE_MODULES = YES;
29512955
CLANG_ENABLE_OBJC_WEAK = YES;
29522956
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
2957+
CLANG_WARN_BOOL_CONVERSION = NO;
29532958
CLANG_WARN_COMMA = YES;
29542959
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
2955-
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
2960+
CLANG_WARN_DOCUMENTATION_COMMENTS = NO;
29562961
CLANG_WARN_INFINITE_RECURSION = YES;
29572962
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
29582963
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
29592964
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
2960-
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
2965+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = NO;
29612966
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
2962-
CLANG_WARN_STRICT_PROTOTYPES = YES;
2967+
CLANG_WARN_STRICT_PROTOTYPES = NO;
29632968
CLANG_WARN_SUSPICIOUS_MOVE = YES;
29642969
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
29652970
CODE_SIGN_STYLE = Automatic;
@@ -2981,13 +2986,15 @@
29812986
MTL_ENABLE_DEBUG_INFO = NO;
29822987
MTL_FAST_MATH = YES;
29832988
ONLY_ACTIVE_ARCH = NO;
2989+
OTHER_CFLAGS = "-fembed-bitcode";
29842990
PRODUCT_BUNDLE_IDENTIFIER = com.onesignal.OneSignalCore;
29852991
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
29862992
SKIP_INSTALL = YES;
29872993
SWIFT_EMIT_LOC_STRINGS = YES;
29882994
TARGETED_DEVICE_FAMILY = "1,2";
29892995
VERSIONING_SYSTEM = "apple-generic";
29902996
VERSION_INFO_PREFIX = "";
2997+
WARNING_CFLAGS = "-Wno-nullability-completeness";
29912998
};
29922999
name = Release;
29933000
};
@@ -3001,16 +3008,17 @@
30013008
CLANG_ENABLE_MODULES = YES;
30023009
CLANG_ENABLE_OBJC_WEAK = YES;
30033010
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
3011+
CLANG_WARN_BOOL_CONVERSION = NO;
30043012
CLANG_WARN_COMMA = YES;
30053013
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
3006-
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
3014+
CLANG_WARN_DOCUMENTATION_COMMENTS = NO;
30073015
CLANG_WARN_INFINITE_RECURSION = YES;
30083016
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
30093017
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
30103018
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
3011-
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
3019+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = NO;
30123020
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
3013-
CLANG_WARN_STRICT_PROTOTYPES = YES;
3021+
CLANG_WARN_STRICT_PROTOTYPES = NO;
30143022
CLANG_WARN_SUSPICIOUS_MOVE = YES;
30153023
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
30163024
CODE_SIGN_STYLE = Automatic;
@@ -3038,13 +3046,15 @@
30383046
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
30393047
MTL_FAST_MATH = YES;
30403048
ONLY_ACTIVE_ARCH = NO;
3049+
OTHER_CFLAGS = "-fembed-bitcode";
30413050
PRODUCT_BUNDLE_IDENTIFIER = com.onesignal.OneSignalCore;
30423051
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
30433052
SKIP_INSTALL = YES;
30443053
SWIFT_EMIT_LOC_STRINGS = YES;
30453054
TARGETED_DEVICE_FAMILY = "1,2";
30463055
VERSIONING_SYSTEM = "apple-generic";
30473056
VERSION_INFO_PREFIX = "";
3057+
WARNING_CFLAGS = "-Wno-nullability-completeness";
30483058
};
30493059
name = Debug;
30503060
};
@@ -3060,14 +3070,14 @@
30603070
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
30613071
CLANG_WARN_COMMA = YES;
30623072
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
3063-
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
3073+
CLANG_WARN_DOCUMENTATION_COMMENTS = NO;
30643074
CLANG_WARN_INFINITE_RECURSION = YES;
30653075
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
30663076
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
30673077
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
3068-
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
3078+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = NO;
30693079
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
3070-
CLANG_WARN_STRICT_PROTOTYPES = YES;
3080+
CLANG_WARN_STRICT_PROTOTYPES = NO;
30713081
CLANG_WARN_SUSPICIOUS_MOVE = YES;
30723082
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
30733083
CODE_SIGN_STYLE = Automatic;
@@ -3089,13 +3099,15 @@
30893099
MTL_ENABLE_DEBUG_INFO = NO;
30903100
MTL_FAST_MATH = YES;
30913101
ONLY_ACTIVE_ARCH = NO;
3102+
OTHER_CFLAGS = "-fembed-bitcode";
30923103
PRODUCT_BUNDLE_IDENTIFIER = com.onesignal.OneSignalExtension;
30933104
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
30943105
SKIP_INSTALL = YES;
30953106
SWIFT_EMIT_LOC_STRINGS = YES;
30963107
TARGETED_DEVICE_FAMILY = "1,2";
30973108
VERSIONING_SYSTEM = "apple-generic";
30983109
VERSION_INFO_PREFIX = "";
3110+
WARNING_CFLAGS = "-Wno-nullability-completeness";
30993111
};
31003112
name = Release;
31013113
};
@@ -3111,14 +3123,14 @@
31113123
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
31123124
CLANG_WARN_COMMA = YES;
31133125
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
3114-
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
3126+
CLANG_WARN_DOCUMENTATION_COMMENTS = NO;
31153127
CLANG_WARN_INFINITE_RECURSION = YES;
31163128
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
31173129
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
31183130
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
3119-
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
3131+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = NO;
31203132
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
3121-
CLANG_WARN_STRICT_PROTOTYPES = YES;
3133+
CLANG_WARN_STRICT_PROTOTYPES = NO;
31223134
CLANG_WARN_SUSPICIOUS_MOVE = YES;
31233135
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
31243136
CODE_SIGN_STYLE = Automatic;
@@ -3146,13 +3158,15 @@
31463158
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
31473159
MTL_FAST_MATH = YES;
31483160
ONLY_ACTIVE_ARCH = NO;
3161+
OTHER_CFLAGS = "-fembed-bitcode";
31493162
PRODUCT_BUNDLE_IDENTIFIER = com.onesignal.OneSignalExtension;
31503163
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
31513164
SKIP_INSTALL = YES;
31523165
SWIFT_EMIT_LOC_STRINGS = YES;
31533166
TARGETED_DEVICE_FAMILY = "1,2";
31543167
VERSIONING_SYSTEM = "apple-generic";
31553168
VERSION_INFO_PREFIX = "";
3169+
WARNING_CFLAGS = "-Wno-nullability-completeness";
31563170
};
31573171
name = Debug;
31583172
};
@@ -3168,14 +3182,14 @@
31683182
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
31693183
CLANG_WARN_COMMA = YES;
31703184
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
3171-
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
3185+
CLANG_WARN_DOCUMENTATION_COMMENTS = NO;
31723186
CLANG_WARN_INFINITE_RECURSION = YES;
31733187
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
31743188
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
31753189
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
3176-
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
3190+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = NO;
31773191
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
3178-
CLANG_WARN_STRICT_PROTOTYPES = YES;
3192+
CLANG_WARN_STRICT_PROTOTYPES = NO;
31793193
CLANG_WARN_SUSPICIOUS_MOVE = YES;
31803194
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
31813195
CODE_SIGN_STYLE = Automatic;
@@ -3197,13 +3211,15 @@
31973211
MTL_ENABLE_DEBUG_INFO = NO;
31983212
MTL_FAST_MATH = YES;
31993213
ONLY_ACTIVE_ARCH = NO;
3214+
OTHER_CFLAGS = "-fembed-bitcode";
32003215
PRODUCT_BUNDLE_IDENTIFIER = com.onesignal.OneSignalOutcomes;
32013216
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
32023217
SKIP_INSTALL = YES;
32033218
SWIFT_EMIT_LOC_STRINGS = YES;
32043219
TARGETED_DEVICE_FAMILY = "1,2";
32053220
VERSIONING_SYSTEM = "apple-generic";
32063221
VERSION_INFO_PREFIX = "";
3222+
WARNING_CFLAGS = "-Wno-nullability-completeness";
32073223
};
32083224
name = Release;
32093225
};
@@ -3219,14 +3235,14 @@
32193235
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
32203236
CLANG_WARN_COMMA = YES;
32213237
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
3222-
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
3238+
CLANG_WARN_DOCUMENTATION_COMMENTS = NO;
32233239
CLANG_WARN_INFINITE_RECURSION = YES;
32243240
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
32253241
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
32263242
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
3227-
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
3243+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = NO;
32283244
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
3229-
CLANG_WARN_STRICT_PROTOTYPES = YES;
3245+
CLANG_WARN_STRICT_PROTOTYPES = NO;
32303246
CLANG_WARN_SUSPICIOUS_MOVE = YES;
32313247
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
32323248
CODE_SIGN_STYLE = Automatic;
@@ -3254,13 +3270,15 @@
32543270
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
32553271
MTL_FAST_MATH = YES;
32563272
ONLY_ACTIVE_ARCH = NO;
3273+
OTHER_CFLAGS = "-fembed-bitcode";
32573274
PRODUCT_BUNDLE_IDENTIFIER = com.onesignal.OneSignalOutcomes;
32583275
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
32593276
SKIP_INSTALL = YES;
32603277
SWIFT_EMIT_LOC_STRINGS = YES;
32613278
TARGETED_DEVICE_FAMILY = "1,2";
32623279
VERSIONING_SYSTEM = "apple-generic";
32633280
VERSION_INFO_PREFIX = "";
3281+
WARNING_CFLAGS = "-Wno-nullability-completeness";
32643282
};
32653283
name = Debug;
32663284
};

‎iOS_SDK/OneSignalSDK/OneSignalCore/Source/API/OneSignalRequest.h‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
2525
* THE SOFTWARE.
2626
*/
27+
#pragma clang diagnostic ignored "-Wnullability-completeness"
28+
#pragma clang diagnostic ignored "-Wnullability-completeness"
2729

2830
#import <Foundation/Foundation.h>
2931
#import "OneSignalCommonDefines.h"

‎iOS_SDK/OneSignalSDK/OneSignalCore/Source/OSNotification+Internal.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
+(instancetype _Nonnull )parseWithApns:(nonnull NSDictionary *)message;
3535
- (void)setCompletionBlock:(OSNotificationDisplayResponse _Nonnull)completion;
3636
- (void)startTimeoutTimer;
37-
- (void)complete:(OSNotification *)notification;
37+
- (void)complete:(nullable OSNotification *)notification;
3838
@end
3939

4040
#endif /* OSNotification_Internal_h */

‎iOS_SDK/OneSignalSDK/OneSignalCore/Source/OSNotification.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,14 +94,14 @@
9494
@property(readonly, nullable)NSNumber *relevanceScore;
9595

9696
/* iOS 15+ : Interruption Level */
97-
@property(readonly)NSString *interruptionLevel;
97+
@property(readonly, nullable)NSString *interruptionLevel;
9898

9999
@property(readonly, nullable)NSString *collapseId;
100100

101101
/* Parses an APNS push payload into a OSNotification object.
102102
Useful to call from your NotificationServiceExtension when the
103103
didReceiveNotificationRequest:withContentHandler: method fires. */
104-
+ (instancetype)parseWithApns:(nonnull NSDictionary*)message;
104+
+ (instancetype _Nullable)parseWithApns:(nonnull NSDictionary*)message;
105105

106106
/* Convert object into a custom Dictionary / JSON Object */
107107
- (NSDictionary* _Nonnull)jsonRepresentation;

‎iOS_SDK/OneSignalSDK/OneSignalCore/Source/OSNotification.m‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,10 +198,10 @@ - (void)parseActionButtons:(NSArray<NSDictionary*>*)buttons {
198198
- (void)parseOtherApnsFields {
199199
NSDictionary *aps = _rawPayload[@"aps"];
200200
if (aps[@"content-available"])
201-
_contentAvailable = (BOOL)aps[@"content-available"];
201+
_contentAvailable = [aps[@"content-available"] boolValue];
202202

203203
if (aps[@"mutable-content"])
204-
_mutableContent = (BOOL)aps[@"mutable-content"];
204+
_mutableContent = [aps[@"mutable-content"] boolValue];
205205

206206
if (aps[@"thread-id"]) {
207207
_threadId = (NSString *)aps[@"thread-id"];

‎iOS_SDK/OneSignalSDK/OneSignalCore/Source/OneSignalCore.h‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
2525
* THE SOFTWARE.
2626
*/
27+
28+
#pragma clang diagnostic ignored "-Wnullability-completeness"
2729
#import <Foundation/Foundation.h>
2830
#import "OneSignalUserDefaults.h"
2931
#import "OneSignalCommonDefines.h"

‎iOS_SDK/OneSignalSDK/OneSignalCore/Source/OneSignalCoreHelper.h‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@
2626
*/
2727

2828
@interface OneSignalCoreHelper : NSObject
29+
#pragma clang diagnostic ignored "-Wstrict-prototypes"
30+
#pragma clang diagnostic ignored "-Wnullability-completeness"
31+
2932
// Threading
3033
+ (void)runOnMainThread:(void(^)())block;
3134
+ (void)dispatch_async_on_main_queue:(void(^)())block;

‎iOS_SDK/OneSignalSDK/OneSignalCore/Source/OneSignalTrackFirebaseAnalytics.m‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ + (void)init {
5252

5353

5454
+ (void)updateFromDownloadParams:(NSDictionary*)params {
55-
trackingEnabled = (BOOL)params[@"fba"];
55+
trackingEnabled = [params[@"fba"] boolValue];
5656
OneSignalUserDefaults *sharedUserDefaults = OneSignalUserDefaults.initShared;
5757
if (trackingEnabled)
5858
[sharedUserDefaults saveBoolForKey:ONESIGNAL_FB_ENABLE_FIREBASE withValue:YES];

‎iOS_SDK/OneSignalSDK/OneSignalExtension/OneSignalAttachmentHandler.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
#import <UserNotifications/UserNotifications.h>
3030

3131
@interface OneSignalAttachmentHandler : NSObject
32+
3233
+ (void)addAttachments:(OSNotification*)notification toNotificationContent:(UNMutableNotificationContent*)content;
3334
+ (void)addActionButtons:(OSNotification*)notification toNotificationContent:(UNMutableNotificationContent*)content;
3435
+ (UNNotificationAction *)createActionForButton:(NSDictionary *)button;

0 commit comments

Comments
 (0)