Skip to content

Commit 694c2ff

Browse files
emawbyemawby
committed
addressing warnings exposed from modularization
1 parent a6049eb commit 694c2ff

File tree

15 files changed

+62
-33
lines changed

15 files changed

+62
-33
lines changed

‎iOS_SDK/OneSignalDevApp/OneSignalExample.xcodeproj/project.pbxproj‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -714,6 +714,7 @@
714714
9150E77B1E73BEDD00C5D46A /* Debug */ = {
715715
isa = XCBuildConfiguration;
716716
buildSettings = {
717+
CLANG_WARN_STRICT_PROTOTYPES = NO;
717718
CODE_SIGN_ENTITLEMENTS = OneSignalNotificationServiceExtension/OneSignalNotificationServiceExtension.entitlements;
718719
CURRENT_PROJECT_VERSION = 1.4.4;
719720
DERIVE_MACCATALYST_PRODUCT_BUNDLE_IDENTIFIER = YES;
@@ -740,6 +741,7 @@
740741
9150E77C1E73BEDD00C5D46A /* Release */ = {
741742
isa = XCBuildConfiguration;
742743
buildSettings = {
744+
CLANG_WARN_STRICT_PROTOTYPES = NO;
743745
CODE_SIGN_ENTITLEMENTS = OneSignalNotificationServiceExtension/OneSignalNotificationServiceExtension.entitlements;
744746
CURRENT_PROJECT_VERSION = 1.4.4;
745747
DERIVE_MACCATALYST_PRODUCT_BUNDLE_IDENTIFIER = YES;
@@ -778,7 +780,7 @@
778780
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
779781
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
780782
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
781-
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
783+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = NO;
782784
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
783785
CLANG_WARN_STRICT_PROTOTYPES = YES;
784786
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
@@ -822,7 +824,7 @@
822824
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
823825
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
824826
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
825-
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
827+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = NO;
826828
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
827829
CLANG_WARN_STRICT_PROTOTYPES = YES;
828830
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;

‎iOS_SDK/OneSignalSDK/OneSignal.xcodeproj/project.pbxproj‎

Lines changed: 36 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -2712,6 +2712,7 @@
27122712
DYLIB_COMPATIBILITY_VERSION = 1;
27132713
DYLIB_CURRENT_VERSION = 1;
27142714
DYLIB_INSTALL_NAME_BASE = "@rpath";
2715+
GCC_WARN_64_TO_32_BIT_CONVERSION = NO;
27152716
INFOPLIST_FILE = OneSignalFramework/Info.plist;
27162717
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
27172718
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
@@ -2726,6 +2727,7 @@
27262727
TARGETED_DEVICE_FAMILY = "1,2";
27272728
VERSIONING_SYSTEM = "apple-generic";
27282729
VERSION_INFO_PREFIX = "";
2730+
WARNING_CFLAGS = "-Wno-nullability-completeness";
27292731
};
27302732
name = Release;
27312733
};
@@ -2867,6 +2869,7 @@
28672869
DYLIB_COMPATIBILITY_VERSION = 1;
28682870
DYLIB_CURRENT_VERSION = 1;
28692871
DYLIB_INSTALL_NAME_BASE = "@rpath";
2872+
GCC_WARN_64_TO_32_BIT_CONVERSION = NO;
28702873
INFOPLIST_FILE = OneSignalFramework/Info.plist;
28712874
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
28722875
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
@@ -2882,6 +2885,7 @@
28822885
TARGETED_DEVICE_FAMILY = "1,2";
28832886
VERSIONING_SYSTEM = "apple-generic";
28842887
VERSION_INFO_PREFIX = "";
2888+
WARNING_CFLAGS = "-Wno-nullability-completeness";
28852889
};
28862890
name = Debug;
28872891
};
@@ -2948,16 +2952,17 @@
29482952
CLANG_ENABLE_MODULES = YES;
29492953
CLANG_ENABLE_OBJC_WEAK = YES;
29502954
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
2955+
CLANG_WARN_BOOL_CONVERSION = NO;
29512956
CLANG_WARN_COMMA = YES;
29522957
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
2953-
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
2958+
CLANG_WARN_DOCUMENTATION_COMMENTS = NO;
29542959
CLANG_WARN_INFINITE_RECURSION = YES;
29552960
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
29562961
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
29572962
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
2958-
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
2963+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = NO;
29592964
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
2960-
CLANG_WARN_STRICT_PROTOTYPES = YES;
2965+
CLANG_WARN_STRICT_PROTOTYPES = NO;
29612966
CLANG_WARN_SUSPICIOUS_MOVE = YES;
29622967
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
29632968
CODE_SIGN_STYLE = Automatic;
@@ -2979,13 +2984,15 @@
29792984
MTL_ENABLE_DEBUG_INFO = NO;
29802985
MTL_FAST_MATH = YES;
29812986
ONLY_ACTIVE_ARCH = NO;
2987+
OTHER_CFLAGS = "-fembed-bitcode";
29822988
PRODUCT_BUNDLE_IDENTIFIER = com.onesignal.OneSignalCore;
29832989
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
29842990
SKIP_INSTALL = YES;
29852991
SWIFT_EMIT_LOC_STRINGS = YES;
29862992
TARGETED_DEVICE_FAMILY = "1,2";
29872993
VERSIONING_SYSTEM = "apple-generic";
29882994
VERSION_INFO_PREFIX = "";
2995+
WARNING_CFLAGS = "-Wno-nullability-completeness";
29892996
};
29902997
name = Release;
29912998
};
@@ -2999,16 +3006,17 @@
29993006
CLANG_ENABLE_MODULES = YES;
30003007
CLANG_ENABLE_OBJC_WEAK = YES;
30013008
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
3009+
CLANG_WARN_BOOL_CONVERSION = NO;
30023010
CLANG_WARN_COMMA = YES;
30033011
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
3004-
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
3012+
CLANG_WARN_DOCUMENTATION_COMMENTS = NO;
30053013
CLANG_WARN_INFINITE_RECURSION = YES;
30063014
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
30073015
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
30083016
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
3009-
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
3017+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = NO;
30103018
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
3011-
CLANG_WARN_STRICT_PROTOTYPES = YES;
3019+
CLANG_WARN_STRICT_PROTOTYPES = NO;
30123020
CLANG_WARN_SUSPICIOUS_MOVE = YES;
30133021
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
30143022
CODE_SIGN_STYLE = Automatic;
@@ -3036,13 +3044,15 @@
30363044
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
30373045
MTL_FAST_MATH = YES;
30383046
ONLY_ACTIVE_ARCH = NO;
3047+
OTHER_CFLAGS = "-fembed-bitcode";
30393048
PRODUCT_BUNDLE_IDENTIFIER = com.onesignal.OneSignalCore;
30403049
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
30413050
SKIP_INSTALL = YES;
30423051
SWIFT_EMIT_LOC_STRINGS = YES;
30433052
TARGETED_DEVICE_FAMILY = "1,2";
30443053
VERSIONING_SYSTEM = "apple-generic";
30453054
VERSION_INFO_PREFIX = "";
3055+
WARNING_CFLAGS = "-Wno-nullability-completeness";
30463056
};
30473057
name = Debug;
30483058
};
@@ -3058,14 +3068,14 @@
30583068
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
30593069
CLANG_WARN_COMMA = YES;
30603070
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
3061-
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
3071+
CLANG_WARN_DOCUMENTATION_COMMENTS = NO;
30623072
CLANG_WARN_INFINITE_RECURSION = YES;
30633073
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
30643074
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
30653075
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
3066-
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
3076+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = NO;
30673077
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
3068-
CLANG_WARN_STRICT_PROTOTYPES = YES;
3078+
CLANG_WARN_STRICT_PROTOTYPES = NO;
30693079
CLANG_WARN_SUSPICIOUS_MOVE = YES;
30703080
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
30713081
CODE_SIGN_STYLE = Automatic;
@@ -3087,13 +3097,15 @@
30873097
MTL_ENABLE_DEBUG_INFO = NO;
30883098
MTL_FAST_MATH = YES;
30893099
ONLY_ACTIVE_ARCH = NO;
3100+
OTHER_CFLAGS = "-fembed-bitcode";
30903101
PRODUCT_BUNDLE_IDENTIFIER = com.onesignal.OneSignalExtension;
30913102
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
30923103
SKIP_INSTALL = YES;
30933104
SWIFT_EMIT_LOC_STRINGS = YES;
30943105
TARGETED_DEVICE_FAMILY = "1,2";
30953106
VERSIONING_SYSTEM = "apple-generic";
30963107
VERSION_INFO_PREFIX = "";
3108+
WARNING_CFLAGS = "-Wno-nullability-completeness";
30973109
};
30983110
name = Release;
30993111
};
@@ -3109,14 +3121,14 @@
31093121
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
31103122
CLANG_WARN_COMMA = YES;
31113123
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
3112-
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
3124+
CLANG_WARN_DOCUMENTATION_COMMENTS = NO;
31133125
CLANG_WARN_INFINITE_RECURSION = YES;
31143126
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
31153127
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
31163128
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
3117-
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
3129+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = NO;
31183130
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
3119-
CLANG_WARN_STRICT_PROTOTYPES = YES;
3131+
CLANG_WARN_STRICT_PROTOTYPES = NO;
31203132
CLANG_WARN_SUSPICIOUS_MOVE = YES;
31213133
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
31223134
CODE_SIGN_STYLE = Automatic;
@@ -3144,13 +3156,15 @@
31443156
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
31453157
MTL_FAST_MATH = YES;
31463158
ONLY_ACTIVE_ARCH = NO;
3159+
OTHER_CFLAGS = "-fembed-bitcode";
31473160
PRODUCT_BUNDLE_IDENTIFIER = com.onesignal.OneSignalExtension;
31483161
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
31493162
SKIP_INSTALL = YES;
31503163
SWIFT_EMIT_LOC_STRINGS = YES;
31513164
TARGETED_DEVICE_FAMILY = "1,2";
31523165
VERSIONING_SYSTEM = "apple-generic";
31533166
VERSION_INFO_PREFIX = "";
3167+
WARNING_CFLAGS = "-Wno-nullability-completeness";
31543168
};
31553169
name = Debug;
31563170
};
@@ -3166,14 +3180,14 @@
31663180
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
31673181
CLANG_WARN_COMMA = YES;
31683182
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
3169-
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
3183+
CLANG_WARN_DOCUMENTATION_COMMENTS = NO;
31703184
CLANG_WARN_INFINITE_RECURSION = YES;
31713185
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
31723186
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
31733187
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
3174-
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
3188+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = NO;
31753189
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
3176-
CLANG_WARN_STRICT_PROTOTYPES = YES;
3190+
CLANG_WARN_STRICT_PROTOTYPES = NO;
31773191
CLANG_WARN_SUSPICIOUS_MOVE = YES;
31783192
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
31793193
CODE_SIGN_STYLE = Automatic;
@@ -3195,13 +3209,15 @@
31953209
MTL_ENABLE_DEBUG_INFO = NO;
31963210
MTL_FAST_MATH = YES;
31973211
ONLY_ACTIVE_ARCH = NO;
3212+
OTHER_CFLAGS = "-fembed-bitcode";
31983213
PRODUCT_BUNDLE_IDENTIFIER = com.onesignal.OneSignalOutcomes;
31993214
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
32003215
SKIP_INSTALL = YES;
32013216
SWIFT_EMIT_LOC_STRINGS = YES;
32023217
TARGETED_DEVICE_FAMILY = "1,2";
32033218
VERSIONING_SYSTEM = "apple-generic";
32043219
VERSION_INFO_PREFIX = "";
3220+
WARNING_CFLAGS = "-Wno-nullability-completeness";
32053221
};
32063222
name = Release;
32073223
};
@@ -3217,14 +3233,14 @@
32173233
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
32183234
CLANG_WARN_COMMA = YES;
32193235
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
3220-
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
3236+
CLANG_WARN_DOCUMENTATION_COMMENTS = NO;
32213237
CLANG_WARN_INFINITE_RECURSION = YES;
32223238
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
32233239
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
32243240
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
3225-
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
3241+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = NO;
32263242
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
3227-
CLANG_WARN_STRICT_PROTOTYPES = YES;
3243+
CLANG_WARN_STRICT_PROTOTYPES = NO;
32283244
CLANG_WARN_SUSPICIOUS_MOVE = YES;
32293245
CLANG_WARN_UNGUARDED_AVAILABILITY = YES_AGGRESSIVE;
32303246
CODE_SIGN_STYLE = Automatic;
@@ -3252,13 +3268,15 @@
32523268
MTL_ENABLE_DEBUG_INFO = INCLUDE_SOURCE;
32533269
MTL_FAST_MATH = YES;
32543270
ONLY_ACTIVE_ARCH = NO;
3271+
OTHER_CFLAGS = "-fembed-bitcode";
32553272
PRODUCT_BUNDLE_IDENTIFIER = com.onesignal.OneSignalOutcomes;
32563273
PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
32573274
SKIP_INSTALL = YES;
32583275
SWIFT_EMIT_LOC_STRINGS = YES;
32593276
TARGETED_DEVICE_FAMILY = "1,2";
32603277
VERSIONING_SYSTEM = "apple-generic";
32613278
VERSION_INFO_PREFIX = "";
3279+
WARNING_CFLAGS = "-Wno-nullability-completeness";
32623280
};
32633281
name = Debug;
32643282
};

‎iOS_SDK/OneSignalSDK/OneSignalCore/Source/API/OneSignalRequest.h‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
2525
* THE SOFTWARE.
2626
*/
27+
#pragma clang diagnostic ignored "-Wnullability-completeness"
28+
#pragma clang diagnostic ignored "-Wnullability-completeness"
2729

2830
#import <Foundation/Foundation.h>
2931
#import "OneSignalCommonDefines.h"

‎iOS_SDK/OneSignalSDK/OneSignalCore/Source/OSNotification+Internal.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
+(instancetype _Nonnull )parseWithApns:(nonnull NSDictionary *)message;
3535
- (void)setCompletionBlock:(OSNotificationDisplayResponse _Nonnull)completion;
3636
- (void)startTimeoutTimer;
37-
- (void)complete:(OSNotification *)notification;
37+
- (void)complete:(nullable OSNotification *)notification;
3838
@end
3939

4040
#endif /* OSNotification_Internal_h */

‎iOS_SDK/OneSignalSDK/OneSignalCore/Source/OSNotification.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,14 +94,14 @@
9494
@property(readonly, nullable)NSNumber *relevanceScore;
9595

9696
/* iOS 15+ : Interruption Level */
97-
@property(readonly)NSString *interruptionLevel;
97+
@property(readonly, nullable)NSString *interruptionLevel;
9898

9999
@property(readonly, nullable)NSString *collapseId;
100100

101101
/* Parses an APNS push payload into a OSNotification object.
102102
Useful to call from your NotificationServiceExtension when the
103103
didReceiveNotificationRequest:withContentHandler: method fires. */
104-
+ (instancetype)parseWithApns:(nonnull NSDictionary*)message;
104+
+ (instancetype _Nullable)parseWithApns:(nonnull NSDictionary*)message;
105105

106106
/* Convert object into a custom Dictionary / JSON Object */
107107
- (NSDictionary* _Nonnull)jsonRepresentation;

‎iOS_SDK/OneSignalSDK/OneSignalCore/Source/OSNotification.m‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,10 +198,10 @@ - (void)parseActionButtons:(NSArray<NSDictionary*>*)buttons {
198198
- (void)parseOtherApnsFields {
199199
NSDictionary *aps = _rawPayload[@"aps"];
200200
if (aps[@"content-available"])
201-
_contentAvailable = (BOOL)aps[@"content-available"];
201+
_contentAvailable = [aps[@"content-available"] boolValue];
202202

203203
if (aps[@"mutable-content"])
204-
_mutableContent = (BOOL)aps[@"mutable-content"];
204+
_mutableContent = [aps[@"mutable-content"] boolValue];
205205

206206
if (aps[@"thread-id"]) {
207207
_threadId = (NSString *)aps[@"thread-id"];

‎iOS_SDK/OneSignalSDK/OneSignalCore/Source/OneSignalCore.h‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@
2424
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
2525
* THE SOFTWARE.
2626
*/
27+
28+
#pragma clang diagnostic ignored "-Wnullability-completeness"
2729
#import <Foundation/Foundation.h>
2830
#import "OneSignalUserDefaults.h"
2931
#import "OneSignalCommonDefines.h"

‎iOS_SDK/OneSignalSDK/OneSignalCore/Source/OneSignalCoreHelper.h‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,9 @@
2626
*/
2727

2828
@interface OneSignalCoreHelper : NSObject
29+
#pragma clang diagnostic ignored "-Wstrict-prototypes"
30+
#pragma clang diagnostic ignored "-Wnullability-completeness"
31+
2932
// Threading
3033
+ (void)runOnMainThread:(void(^)())block;
3134
+ (void)dispatch_async_on_main_queue:(void(^)())block;

‎iOS_SDK/OneSignalSDK/OneSignalCore/Source/OneSignalTrackFirebaseAnalytics.m‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ + (void)init {
5252

5353

5454
+ (void)updateFromDownloadParams:(NSDictionary*)params {
55-
trackingEnabled = (BOOL)params[@"fba"];
55+
trackingEnabled = [params[@"fba"] boolValue];
5656
OneSignalUserDefaults *sharedUserDefaults = OneSignalUserDefaults.initShared;
5757
if (trackingEnabled)
5858
[sharedUserDefaults saveBoolForKey:ONESIGNAL_FB_ENABLE_FIREBASE withValue:YES];

‎iOS_SDK/OneSignalSDK/OneSignalExtension/OneSignalAttachmentHandler.h‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
#import <UserNotifications/UserNotifications.h>
3030

3131
@interface OneSignalAttachmentHandler : NSObject
32+
3233
+ (void)addAttachments:(OSNotification*)notification toNotificationContent:(UNMutableNotificationContent*)content;
3334
+ (void)addActionButtons:(OSNotification*)notification toNotificationContent:(UNMutableNotificationContent*)content;
3435
+ (UNNotificationAction *)createActionForButton:(NSDictionary *)button;

0 commit comments

Comments
 (0)