Fix Private API

• In a recent update, we added a method called valueForQueryParameter() that extracted URL query parameters from URLs
• It appears that Apple has a private API with a similar name and blocks all app uploads using this method name...
• Resolved by renaming to valueFromQueryParameter()

Author: Nightsd01

iOS_SDK/OneSignalSDK/Source/NSURL+OneSignal.h

@@ -29,6 +29,6 @@
 
 @interface NSURL (OneSignal)
 
-- (NSString *)valueForQueryParameter:(NSString *)parameter;
+- (NSString *)valueFromQueryParameter:(NSString *)parameter;
 
 @end

iOS_SDK/OneSignalSDK/Source/NSURL+OneSignal.m

@@ -28,7 +28,7 @@
 #import "NSURL+OneSignal.h"
 
 @implementation NSURL (OneSignal)
-- (NSString *)valueForQueryParameter:(NSString *)parameter {
+- (NSString *)valueFromQueryParameter:(NSString *)parameter {
     NSURLComponents *components = [NSURLComponents componentsWithURL:self resolvingAgainstBaseURL:false];
 
     for(NSURLQueryItem *item in components.queryItems)

iOS_SDK/OneSignalSDK/Source/OneSignalHelper.m

@@ -767,7 +767,7 @@ + (NSString*)downloadMediaAndSaveInBundle:(NSString*)urlString {
             if (mimeType != nil && ![mimeType isEqualToString:@""]) {
                 newExtension = mimeType.fileExtensionForMimeType;
             } else {
-                newExtension = [[[NSURL URLWithString:urlString] valueForQueryParameter:@"filename"] supportedFileExtension];
+                newExtension = [[[NSURL URLWithString:urlString] valueFromQueryParameter:@"filename"] supportedFileExtension];
             }
 
             if (!newExtension || ![ONESIGNAL_SUPPORTED_ATTACHMENT_TYPES containsObject:newExtension])