Skip to content

Commit 7dc63b4

Browse files
authored
Merge pull request #1286 from casey-chow/main
Make web views inspectable
2 parents 789b339 + bf777de commit 7dc63b4

File tree

4 files changed

+13
-0
lines changed

4 files changed

+13
-0
lines changed

iOS_SDK/OneSignalSDK/OneSignalCore/Source/OneSignalLog.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ typedef NS_ENUM(NSUInteger, ONE_S_LOG_LEVEL) {
3939
};
4040

4141
+ (void)setLogLevel:(ONE_S_LOG_LEVEL)logLevel;
42+
+ (ONE_S_LOG_LEVEL)getLogLevel;
4243
+ (void)onesignalLog:(ONE_S_LOG_LEVEL)logLevel message:(NSString* _Nonnull)message;
4344

4445
@end

iOS_SDK/OneSignalSDK/OneSignalCore/Source/OneSignalLog.m

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@ + (void)setLogLevel:(ONE_S_LOG_LEVEL)nsLogLevel {
3636
_nsLogLevel = nsLogLevel;
3737
}
3838

39+
+ (ONE_S_LOG_LEVEL)getLogLevel {
40+
return _nsLogLevel;
41+
}
42+
3943
+ (void) onesignal_Log:(ONE_S_LOG_LEVEL)logLevel message:(NSString*) message {
4044
onesignal_Log(logLevel, message);
4145
}

iOS_SDK/OneSignalSDK/Source/OSInAppMessageView.m

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,10 @@ - (void)setupWebviewWithMessageHandler:(id<WKScriptMessageHandler>)handler {
110110
self.webView = [[WKWebView alloc] initWithFrame:mainBounds configuration:configuration];
111111
self.webView.backgroundColor = [UIColor clearColor];
112112
self.webView.opaque = NO;
113+
// https://webkit.org/blog/13936/enabling-the-inspection-of-web-content-in-apps/
114+
if (@available(macOS 13.3, iOS 16.4, *) && [OneSignalLog getLogLevel] >= ONE_S_LL_DEBUG) {
115+
self.webView.inspectable = YES;
116+
}
113117
[self addSubview:self.webView];
114118

115119
[self layoutIfNeeded];

iOS_SDK/OneSignalSDK/Source/OneSignalWebView.m

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,10 @@ - (void)viewDidLoad {
4141

4242
_webView = [WKWebView new];
4343
_webView.navigationDelegate = self;
44+
// https://webkit.org/blog/13936/enabling-the-inspection-of-web-content-in-apps/
45+
if (@available(macOS 13.3, iOS 16.4, *) && [OneSignalLog getLogLevel] >= ONE_S_LL_DEBUG) {
46+
_webView.inspectable = YES;
47+
}
4448
[self.view addSubview:_webView];
4549

4650
[self pinSubviewToMarginsWithSubview:_webView withSuperview:self.view];

0 commit comments

Comments
 (0)