setting sessionManager delegate as nullable

Setting OneSignal as sessionManager delegate in init

Author: emawby

iOS_SDK/OneSignalSDK/OneSignalOutcomes/Source/OutcomeEvents/OSSessionManager.h

@@ -38,9 +38,9 @@
 
 + (OSSessionManager*)sharedSessionManager;
 
-@property (nonatomic) id<SessionStatusDelegate> _Nonnull delegate;
+@property (nonatomic) id<SessionStatusDelegate> _Nullable delegate;
 
-- (instancetype _Nonnull)init:(Class<SessionStatusDelegate> _Nonnull)delegate withTrackerFactory:(OSTrackerFactory *_Nonnull)trackerFactory;
+- (instancetype _Nonnull)init:(Class<SessionStatusDelegate> _Nullable)delegate withTrackerFactory:(OSTrackerFactory *_Nonnull)trackerFactory;
 
 - (NSArray<OSInfluence *> *_Nonnull)getInfluences;
 - (NSArray<OSInfluence *> *_Nonnull)getSessionInfluences;

iOS_SDK/OneSignalSDK/OneSignalOutcomes/Source/OutcomeEvents/OSSessionManager.m

@@ -41,7 +41,7 @@ @implementation OSSessionManager
 static OSSessionManager *_sessionManager;
 + (OSSessionManager*)sharedSessionManager {
     if (!_sessionManager)
-        _sessionManager = [[OSSessionManager alloc] init:self withTrackerFactory:[OSTrackerFactory sharedTrackerFactory]];
+        _sessionManager = [[OSSessionManager alloc] init:nil withTrackerFactory:[OSTrackerFactory sharedTrackerFactory]];
     return _sessionManager;
 }
 
@@ -255,7 +255,7 @@ - (BOOL)willChangeSessionForChannel:(OSChannelTracker *)channelTracker withInflu
 - (void)sendSessionEndingWithInfluences:(NSArray<OSInfluence *> *)endingInfluences {
     [OneSignalLog onesignalLog:ONE_S_LL_DEBUG message:[NSString stringWithFormat:@"OneSignal SessionManager sendSessionEndingWithInfluences with influences: %@", endingInfluences.description]];
     // Only end session if there are influences available to end
-    if (endingInfluences.count > 0 && _delegate)
+    if (endingInfluences.count > 0 && _delegate && [_delegate respondsToSelector:@selector(onSessionEnding:)])
         [_delegate onSessionEnding:endingInfluences];
 }
 

iOS_SDK/OneSignalSDK/Source/OneSignal.m

@@ -695,6 +695,8 @@ + (void)setInAppMessageLifecycleHandler:(NSObject<OSInAppMessageLifecycleHandler
  */
 + (void)init {
     [[OSMigrationController new] migrate];
+    // using classes as delegates is not best practice. We should consider using a shared instance of a class instead
+    [OSSessionManager sharedSessionManager].delegate = (id<SessionStatusDelegate>)self;
     if ([self requiresUserPrivacyConsent]) {
         [OneSignalLog onesignalLog:ONE_S_LL_VERBOSE message:@"Delayed initialization of the OneSignal SDK until the user provides privacy consent using the consentGranted() method"];
         delayedInitializationForPrivacyConsent = true;
@@ -1788,7 +1790,6 @@ + (void)registerUserInternal {
         return;
 
     [_outcomeEventsController clearOutcomes];
-    [OSSessionManager sharedSessionManager].delegate = self;
     [[OSSessionManager sharedSessionManager] restartSessionIfNeeded:_appEntryState];
 
     [OneSignalTrackFirebaseAnalytics trackInfluenceOpenEvent];