Skip to content

Commit 90d47fc

Browse files
rgomezpemawby
authored andcommitted
Renamed Session type to OSSession to avoid cross-package conflicts
1 parent 8b35b1b commit 90d47fc

File tree

7 files changed

+11
-11
lines changed

7 files changed

+11
-11
lines changed

iOS_SDK/OneSignalSDK/Source/OSIndirectInfluence.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,21 @@
11
/**
22
Modified MIT License
3-
3+
44
Copyright 2019 OneSignal
5-
5+
66
Permission is hereby granted, free of charge, to any person obtaining a copy
77
of this software and associated documentation files (the "Software"), to deal
88
in the Software without restriction, including without limitation the rights
99
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
1010
copies of the Software, and to permit persons to whom the Software is
1111
furnished to do so, subject to the following conditions:
12-
12+
1313
1. The above copyright notice and this permission notice shall be included in
1414
all copies or substantial portions of the Software.
15-
15+
1616
2. All copies of substantial portions of the Software may only be used in connection
1717
with services provided by OneSignal.
18-
18+
1919
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
2020
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
2121
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE

iOS_SDK/OneSignalSDK/Source/OSOutcomeEvent.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232

3333
@interface OSOutcomeEvent () <OSJSONEncodable>
3434

35-
- (id _Nonnull)initWithSession:(Session)session
35+
- (id _Nonnull)initWithSession:(OSSession)session
3636
notificationIds:(NSArray * _Nullable)notificationIds
3737
name:(NSString * _Nonnull)name
3838
timestamp:(NSNumber * _Nonnull)timestamp

iOS_SDK/OneSignalSDK/Source/OSOutcomeEvent.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ of this software and associated documentation files (the "Software"), to deal
3131

3232
@implementation OSOutcomeEvent
3333

34-
- (id _Nonnull)initWithSession:(Session)influenceType
34+
- (id _Nonnull)initWithSession:(OSSession)influenceType
3535
notificationIds:(NSArray * _Nullable)notificationIds
3636
name:(NSString * _Nonnull)name
3737
timestamp:(NSNumber * _Nonnull)timestamp
@@ -52,7 +52,7 @@ - (id)initFromOutcomeEventParams:(OSOutcomeEventParams *)outcomeEventParams {
5252
OSOutcomeSource *source = outcomeEventParams.outcomeSource;
5353
Session influenceType = UNATTRIBUTED;
5454
NSArray *notificationId = nil;
55-
55+
5656
if (source) {
5757
if (source.directBody && source.directBody.notificationIds && source.directBody.notificationIds.count > 0) {
5858
influenceType = DIRECT;
@@ -62,7 +62,7 @@ - (id)initFromOutcomeEventParams:(OSOutcomeEventParams *)outcomeEventParams {
6262
notificationId = source.indirectBody.notificationIds;
6363
}
6464
}
65-
65+
6666
_session = influenceType;
6767
_notificationIds = notificationId;
6868
_name = outcomeEventParams.outcomeId;

iOS_SDK/OneSignalSDK/Source/OSOutcomesUtils.h

Whitespace-only changes.

iOS_SDK/OneSignalSDK/Source/OSOutcomesUtils.m

Whitespace-only changes.

iOS_SDK/OneSignalSDK/Source/OneSignal.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ typedef NS_ENUM(NSUInteger, OSNotificationActionType) {
210210
// Pass in nil means a notification will not display
211211
typedef void (^OSNotificationDisplayResponse)(OSNotification* _Nullable notification);
212212
/* OneSignal Influence Types */
213-
typedef NS_ENUM(NSUInteger, Session) {
213+
typedef NS_ENUM(NSUInteger, OSSession) {
214214
DIRECT,
215215
INDIRECT,
216216
UNATTRIBUTED,
@@ -225,7 +225,7 @@ typedef NS_ENUM(NSUInteger, OSInfluenceChannel) {
225225
@interface OSOutcomeEvent : NSObject
226226

227227
// Session enum (DIRECT, INDIRECT, UNATTRIBUTED, or DISABLED) to determine code route and request params
228-
@property (nonatomic) Session session;
228+
@property (nonatomic) OSSession session;
229229

230230
// Notification ids for the current session
231231
@property (strong, nonatomic, nullable) NSArray *notificationIds;

iOS_SDK/OneSignalSDK/Source/OneSignalSessionManager.m

Whitespace-only changes.

0 commit comments

Comments
 (0)