Skip to content

Commit 91d6096

Browse files
committed
address PR comments
* Move clearing local data inside the `if response` block. * We don't know what it would mean to have a successful yet `nil` response, or if this can even happen, so it is better to not make any local changes in that case.
1 parent baba4c1 commit 91d6096

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

iOS_SDK/OneSignalSDK/OneSignalUser/Source/OSUserRequests.swift

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -266,10 +266,9 @@ class OSUserExecutor {
266266
}
267267

268268
OneSignalClient.shared().execute(request) { response in
269-
// Clear local data in preparation for hydration
270-
OneSignalUserManagerImpl.sharedInstance.clearUserData()
271-
272269
if let response = response {
270+
// Clear local data in preparation for hydration
271+
OneSignalUserManagerImpl.sharedInstance.clearUserData()
273272
parseFetchUserResponse(response: response, identityModel: request.identityModel, originalPushToken: OneSignalUserManagerImpl.sharedInstance.token)
274273
}
275274
} onFailure: { _ in

0 commit comments

Comments
 (0)