Merge pull request #970 from OneSignal/fix/always_set_badge_on_main_thread

emawby · web-flow · commit 94b7475c3dbf · 2021-08-05T15:12:01.000-07:00
Running setApplicationIconBadgeNumber on mainThread
diff --git a/iOS_SDK/OneSignalSDK/Source/OneSignal.m b/iOS_SDK/OneSignalSDK/Source/OneSignal.m
@@ -2221,7 +2221,9 @@ + (BOOL)clearBadgeCount:(BOOL)fromNotifOpened {
     bool wasBadgeSet = [UIApplication sharedApplication].applicationIconBadgeNumber > 0;
     
     if (fromNotifOpened || wasBadgeSet) {
-        [[UIApplication sharedApplication] setApplicationIconBadgeNumber:0];
+        [OneSignalHelper runOnMainThread:^{
+            [[UIApplication sharedApplication] setApplicationIconBadgeNumber:0];
+        }];
     }
 
     return wasBadgeSet;

Original file line number	Diff line number	Diff line change
`@@ -2221,7 +2221,9 @@ + (BOOL)clearBadgeCount:(BOOL)fromNotifOpened {`
`2221`	`2221`	`bool wasBadgeSet = [UIApplication sharedApplication].applicationIconBadgeNumber > 0;`
`2222`	`2222`
`2223`	`2223`	`if (fromNotifOpened \|\| wasBadgeSet) {`
`2224`		`- [[UIApplication sharedApplication] setApplicationIconBadgeNumber:0];`
	`2224`	`+ [OneSignalHelper runOnMainThread:^{`
	`2225`	`+ [[UIApplication sharedApplication] setApplicationIconBadgeNumber:0];`
	`2226`	`+ }];`
`2225`	`2227`	`}`
`2226`	`2228`
`2227`	`2229`	`return wasBadgeSet;`